)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"42c76836c79c2c3e7d453166facb37161351af0d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Wilson Liu \u003cliuxinguo@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-13 21:32:20 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use function instead of duplicated code in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Use a function _get_id_from_result() instead of lots of"},{"line_number":10,"context_line":"duplicated code."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_53f193cc","line":7,"updated":"2015-09-13 17:38:44.000000000","message":"The first line should be limited to 50 characters","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"}],"cinder/tests/unit/test_huawei_drivers.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"d0a40f4efbb32c5b8697bda0b8e43089c0bdfbe1","unresolved":false,"context_lines":[{"line_number":2083,"context_line":"    def test_get_id_from_result(self):"},{"line_number":2084,"context_line":"        self.driver.restclient.login()"},{"line_number":2085,"context_line":"        result \u003d {}"},{"line_number":2086,"context_line":"        name \u003d \u0027test_name\u0027"},{"line_number":2087,"context_line":"        key \u003d \u0027NAME\u0027"},{"line_number":2088,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(resule, name, key)"},{"line_number":2089,"context_line":"        self.assertIsNone(re)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_af76663c","line":2086,"updated":"2015-09-14 16:57:42.000000000","message":"it doesn\u0027t seem like you need to redeclare these multiple times. The values remain the same, just the result var changes.","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"ae8d8a23e642a14b2c2e98b1cc7d5cd96b4e796e","unresolved":false,"context_lines":[{"line_number":2085,"context_line":"        result \u003d {}"},{"line_number":2086,"context_line":"        name \u003d \u0027test_name\u0027"},{"line_number":2087,"context_line":"        key \u003d \u0027NAME\u0027"},{"line_number":2088,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(resule, name, key)"},{"line_number":2089,"context_line":"        self.assertIsNone(re)"},{"line_number":2090,"context_line":""},{"line_number":2091,"context_line":"        result \u003d {\u0027data\u0027:{}}"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_2087d510","line":2088,"updated":"2015-09-14 12:15:07.000000000","message":"s/resule/result","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"ae8d8a23e642a14b2c2e98b1cc7d5cd96b4e796e","unresolved":false,"context_lines":[{"line_number":2088,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(resule, name, key)"},{"line_number":2089,"context_line":"        self.assertIsNone(re)"},{"line_number":2090,"context_line":""},{"line_number":2091,"context_line":"        result \u003d {\u0027data\u0027:{}}"},{"line_number":2092,"context_line":"        name \u003d \u0027test_name\u0027"},{"line_number":2093,"context_line":"        key \u003d \u0027NAME\u0027"},{"line_number":2094,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(resule, name, key)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_408f6923","line":2091,"updated":"2015-09-14 12:15:07.000000000","message":"Add space after \":\" for all the occurrences below.\n\nEx. result \u003d {\u0027data\u0027: {}}","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"ae8d8a23e642a14b2c2e98b1cc7d5cd96b4e796e","unresolved":false,"context_lines":[{"line_number":2091,"context_line":"        result \u003d {\u0027data\u0027:{}}"},{"line_number":2092,"context_line":"        name \u003d \u0027test_name\u0027"},{"line_number":2093,"context_line":"        key \u003d \u0027NAME\u0027"},{"line_number":2094,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(resule, name, key)"},{"line_number":2095,"context_line":"        self.assertIsNone(re)"},{"line_number":2096,"context_line":""},{"line_number":2097,"context_line":"        result \u003d {\u0027data\u0027:{\u0027COUNT\u0027: 1, \u0027ID\u0027: \u00271\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_60170da4","line":2094,"updated":"2015-09-14 12:15:07.000000000","message":"s/resule/result","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"ae8d8a23e642a14b2c2e98b1cc7d5cd96b4e796e","unresolved":false,"context_lines":[{"line_number":2098,"context_line":"                          \u0027COUNT\u0027: 2, \u0027ID\u0027: \u00272\u0027}"},{"line_number":2099,"context_line":"        name \u003d \u0027test_name\u0027"},{"line_number":2100,"context_line":"        key \u003d \u0027NAME\u0027"},{"line_number":2101,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(resule, name, key)"},{"line_number":2102,"context_line":"        self.assertIsNone(re)"},{"line_number":2103,"context_line":""},{"line_number":2104,"context_line":"        result \u003d {\u0027data\u0027:{\u0027NAME\u0027: \u0027test_name1\u0027, \u0027ID\u0027: \u00271\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_201115ad","line":2101,"updated":"2015-09-14 12:15:07.000000000","message":"s/resule/result","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"ae8d8a23e642a14b2c2e98b1cc7d5cd96b4e796e","unresolved":false,"context_lines":[{"line_number":2105,"context_line":"                          \u0027NAME\u0027: \u0027test_name2\u0027, \u0027ID\u0027: \u00272\u0027}"},{"line_number":2106,"context_line":"        name \u003d \u0027test_name\u0027"},{"line_number":2107,"context_line":"        key \u003d \u0027NAME\u0027"},{"line_number":2108,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(resule, name, key)"},{"line_number":2109,"context_line":"        self.assertIsNone(re)"},{"line_number":2110,"context_line":""},{"line_number":2111,"context_line":"        result \u003d {\u0027data\u0027:{\u0027NAME\u0027: \u0027test_name\u0027, \u0027ID\u0027: \u00271\u0027},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_802021f9","line":2108,"updated":"2015-09-14 12:15:07.000000000","message":"s/resule/result","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"ae8d8a23e642a14b2c2e98b1cc7d5cd96b4e796e","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"                          \u0027NAME\u0027: \u0027test_name2\u0027, \u0027ID\u0027: \u00272\u0027}"},{"line_number":2113,"context_line":"        name \u003d \u0027test_name\u0027"},{"line_number":2114,"context_line":"        key \u003d \u0027NAME\u0027"},{"line_number":2115,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(resule, name, key)"},{"line_number":2116,"context_line":"        self.assertEqual(\u00271\u0027, re)"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":"    def create_fake_conf_file(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e0231d04","line":2115,"updated":"2015-09-14 12:15:07.000000000","message":"s/resule/result","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"58c86f7b3173ca5402451a09882300b6044c6179","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"    def test_get_id_from_result(self):"},{"line_number":2113,"context_line":"        self.driver.restclient.login()"},{"line_number":2114,"context_line":"        result \u003d {}"},{"line_number":2115,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(result, name, key)"},{"line_number":2116,"context_line":"        self.assertIsNone(re)"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":"        result \u003d {\u0027data\u0027: {}}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_e6d48448","line":2115,"updated":"2015-09-21 15:15:37.000000000","message":"name and key are not defined in this test. This call and the 4 others will fail","commit_id":"08f4c3381287568260105937c1b1e89e121f28fe"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"845d478974446b0e35da7038dbb208fc870f3205","unresolved":false,"context_lines":[{"line_number":2142,"context_line":""},{"line_number":2143,"context_line":"        result \u003d {\u0027data\u0027: [{\u0027NAME\u0027: \u0027test_name\u0027, \u0027ID\u0027: \u00271\u0027},"},{"line_number":2144,"context_line":"                           {\u0027NAME\u0027: \u0027test_name2\u0027, \u0027ID\u0027: \u00272\u0027}]}"},{"line_number":2145,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(result, name, key)"},{"line_number":2146,"context_line":"        self.assertEqual(\u00271\u0027, re)"},{"line_number":2147,"context_line":""},{"line_number":2148,"context_line":"    def create_fake_conf_file(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_1105a578","line":2145,"updated":"2015-09-24 07:40:49.000000000","message":"I just wonder this whether  there is a  case as follow:\n\n        result \u003d {\u0027data\u0027: [{\u0027NAME\u0027: \u0027test_name1\u0027},     \n                  {\u0027NAME\u0027: \u0027test_name2\u0027}]}\n\n \"NAME\" in result, but no \"ID\" in it?\n\nand what\u0027s the result of _get_id_from_result  call?","commit_id":"8d5cd04f08e944c195341785d10217f36bc1dd5c"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"024956e80abf1830c8a0203d14a3e1abd6592bda","unresolved":false,"context_lines":[{"line_number":2142,"context_line":""},{"line_number":2143,"context_line":"        result \u003d {\u0027data\u0027: [{\u0027NAME\u0027: \u0027test_name\u0027, \u0027ID\u0027: \u00271\u0027},"},{"line_number":2144,"context_line":"                           {\u0027NAME\u0027: \u0027test_name2\u0027, \u0027ID\u0027: \u00272\u0027}]}"},{"line_number":2145,"context_line":"        re \u003d self.driver.restclient._get_id_from_result(result, name, key)"},{"line_number":2146,"context_line":"        self.assertEqual(\u00271\u0027, re)"},{"line_number":2147,"context_line":""},{"line_number":2148,"context_line":"    def create_fake_conf_file(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba15a1d1_ac94a28a","line":2145,"in_reply_to":"ba15a1d1_1105a578","updated":"2015-09-24 07:46:00.000000000","message":"If there is a \"NAME\" in the result, there must be a \"ID\" in it too, this is guaranteed by the storage array.","commit_id":"8d5cd04f08e944c195341785d10217f36bc1dd5c"}],"cinder/volume/drivers/huawei/rest_client.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"ae8d8a23e642a14b2c2e98b1cc7d5cd96b4e796e","unresolved":false,"context_lines":[{"line_number":598,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":599,"context_line":"        self._assert_rest_result(result, _(\u0027Check hostgroup associate error.\u0027))"},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"        if self._get_id_from_result(result, host_id, \u0027ID\u0027)"},{"line_number":602,"context_line":"            return True"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_00ddf141","line":601,"updated":"2015-09-14 12:15:07.000000000","message":"Please add : after if statement.\n\nif self._get_id_from_result(result, host_id, \u0027ID\u0027):","commit_id":"b0044a38b887f069db2a2ec1d53e116e437c4c90"}]}