)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b382cddc20e998f21cfba330765ee3cf31525a7b","unresolved":false,"context_lines":[{"line_number":601,"context_line":"            # NOTE(jdg): In the case of \"name\" we can\u0027t"},{"line_number":602,"context_line":"            # update that on manage/import, so we use"},{"line_number":603,"context_line":"            # the uuid attribute"},{"line_number":604,"context_line":"            meta \u003d v.get(\u0027attributes\u0027, None)"},{"line_number":605,"context_line":"            alt_id \u003d \u0027\u0027"},{"line_number":606,"context_line":"            if meta:"},{"line_number":607,"context_line":"                alt_id \u003d meta.get(\u0027uuid\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_94870061","line":604,"updated":"2015-09-14 13:07:40.000000000","message":"If attributes is not present, the default from v.get(\u0027attributes\u0027) will be None, so no need to add None as the default value.","commit_id":"a6219be698dc6b4fddf4a343c3c642895dd22bf3"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e8cce4feaee56b42eb5b9ac2d34fdbc9380c39e1","unresolved":false,"context_lines":[{"line_number":601,"context_line":"            # NOTE(jdg): In the case of \"name\" we can\u0027t"},{"line_number":602,"context_line":"            # update that on manage/import, so we use"},{"line_number":603,"context_line":"            # the uuid attribute"},{"line_number":604,"context_line":"            meta \u003d v.get(\u0027attributes\u0027, None)"},{"line_number":605,"context_line":"            alt_id \u003d \u0027\u0027"},{"line_number":606,"context_line":"            if meta:"},{"line_number":607,"context_line":"                alt_id \u003d meta.get(\u0027uuid\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_da0041ad","line":604,"in_reply_to":"ba15a1d1_94870061","updated":"2015-09-14 13:50:31.000000000","message":"Indeed, force of habit now I almost ALWAYS explicitly set something there.  I\u0027ll change it here, thanks!","commit_id":"a6219be698dc6b4fddf4a343c3c642895dd22bf3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cd7bca2c0323822b2701d5c38711707b58b32215","unresolved":false,"context_lines":[{"line_number":601,"context_line":"            # NOTE(jdg): In the case of \"name\" we can\u0027t"},{"line_number":602,"context_line":"            # update that on manage/import, so we use"},{"line_number":603,"context_line":"            # the uuid attribute"},{"line_number":604,"context_line":"            meta \u003d v.get(\u0027attributes\u0027, None)"},{"line_number":605,"context_line":"            alt_id \u003d \u0027\u0027"},{"line_number":606,"context_line":"            if meta:"},{"line_number":607,"context_line":"                alt_id \u003d meta.get(\u0027uuid\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba15a1d1_5ded0b8a","line":604,"in_reply_to":"ba15a1d1_da0041ad","updated":"2015-09-14 14:17:48.000000000","message":"FWIW, I think the idea of explicitly setting something is more obvious and probably safer. I know in general there\u0027s been a push to get rid of redundant cases of setting None, so my only concern here was consistency with what we\u0027re doing elsewhere.","commit_id":"a6219be698dc6b4fddf4a343c3c642895dd22bf3"}]}