)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"62625ebce2a21b6f26e51f0b5d2be0070c9ec5c1","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retype enhancement for EMC VNX cinder driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch can avoid lun migration when the user only wants to"},{"line_number":10,"context_line":"turn on compression on a lun."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I155272d1130ac0048d226742970e021118f2f123"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_24b52d30","line":9,"updated":"2015-09-16 19:09:05.000000000","message":"Suggest: \"This patch enables the compression of a lun without migration.\" ? I am a little confused by this sentence. Can you rephrase or add more to help clarify here? Thanks!","commit_id":"bfbfce622b66108f48cb5a3fa94f64f23710e9d3"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"6424841f5794d9f65f0eaa1575d26b93886a1456","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Retype enhancement for EMC VNX cinder driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch can avoid lun migration when the user only wants to"},{"line_number":10,"context_line":"turn on compression on a lun."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I155272d1130ac0048d226742970e021118f2f123"},{"line_number":13,"context_line":"Closes-Bug: #1495802"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba15a1d1_d780a1c2","line":10,"updated":"2015-09-16 20:13:06.000000000","message":"I agree with Kendall that this sentence is a bit confusing. I think adding a bit more information to that sentence along with the problem this patch is addressing would be very helpful.","commit_id":"bfbfce622b66108f48cb5a3fa94f64f23710e9d3"}],"cinder/tests/unit/test_emc_vnxdirect.py":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"6424841f5794d9f65f0eaa1575d26b93886a1456","unresolved":false,"context_lines":[{"line_number":3151,"context_line":"        retyped \u003d self.driver.retype(None, self.testData.test_volume3,"},{"line_number":3152,"context_line":"                                     new_type_data, None, host_test_data)"},{"line_number":3153,"context_line":"        self.assertFalse(retyped,"},{"line_number":3154,"context_line":"                         \"Retype should failed due to\""},{"line_number":3155,"context_line":"                         \"the volume has snapshot\")"},{"line_number":3156,"context_line":""},{"line_number":3157,"context_line":"    @mock.patch("}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_dad76849","line":3154,"updated":"2015-09-16 20:13:06.000000000","message":"Should there be a space at the end of this line after \u0027to\u0027?","commit_id":"bfbfce622b66108f48cb5a3fa94f64f23710e9d3"}],"cinder/volume/drivers/emc/emc_vnx_cli.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"62625ebce2a21b6f26e51f0b5d2be0070c9ec5c1","unresolved":false,"context_lines":[{"line_number":2293,"context_line":"            # Reject if volume has snapshot when migration is needed"},{"line_number":2294,"context_line":"            if changes[\u0027migration\u0027]:"},{"line_number":2295,"context_line":"                LOG.debug(\u0027Driver is not able to do retype because the volume \u0027"},{"line_number":2296,"context_line":"                          \u0027has snapshot which is forbidden to migrate.\u0027)"},{"line_number":2297,"context_line":"                return False"},{"line_number":2298,"context_line":"            # Reject if volume has snapshot when trying to"},{"line_number":2299,"context_line":"            # turn on compression"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_c428f188","line":2296,"updated":"2015-09-16 19:09:05.000000000","message":"Suggest: \"...has a snapshot...\"","commit_id":"bfbfce622b66108f48cb5a3fa94f64f23710e9d3"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"62625ebce2a21b6f26e51f0b5d2be0070c9ec5c1","unresolved":false,"context_lines":[{"line_number":2299,"context_line":"            # turn on compression"},{"line_number":2300,"context_line":"            if changes[\u0027compression_on\u0027]:"},{"line_number":2301,"context_line":"                LOG.debug(\u0027Driver is not able to do retype because the volume \u0027"},{"line_number":2302,"context_line":"                          \u0027has snapshot which is forbidden to turn on \u0027"},{"line_number":2303,"context_line":"                          \u0027compression.\u0027)"},{"line_number":2304,"context_line":"                return False"},{"line_number":2305,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_841e795d","line":2302,"updated":"2015-09-16 19:09:05.000000000","message":"Ditto.","commit_id":"bfbfce622b66108f48cb5a3fa94f64f23710e9d3"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cc084f2ab528eaf57f39f97a85f6684fcad61d6a","unresolved":false,"context_lines":[{"line_number":2293,"context_line":"            # Reject if volume has snapshot when migration is needed"},{"line_number":2294,"context_line":"            if changes[\u0027migration\u0027]:"},{"line_number":2295,"context_line":"                LOG.debug(\u0027Driver is not able to do retype because the volume \u0027"},{"line_number":2296,"context_line":"                          \u0027has a snapshot which is forbidden to migrate.\u0027)"},{"line_number":2297,"context_line":"                return False"},{"line_number":2298,"context_line":"            # Reject if volume has snapshot when trying to"},{"line_number":2299,"context_line":"            # turn on compression"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_65344afb","line":2296,"updated":"2015-09-17 18:51:53.000000000","message":"Please, add volume ID to log message. It will be helpful for debugging and troubleshooting.","commit_id":"39a25d186a71aab15045343c59274a807b48cc56"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"578828575810931518b770640c17140174da6be5","unresolved":false,"context_lines":[{"line_number":2293,"context_line":"            # Reject if volume has snapshot when migration is needed"},{"line_number":2294,"context_line":"            if changes[\u0027migration\u0027]:"},{"line_number":2295,"context_line":"                LOG.debug(\u0027Driver is not able to do retype because the volume \u0027"},{"line_number":2296,"context_line":"                          \u0027has a snapshot which is forbidden to migrate.\u0027)"},{"line_number":2297,"context_line":"                return False"},{"line_number":2298,"context_line":"            # Reject if volume has snapshot when trying to"},{"line_number":2299,"context_line":"            # turn on compression"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_b1ffbda9","line":2296,"in_reply_to":"ba15a1d1_65344afb","updated":"2015-09-21 02:23:40.000000000","message":"Are you saying the ID in OpenStack or in the array?","commit_id":"39a25d186a71aab15045343c59274a807b48cc56"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"2fb4bd34adb16604b882a61ae859f20b0a06771e","unresolved":false,"context_lines":[{"line_number":2293,"context_line":"            # Reject if volume has snapshot when migration is needed"},{"line_number":2294,"context_line":"            if changes[\u0027migration\u0027]:"},{"line_number":2295,"context_line":"                LOG.debug(\u0027Driver is not able to do retype because the volume \u0027"},{"line_number":2296,"context_line":"                          \u0027has a snapshot which is forbidden to migrate.\u0027)"},{"line_number":2297,"context_line":"                return False"},{"line_number":2298,"context_line":"            # Reject if volume has snapshot when trying to"},{"line_number":2299,"context_line":"            # turn on compression"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_4581bb4c","line":2296,"in_reply_to":"ba15a1d1_b1ffbda9","updated":"2015-09-21 07:37:09.000000000","message":"I mean OpenStack Cinder ID. But if you think that array\u0027s ID will be useful to debug - it could be added too.","commit_id":"39a25d186a71aab15045343c59274a807b48cc56"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cc084f2ab528eaf57f39f97a85f6684fcad61d6a","unresolved":false,"context_lines":[{"line_number":2298,"context_line":"            # Reject if volume has snapshot when trying to"},{"line_number":2299,"context_line":"            # turn on compression"},{"line_number":2300,"context_line":"            if changes[\u0027compression_on\u0027]:"},{"line_number":2301,"context_line":"                LOG.debug(\u0027Driver is not able to do retype because the volume \u0027"},{"line_number":2302,"context_line":"                          \u0027has a snapshot which is forbidden to turn on \u0027"},{"line_number":2303,"context_line":"                          \u0027compression.\u0027)"},{"line_number":2304,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_85371efe","line":2301,"updated":"2015-09-17 18:51:53.000000000","message":"The same as above","commit_id":"39a25d186a71aab15045343c59274a807b48cc56"},{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"578828575810931518b770640c17140174da6be5","unresolved":false,"context_lines":[{"line_number":2298,"context_line":"            # Reject if volume has snapshot when trying to"},{"line_number":2299,"context_line":"            # turn on compression"},{"line_number":2300,"context_line":"            if changes[\u0027compression_on\u0027]:"},{"line_number":2301,"context_line":"                LOG.debug(\u0027Driver is not able to do retype because the volume \u0027"},{"line_number":2302,"context_line":"                          \u0027has a snapshot which is forbidden to turn on \u0027"},{"line_number":2303,"context_line":"                          \u0027compression.\u0027)"},{"line_number":2304,"context_line":"                return False"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_512bc133","line":2301,"in_reply_to":"ba15a1d1_85371efe","updated":"2015-09-21 02:23:40.000000000","message":"Done","commit_id":"39a25d186a71aab15045343c59274a807b48cc56"}]}