)]}'
{"cinder/volume/drivers/netapp/dataontap/nfs_cmode.py":[{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"282126b0e6c8a692514ea8d46160f870e581bc27","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    def _delete_backing_file_for_volume(self, volume):"},{"line_number":347,"context_line":"        \"\"\"Deletes file on nfs share that backs a cinder volume.\"\"\""},{"line_number":348,"context_line":"        try:"},{"line_number":349,"context_line":"            LOG.debug(\u0027Deleting backing file for volume %s\u0027, volume[\u0027id\u0027])"},{"line_number":350,"context_line":"            self._delete_volume_on_filer(volume)"},{"line_number":351,"context_line":"        except Exception:"},{"line_number":352,"context_line":"            LOG.exception(_LE(\u0027Could not do delete of volume %s on filer, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_b50d77ea","line":349,"updated":"2015-09-19 06:48:35.000000000","message":"Add a \u0027.\u0027 to the EOL.","commit_id":"f02636774cb179cce2bf1040e3eb8098501c380c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d1c87182a8b8634c3a9d6468184b1ae90d117e7e","unresolved":false,"context_lines":[{"line_number":346,"context_line":"    def _delete_backing_file_for_volume(self, volume):"},{"line_number":347,"context_line":"        \"\"\"Deletes file on nfs share that backs a cinder volume.\"\"\""},{"line_number":348,"context_line":"        try:"},{"line_number":349,"context_line":"            LOG.debug(\u0027Deleting backing file for volume %s\u0027, volume[\u0027id\u0027])"},{"line_number":350,"context_line":"            self._delete_volume_on_filer(volume)"},{"line_number":351,"context_line":"        except Exception:"},{"line_number":352,"context_line":"            LOG.exception(_LE(\u0027Could not do delete of volume %s on filer, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_d355a3fa","line":349,"in_reply_to":"ba15a1d1_b50d77ea","updated":"2015-09-19 13:12:26.000000000","message":"Done","commit_id":"f02636774cb179cce2bf1040e3eb8098501c380c"},{"author":{"_account_id":17151,"name":"chenying","email":"chenyingko@gmail.com","username":"chenying"},"change_message_id":"282126b0e6c8a692514ea8d46160f870e581bc27","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    def _delete_backing_file_for_snapshot(self, snapshot):"},{"line_number":377,"context_line":"        \"\"\"Deletes file on nfs share that backs a cinder volume.\"\"\""},{"line_number":378,"context_line":"        try:"},{"line_number":379,"context_line":"            LOG.debug(\u0027Deleting backing file for snapshot %s\u0027, snapshot[\u0027id\u0027])"},{"line_number":380,"context_line":"            self._delete_snapshot_on_filer(snapshot)"},{"line_number":381,"context_line":"        except Exception:"},{"line_number":382,"context_line":"            LOG.exception(_LE(\u0027Could not do delete of snapshot %s on filer, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_75f83fc5","line":379,"updated":"2015-09-19 06:48:35.000000000","message":"Add a \u0027.\u0027 to the EOL.","commit_id":"f02636774cb179cce2bf1040e3eb8098501c380c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d1c87182a8b8634c3a9d6468184b1ae90d117e7e","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    def _delete_backing_file_for_snapshot(self, snapshot):"},{"line_number":377,"context_line":"        \"\"\"Deletes file on nfs share that backs a cinder volume.\"\"\""},{"line_number":378,"context_line":"        try:"},{"line_number":379,"context_line":"            LOG.debug(\u0027Deleting backing file for snapshot %s\u0027, snapshot[\u0027id\u0027])"},{"line_number":380,"context_line":"            self._delete_snapshot_on_filer(snapshot)"},{"line_number":381,"context_line":"        except Exception:"},{"line_number":382,"context_line":"            LOG.exception(_LE(\u0027Could not do delete of snapshot %s on filer, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_33517f0f","line":379,"in_reply_to":"ba15a1d1_75f83fc5","updated":"2015-09-19 13:12:26.000000000","message":"Done","commit_id":"f02636774cb179cce2bf1040e3eb8098501c380c"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4b34a02329583eaa403de96f45bfd97de49f81d7","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        (_vserver, flexvol) \u003d self._get_export_ip_path("},{"line_number":394,"context_line":"            volume_id\u003dsnapshot[\u0027volume_id\u0027])"},{"line_number":395,"context_line":"        path_on_filer \u003d \u0027/vol\u0027 + flexvol + \u0027/\u0027 + snapshot[\u0027name\u0027]"},{"line_number":396,"context_line":"        LOG.debug(\u0027Attempting to delete backing file %s for snapshot %s \u0027"},{"line_number":397,"context_line":"                  \u0027on filer.\u0027, path_on_filer, snapshot[\u0027id\u0027])"},{"line_number":398,"context_line":"        self.zapi_client.delete_file(path_on_filer)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_ca5148da","line":396,"updated":"2015-09-21 14:42:36.000000000","message":"If you do another update, since there are multiple formatting variables it would be good to name them. -- %(path)s %(id)s","commit_id":"4163fb29add1f3c80cb902c8735be3dde24930d3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6becd1c9b009902e3eaf0511d8a0bd3aaedf0a72","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        (_vserver, flexvol) \u003d self._get_export_ip_path("},{"line_number":394,"context_line":"            volume_id\u003dsnapshot[\u0027volume_id\u0027])"},{"line_number":395,"context_line":"        path_on_filer \u003d \u0027/vol\u0027 + flexvol + \u0027/\u0027 + snapshot[\u0027name\u0027]"},{"line_number":396,"context_line":"        LOG.debug(\u0027Attempting to delete backing file %s for snapshot %s \u0027"},{"line_number":397,"context_line":"                  \u0027on filer.\u0027, path_on_filer, snapshot[\u0027id\u0027])"},{"line_number":398,"context_line":"        self.zapi_client.delete_file(path_on_filer)"},{"line_number":399,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_853021a0","line":396,"in_reply_to":"ba15a1d1_ca5148da","updated":"2015-09-21 16:26:05.000000000","message":"If I do another patch, I will.  Thought the rule was that this isn\u0027t required for debug logs though.","commit_id":"4163fb29add1f3c80cb902c8735be3dde24930d3"}]}