)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ab96ccfe3942fa7a450d45874c8ea6e1b8393067","unresolved":false,"context_lines":[{"line_number":15,"context_line":"There is also one change to the name of an opt in cinder/volume/api.py."},{"line_number":16,"context_line":"Instances such as this one will be caught by the in-progress hacking"},{"line_number":17,"context_line":"check patch: https://review.openstack.org/#/c/223375/"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I8d333d7529d40f3a3b3651ca3a52c0048d96b99a"},{"line_number":20,"context_line":"Closes-Bug: #1498122"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_2369d5be","line":18,"updated":"2015-09-22 15:10:00.000000000","message":"-1: Please mention also added `backend`","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3ff5f9dacfd311bdc42f220ec896c26f5c20f1c7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kendall Nelson \u003ckjnelson@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-23 09:53:59 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP:(until Mitaka opens) Missing configuration opts from cinder.sample.conf"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The logic for writing opts registered with register_opt() to the"},{"line_number":10,"context_line":"auto-generated opts.py file was flawed in that the directories where"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_56d8a51d","line":7,"updated":"2015-09-24 16:42:03.000000000","message":"-1: No longer WIP","commit_id":"de6f834e1a824e8c04f169a7151bd7797c4207fc"}],"cinder/config/generate_cinder_opts.py":[{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"f6474b89721f7b0f1f1341177237329deec9c3d6","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            opt_file.write(\"            \" + opts.strip(\"\\n\") + \",\\n\")"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _retrieve_name(aline):"},{"line_number":98,"context_line":"        if aline.find(\"CONF.register_opt(\") !\u003d -1:"},{"line_number":99,"context_line":"            name \u003d aline.replace(\"CONF.register_opt(\", \"\")"},{"line_number":100,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7c0d5836","line":97,"updated":"2015-09-21 18:54:58.000000000","message":"Could minimize duplicated code by just having if check for what string to do the replace on, and then outside if statement do:\n    return aline.replace(search_string, \"\")","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2175b3d962bfb0c97fc17428b3a27393eb3e76fb","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            opt_file.write(\"            \" + opts.strip(\"\\n\") + \",\\n\")"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _retrieve_name(aline):"},{"line_number":98,"context_line":"        if aline.find(\"CONF.register_opt(\") !\u003d -1:"},{"line_number":99,"context_line":"            name \u003d aline.replace(\"CONF.register_opt(\", \"\")"},{"line_number":100,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e6776b00","line":97,"in_reply_to":"ba15a1d1_7c0d5836","updated":"2015-09-22 16:06:06.000000000","message":"Done","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ce7e8f560904f3969a26a9b9e3cabd9bbbe46270","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        else:"},{"line_number":95,"context_line":"            opt_file.write(\"            \" + opts.strip(\"\\n\") + \",\\n\")"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _retrieve_name(aline):"},{"line_number":98,"context_line":"        if aline.find(\"CONF.register_opt(\") !\u003d -1:"},{"line_number":99,"context_line":"            name \u003d aline.replace(\"CONF.register_opt(\", \"\")"},{"line_number":100,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_7289b525","line":97,"in_reply_to":"ba15a1d1_e6776b00","updated":"2015-09-23 09:24:40.000000000","message":"nit: You say done, but it\u0027s not done in the latest patch.","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"f6474b89721f7b0f1f1341177237329deec9c3d6","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            opt_file.write(\"            \" + opts.strip(\"\\n\") + \",\\n\")"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _retrieve_name(aline):"},{"line_number":98,"context_line":"        if aline.find(\"CONF.register_opt(\") !\u003d -1:"},{"line_number":99,"context_line":"            name \u003d aline.replace(\"CONF.register_opt(\", \"\")"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            name \u003d aline.replace(\"CONF.register_opts(\", \"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_1c13fc5d","line":98,"updated":"2015-09-21 18:54:58.000000000","message":"Might be worth having a constant for \"CONF.register_opt\" and \"CONF.register_opts\" since they seem to be used a lot throughout","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ab96ccfe3942fa7a450d45874c8ea6e1b8393067","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            opt_file.write(\"            \" + opts.strip(\"\\n\") + \",\\n\")"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _retrieve_name(aline):"},{"line_number":98,"context_line":"        if aline.find(\"CONF.register_opt(\") !\u003d -1:"},{"line_number":99,"context_line":"            name \u003d aline.replace(\"CONF.register_opt(\", \"\")"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            name \u003d aline.replace(\"CONF.register_opts(\", \"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_d19542e4","line":98,"in_reply_to":"ba15a1d1_1c13fc5d","updated":"2015-09-22 15:10:00.000000000","message":"nit: Since you don\u0027t care about the position please use in:\n\n if \u0027CONF.register_opt(\u0027 in aline:","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2175b3d962bfb0c97fc17428b3a27393eb3e76fb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            opt_file.write(\"            \" + opts.strip(\"\\n\") + \",\\n\")"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def _retrieve_name(aline):"},{"line_number":98,"context_line":"        if aline.find(\"CONF.register_opt(\") !\u003d -1:"},{"line_number":99,"context_line":"            name \u003d aline.replace(\"CONF.register_opt(\", \"\")"},{"line_number":100,"context_line":"        else:"},{"line_number":101,"context_line":"            name \u003d aline.replace(\"CONF.register_opts(\", \"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e620cbf9","line":98,"in_reply_to":"ba15a1d1_d19542e4","updated":"2015-09-22 16:06:06.000000000","message":"Done","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"16f81b4cc42eba4a2491b9c66c9b689d9ba7dfa1","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                    default_list \u003d _retrieve_name(aline)"},{"line_number":162,"context_line":"                    default_list \u003d default_list.replace(\u0027)\u0027, \u0027\u0027).strip()"},{"line_number":163,"context_line":"                    line \u003d key + \".\" + default_list"},{"line_number":164,"context_line":"                    registered_opts_dict[\u0027DEFAULT\u0027].append(line)"},{"line_number":165,"context_line":"        opt_dict[key] \u003d registered_opts_dict"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    list_str \u003d (\"def list_opts():\\n\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_21cedb83","line":164,"updated":"2015-09-21 18:45:21.000000000","message":"I think something to look at in the near future, for M, is to refactor some of this code.  there is a lot of repeatable code for the most part that can be condensed and more readable.","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ab96ccfe3942fa7a450d45874c8ea6e1b8393067","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                    default_list \u003d _retrieve_name(aline)"},{"line_number":162,"context_line":"                    default_list \u003d default_list.replace(\u0027)\u0027, \u0027\u0027).strip()"},{"line_number":163,"context_line":"                    line \u003d key + \".\" + default_list"},{"line_number":164,"context_line":"                    registered_opts_dict[\u0027DEFAULT\u0027].append(line)"},{"line_number":165,"context_line":"        opt_dict[key] \u003d registered_opts_dict"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    list_str \u003d (\"def list_opts():\\n\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_a39ba5c8","line":164,"in_reply_to":"ba15a1d1_21cedb83","updated":"2015-09-22 15:10:00.000000000","message":"+1","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2175b3d962bfb0c97fc17428b3a27393eb3e76fb","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                    default_list \u003d _retrieve_name(aline)"},{"line_number":162,"context_line":"                    default_list \u003d default_list.replace(\u0027)\u0027, \u0027\u0027).strip()"},{"line_number":163,"context_line":"                    line \u003d key + \".\" + default_list"},{"line_number":164,"context_line":"                    registered_opts_dict[\u0027DEFAULT\u0027].append(line)"},{"line_number":165,"context_line":"        opt_dict[key] \u003d registered_opts_dict"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    list_str \u003d (\"def list_opts():\\n\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_80155ee6","line":164,"in_reply_to":"ba15a1d1_21cedb83","updated":"2015-09-22 16:06:06.000000000","message":"Yeah I agree totally. I have a few thoughts for how to do it too; I was just saving it for another patch, probably for the beginning of Mitaka like you said.","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"}],"cinder/volume/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ab96ccfe3942fa7a450d45874c8ea6e1b8393067","unresolved":false,"context_lines":[{"line_number":52,"context_line":"from cinder.volume import volume_types"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"allow_force_opt \u003d cfg.BoolOpt(\u0027enable_force_upload\u0027,"},{"line_number":56,"context_line":"                              default\u003dFalse,"},{"line_number":57,"context_line":"                              help\u003d\u0027Enables the Force option on \u0027"},{"line_number":58,"context_line":"                                   \u0027upload_to_image. This enables \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_6b1c8913","line":55,"updated":"2015-09-22 15:10:00.000000000","message":"nit: Shouldn\u0027t this be allow_force_upload_opt?","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"2175b3d962bfb0c97fc17428b3a27393eb3e76fb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"from cinder.volume import volume_types"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"allow_force_opt \u003d cfg.BoolOpt(\u0027enable_force_upload\u0027,"},{"line_number":56,"context_line":"                              default\u003dFalse,"},{"line_number":57,"context_line":"                              help\u003d\u0027Enables the Force option on \u0027"},{"line_number":58,"context_line":"                                   \u0027upload_to_image. This enables \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba15a1d1_e6e52ba8","line":55,"in_reply_to":"ba15a1d1_6b1c8913","updated":"2015-09-22 16:06:06.000000000","message":"Done","commit_id":"b2e501a79015116d0ef019711ba5ebccd0a34699"}]}