)]}'
{"cinder/cmd/volume.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a10a263f404ef227d6d807e684cc43da8a14c765","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                launcher.launch_service(server)"},{"line_number":87,"context_line":"                service_started \u003d True"},{"line_number":88,"context_line":"            finally:"},{"line_number":89,"context_line":"                session.dispose_engine()"},{"line_number":90,"context_line":"    else:"},{"line_number":91,"context_line":"        server \u003d service.Service.create(binary\u003d\u0027cinder-volume\u0027)"},{"line_number":92,"context_line":"        launcher.launch_service(server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_03e93b1a","line":89,"updated":"2015-09-22 12:22:16.000000000","message":"-1: You are disposing the session engine twice now.  I believe the finally clause is not needed.","commit_id":"5e8b631150f9ac55fa6f8a4d1e87c78a9360807b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8b9f4ccf4be0e0f2617f15d2f43613eb6388ba2e","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                launcher.launch_service(server)"},{"line_number":87,"context_line":"                service_started \u003d True"},{"line_number":88,"context_line":"            finally:"},{"line_number":89,"context_line":"                session.dispose_engine()"},{"line_number":90,"context_line":"    else:"},{"line_number":91,"context_line":"        server \u003d service.Service.create(binary\u003d\u0027cinder-volume\u0027)"},{"line_number":92,"context_line":"        launcher.launch_service(server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_8638ef3e","line":89,"in_reply_to":"ba15a1d1_03e93b1a","updated":"2015-09-22 15:34:03.000000000","message":"Agreed, this is mostly for the except: case, I\u0027ll move it there so we cleanup upon failure, and cleanup before launching the service (as before).","commit_id":"5e8b631150f9ac55fa6f8a4d1e87c78a9360807b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a576093a303c9375163a4f87c52de3470fbfa848","unresolved":false,"context_lines":[{"line_number":86,"context_line":"                launcher.launch_service(server)"},{"line_number":87,"context_line":"                service_started \u003d True"},{"line_number":88,"context_line":"            finally:"},{"line_number":89,"context_line":"                session.dispose_engine()"},{"line_number":90,"context_line":"    else:"},{"line_number":91,"context_line":"        server \u003d service.Service.create(binary\u003d\u0027cinder-volume\u0027)"},{"line_number":92,"context_line":"        launcher.launch_service(server)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_d9f1e8ce","line":89,"in_reply_to":"ba15a1d1_8638ef3e","updated":"2015-09-22 15:50:14.000000000","message":"On second thought, I think I\u0027ll just leave this closer to how it was before my changes, which seemed to be ok.","commit_id":"5e8b631150f9ac55fa6f8a4d1e87c78a9360807b"}]}