)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6960ff1515cd994ce480ebd2ff33916da5a853d3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Wilson Liu \u003cliuxinguo@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-22 20:59:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix capability report error in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the capability report is incorrect due"},{"line_number":10,"context_line":"to the wrong calculate way, this patch will fix it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_62910e52","line":7,"updated":"2015-09-22 13:33:12.000000000","message":"This patch fixes Huawei *capacity* reporting, not Huawei *capability* reporting.","commit_id":"4f2c77d7ab5eaaef7cee6bee7e620e2fb5ea792d"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"4d29fb6d0ed591aa1329f61f93f0a4dd70cb1dba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Wilson Liu \u003cliuxinguo@huawei.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-22 20:59:01 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix capability report error in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the capability report is incorrect due"},{"line_number":10,"context_line":"to the wrong calculate way, this patch will fix it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba15a1d1_96b020df","line":7,"in_reply_to":"ba15a1d1_62910e52","updated":"2015-09-22 14:46:41.000000000","message":"Done","commit_id":"4f2c77d7ab5eaaef7cee6bee7e620e2fb5ea792d"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"198d2c69fab0afb55ad6b88d6b8975a891899a07","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix capacity report error in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the capacity report is incorrect due"},{"line_number":10,"context_line":"to the wrong calculate way, this patch will fix it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1498452"},{"line_number":13,"context_line":"Change-Id: I4dc20ef8805d7c414fedb1dc441deb3f9fcd75b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_312b5e96","line":10,"updated":"2015-09-22 15:08:06.000000000","message":"Suggestion: Change \"incorrect due to the wrong calculate way, this...\" to \" incorrect due to the way the capacity report is currently being calculated. This ...\".\n\nIt also might be helpful to say how you fixed this issue.","commit_id":"9c9630a33ccfd44a6770798d1fdc623fd1dcb797"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3a7e9f4aa5bad84cb2f2514b4d15cbbcecb7075a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix capacity report error in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the capacity report is incorrect due"},{"line_number":10,"context_line":"to the wrong calculate way, this patch will fix it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1498452"},{"line_number":13,"context_line":"Change-Id: I4dc20ef8805d7c414fedb1dc441deb3f9fcd75b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_23fa35be","line":10,"in_reply_to":"ba15a1d1_312b5e96","updated":"2015-09-22 15:13:50.000000000","message":"Agree.","commit_id":"9c9630a33ccfd44a6770798d1fdc623fd1dcb797"},{"author":{"_account_id":8202,"name":"chenzongliang","email":"chenzongliang@huawei.com","username":"zongliang"},"change_message_id":"c884ba60f9fc13a160d46f4e43d7bfc60250342a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix capacity report error in Huawei driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the capacity report is incorrect due"},{"line_number":10,"context_line":"to the wrong calculate way, this patch will fix it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: #1498452"},{"line_number":13,"context_line":"Change-Id: I4dc20ef8805d7c414fedb1dc441deb3f9fcd75b5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"ba15a1d1_cb149945","line":10,"in_reply_to":"ba15a1d1_312b5e96","updated":"2015-09-23 00:56:06.000000000","message":"agree jacob","commit_id":"9c9630a33ccfd44a6770798d1fdc623fd1dcb797"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"9f3c12a1523dfdea1d83710509565963e145cb42","unresolved":false,"context_lines":[{"line_number":15,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / constants.CAPACITY_UNIT"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The right calculate method should be:"},{"line_number":18,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / 1024.0 / 1024.0 / 2"},{"line_number":19,"context_line":"If CAPACITY_UNIT \u003d 1024.0 / 1024.0 / 2, finally the result is:"},{"line_number":20,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / (1024.0 / 1024.0 / 2)"},{"line_number":21,"context_line":"This is incorrect."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a1a9d01_de1e285e","line":18,"updated":"2015-09-30 23:43:02.000000000","message":"I think you want to say the right calculation method should be:\n\n\tfree \u003d float(pool_info[\u0027CAPACITY\u0027]) / 1024.0 * 1024.0 * 2\n\nbecause that is what your change does, right?","commit_id":"6ad840f9b11923b38936e63cfdde8b65683c3815"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cab15af962eccf1e8edbcf66c86b443567d3623e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / constants.CAPACITY_UNIT"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The right calculate method should be:"},{"line_number":18,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / 1024.0 / 1024.0 / 2"},{"line_number":19,"context_line":"If CAPACITY_UNIT \u003d 1024.0 / 1024.0 / 2, finally the result is:"},{"line_number":20,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / (1024.0 / 1024.0 / 2)"},{"line_number":21,"context_line":"This is incorrect."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a1a9d01_43754930","line":18,"in_reply_to":"9a1a9d01_a00d40ea","updated":"2015-10-02 00:08:57.000000000","message":"Well, associativity of floating point multiplication and division may not be obvious to some of us dummies, so - \n\nIt is confusing to have the CAPACITY_UNIT\nconstant redefined as a product but have the commit message\nexpressing \"the right calculate method\" entirely as divisions.\n\nI\u0027ll leave it at that.","commit_id":"6ad840f9b11923b38936e63cfdde8b65683c3815"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2b929a8a0329a0f93f21aa13fc8df2c8858523c0","unresolved":false,"context_lines":[{"line_number":15,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / constants.CAPACITY_UNIT"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"The right calculate method should be:"},{"line_number":18,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / 1024.0 / 1024.0 / 2"},{"line_number":19,"context_line":"If CAPACITY_UNIT \u003d 1024.0 / 1024.0 / 2, finally the result is:"},{"line_number":20,"context_line":"free \u003d float(pool_info[\u0027CAPACITY\u0027]) / (1024.0 / 1024.0 / 2)"},{"line_number":21,"context_line":"This is incorrect."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"9a1a9d01_a00d40ea","line":18,"in_reply_to":"9a1a9d01_de1e285e","updated":"2015-10-01 12:57:50.000000000","message":"Please notice the parenthesis, the right way is:\nfree \u003d float(pool_info[\u0027CAPACITY\u0027]) / (1024.0 * 1024.0 * 2)\nequal to:\nfree \u003d float(pool_info[\u0027CAPACITY\u0027]) / 1024.0 / 1024.0 / 2\n\nBut currently is:\nfree \u003d float(pool_info[\u0027CAPACITY\u0027]) / (1024.0 / 1024.0 / 2)\nequal to:\nfree \u003d float(pool_info[\u0027CAPACITY\u0027]) / 1024.0 * 1024.0 * 2\nAnd this is wrong.\nPlease notice the parenthesis.","commit_id":"6ad840f9b11923b38936e63cfdde8b65683c3815"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"e89f0a72fe4009cb5356ffb601fa72b13a2c2727","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We use a constant CAPACITY_UNIT to make the code cleaner"},{"line_number":16,"context_line":"like this:"},{"line_number":17,"context_line":"CAPACITY_UNIT \u003d 1024.0 / 1024.0 / 2"},{"line_number":18,"context_line":"result \u003d var / CAPACITY_UNIT"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"We want the CAPACITY_UNIT work like a *real* constant like C"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9a1a9d01_ba20b6b1","line":17,"updated":"2015-10-03 23:26:59.000000000","message":"This still is confusing as the change in the code isn\u0027t division, but a product.","commit_id":"7c7d7f54e069e7776da163cb0c547f99ae1dc941"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"7a723b19a9e9192345ba1b06dd6d23bbadb96f0e","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"We use a constant CAPACITY_UNIT to make the code cleaner"},{"line_number":16,"context_line":"like this:"},{"line_number":17,"context_line":"CAPACITY_UNIT \u003d 1024.0 / 1024.0 / 2"},{"line_number":18,"context_line":"result \u003d var / CAPACITY_UNIT"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"We want the CAPACITY_UNIT work like a *real* constant like C"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9a1a9d01_e4dbe719","line":17,"in_reply_to":"9a1a9d01_ba20b6b1","updated":"2015-10-05 09:45:53.000000000","message":"What I describe here is the currently wrong code.","commit_id":"7c7d7f54e069e7776da163cb0c547f99ae1dc941"},{"author":{"_account_id":14908,"name":"Eduardo Felipe Zecca da Cruz","email":"duhzecca@gmail.com","username":"duhzecca"},"change_message_id":"8a155b835726fd3850f4e07efae7bab3ab4d054c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"But currently we use a constant CAPACITY_UNIT to make the code cleaner"},{"line_number":16,"context_line":"like this:"},{"line_number":17,"context_line":"CAPACITY_UNIT \u003d 1024.0 / 1024.0 / 2"},{"line_number":18,"context_line":"result \u003d var / CAPACITY_UNIT"},{"line_number":19,"context_line":"We want the CAPACITY_UNIT work like a *real* constant like C"},{"line_number":20,"context_line":"language, but in python, it is not a *real* constant, it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"9a1a9d01_aeff0600","line":17,"updated":"2015-10-05 12:17:24.000000000","message":"you could explain why you changed from division to product.","commit_id":"3a12a256a1d95a86939afb63d7fafa717becdb86"},{"author":{"_account_id":14908,"name":"Eduardo Felipe Zecca da Cruz","email":"duhzecca@gmail.com","username":"duhzecca"},"change_message_id":"f73e24adb568e876d558bb17331e55bb0d3bccf4","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"But currently we use a constant CAPACITY_UNIT to make the code cleaner"},{"line_number":16,"context_line":"like this:"},{"line_number":17,"context_line":"CAPACITY_UNIT \u003d 1024.0 / 1024.0 / 2"},{"line_number":18,"context_line":"result \u003d var / CAPACITY_UNIT"},{"line_number":19,"context_line":"We want the CAPACITY_UNIT work like a *real* constant like C"},{"line_number":20,"context_line":"language, but in python, it is not a *real* constant, it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a2fa921_5a318e0a","line":17,"in_reply_to":"7a2fa921_04e749e5","updated":"2015-10-06 11:45:35.000000000","message":"ok, got it.","commit_id":"3a12a256a1d95a86939afb63d7fafa717becdb86"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"5e87b0b89df7940cc2fdaaf654efce88dd96e31f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"But currently we use a constant CAPACITY_UNIT to make the code cleaner"},{"line_number":16,"context_line":"like this:"},{"line_number":17,"context_line":"CAPACITY_UNIT \u003d 1024.0 / 1024.0 / 2"},{"line_number":18,"context_line":"result \u003d var / CAPACITY_UNIT"},{"line_number":19,"context_line":"We want the CAPACITY_UNIT work like a *real* constant like C"},{"line_number":20,"context_line":"language, but in python, it is not a *real* constant, it\u0027s"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":16,"id":"7a2fa921_04e749e5","line":17,"in_reply_to":"9a1a9d01_aeff0600","updated":"2015-10-06 02:35:10.000000000","message":"The right way is divide the var by (1024*1024*2), you can take it as convert bit to MB. If it is divided by (1024/1024/2), means multiplied by 2, it will be too much bigger than the right value.","commit_id":"3a12a256a1d95a86939afb63d7fafa717becdb86"}],"cinder/volume/drivers/huawei/smartx.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"de0aae9f1579ec06b993ceb45b6d9ca02290af70","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            else:"},{"line_number":135,"context_line":"                opts[\u0027LUNType\u0027] \u003d 1"},{"line_number":136,"context_line":"        if opts[\u0027thick_provisioning_support\u0027] \u003d\u003d \u0027true\u0027:"},{"line_number":137,"context_line":"                opts[\u0027LUNType\u0027] \u003d 0"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return opts"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a1a9d01_b43da2c5","line":137,"updated":"2015-09-30 18:33:29.000000000","message":"The indentation was correct before. This is now over-indented.","commit_id":"6ad840f9b11923b38936e63cfdde8b65683c3815"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2b929a8a0329a0f93f21aa13fc8df2c8858523c0","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            else:"},{"line_number":135,"context_line":"                opts[\u0027LUNType\u0027] \u003d 1"},{"line_number":136,"context_line":"        if opts[\u0027thick_provisioning_support\u0027] \u003d\u003d \u0027true\u0027:"},{"line_number":137,"context_line":"                opts[\u0027LUNType\u0027] \u003d 0"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        return opts"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"9a1a9d01_20b8502a","line":137,"in_reply_to":"9a1a9d01_b43da2c5","updated":"2015-10-01 12:57:50.000000000","message":"Done","commit_id":"6ad840f9b11923b38936e63cfdde8b65683c3815"}]}