)]}'
{"cinder/testing/README.rst":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d54e71742edbdca3d1edf66e50b5834fed59bc4b","unresolved":false,"context_lines":[{"line_number":22,"context_line":"From the root of the cinder source code run tox. This will run several"},{"line_number":23,"context_line":"operations. View the tox.ini file in the root directory for the list of"},{"line_number":24,"context_line":"default tests to run. You can choose a specific test, e.g. \"py27\", by"},{"line_number":25,"context_line":"using the command \"tox -e py27\"."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Writing Unit Tests"},{"line_number":28,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_e97e6a69","line":25,"updated":"2015-10-04 14:47:29.000000000","message":"Might be worth adding some info on how things like how to run a single test, how to debug etc.\n\ntox -epy27 -- -n cinder.tests.test_volumes\n\nAlso maybe a link to the ostestr pages?\nhttp://docs.openstack.org/developer/os-testr/readme.html\n\n\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\u003e\nScratch all that, you added it to devref which is actually referenced above.  Might want to add one more reference to it here, because I\u0027m not sure how many people actually make it past README :)","commit_id":"76af62d620717b8608fa6df15e89d208a63dd903"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cc5c89fb2aa39ae1fcfa99d1d49c087a8a51a149","unresolved":false,"context_lines":[{"line_number":22,"context_line":"From the root of the cinder source code run tox. This will run several"},{"line_number":23,"context_line":"operations. View the tox.ini file in the root directory for the list of"},{"line_number":24,"context_line":"default tests to run. You can choose a specific test, e.g. \"py27\", by"},{"line_number":25,"context_line":"using the command \"tox -e py27\"."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Writing Unit Tests"},{"line_number":28,"context_line":"------------------"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_092cfe48","line":25,"in_reply_to":"9a1a9d01_e97e6a69","updated":"2015-10-04 15:22:49.000000000","message":"Very good point. I don\u0027t want to duplicate much because inevitably one of the locations will get out of date, but giving a pointer to the devref doc would be very useful.","commit_id":"76af62d620717b8608fa6df15e89d208a63dd903"}],"doc/source/devref/development.environment.rst":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7bd4e7b6d82b70bb9230fd0c14af60b867520d12","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    tox"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"The first time you run them, tox will create the virtual environment and"},{"line_number":103,"context_line":"install any prerequisites defined in the ``requirements.txt`` and "},{"line_number":104,"context_line":"``test-requirements.txt`` files."},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"See :doc:`unit_tests` for more details."}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_48abb989","line":103,"updated":"2015-09-22 19:42:45.000000000","message":"Trailng space","commit_id":"2a79bc3591cf997cbe29b682660ed434037d9aaa"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7bd4e7b6d82b70bb9230fd0c14af60b867520d12","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. _virtualenv:"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Manually installing and using the virtualenv"},{"line_number":111,"context_line":"--------------------------------------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"You can also manually install the virtual environment::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"ba15a1d1_68e0fdfa","line":110,"updated":"2015-09-22 19:42:45.000000000","message":"It should be deleted with run_tests.sh too. We can use tox to create virtualenv and run commands inside","commit_id":"2a79bc3591cf997cbe29b682660ed434037d9aaa"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"c5ed229645a85151e04fc412318cb79183ccceb2","unresolved":false,"context_lines":[{"line_number":107,"context_line":""},{"line_number":108,"context_line":".. _virtualenv:"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"Manually installing and using the virtualenv"},{"line_number":111,"context_line":"--------------------------------------------"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"You can also manually install the virtual environment::"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9a1a9d01_f961aa12","line":110,"in_reply_to":"ba15a1d1_68e0fdfa","updated":"2015-10-01 15:23:27.000000000","message":"I\u0027d actually like to keep this. It\u0027s not obvious to run tox to just create a venv, so this could be handy for someone that just wants a virtual environment set up to perform some test.","commit_id":"2a79bc3591cf997cbe29b682660ed434037d9aaa"}],"doc/source/devref/unit_tests.rst":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d54e71742edbdca3d1edf66e50b5834fed59bc4b","unresolved":false,"context_lines":[{"line_number":32,"context_line":"--------------------"},{"line_number":33,"context_line":"Another common need is the ability to debug tests and set breakpoints. Testing can"},{"line_number":34,"context_line":"be performed by running::"},{"line_number":35,"context_line":"    tox -epy27 -- --pdb cinder.tests.unit.test_volume"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"For more information on these options and how to run tests, please see the ostestr"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9a1a9d01_8996ce92","line":35,"updated":"2015-10-04 14:47:29.000000000","message":"Ahh... you\u0027ve got it right here :)","commit_id":"76af62d620717b8608fa6df15e89d208a63dd903"}],"tools/enable-pre-commit-hook.sh":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6cab8da925f8866dac7ec7189a467273a5a2102c","unresolved":false,"context_lines":[{"line_number":17,"context_line":"PRE_COMMIT_SCRIPT\u003d.git/hooks/pre-commit"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"make_hook() {"},{"line_number":20,"context_line":"    echo \"exec tox -e pep8\" \u003e\u003e $PRE_COMMIT_SCRIPT"},{"line_number":21,"context_line":"    chmod +x $PRE_COMMIT_SCRIPT"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if [ -w $PRE_COMMIT_SCRIPT -a -x $PRE_COMMIT_SCRIPT ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba15a1d1_97a1f0ab","line":20,"updated":"2015-09-22 18:38:47.000000000","message":"I dunno about this, building tox can take a massive amount of time compared to run_tests.sh -N... I don\u0027t think people want that happening in the background as a commit hook.","commit_id":"9452f89d6bc595523f5b0ba67be5edf58e049aa0"},{"author":{"_account_id":5196,"name":"Matthew Treinish","email":"mtreinish@kortar.org","username":"treinish"},"change_message_id":"18aa1266dd75ec8c3d9a2daa0db0fa944db82779","unresolved":false,"context_lines":[{"line_number":17,"context_line":"PRE_COMMIT_SCRIPT\u003d.git/hooks/pre-commit"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"make_hook() {"},{"line_number":20,"context_line":"    echo \"exec tox -e pep8\" \u003e\u003e $PRE_COMMIT_SCRIPT"},{"line_number":21,"context_line":"    chmod +x $PRE_COMMIT_SCRIPT"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if [ -w $PRE_COMMIT_SCRIPT -a -x $PRE_COMMIT_SCRIPT ]; then"}],"source_content_type":"text/x-sh","patch_set":1,"id":"ba15a1d1_fdf84d7e","line":20,"in_reply_to":"ba15a1d1_97a1f0ab","updated":"2015-09-22 19:21:43.000000000","message":"Well that\u0027s the tradeoff. You can just call flake8 manually which is about the equiv of doing run_tests.sh -N -p. But both of those presume the requirements are already installed in the system site-packages (or the venv you\u0027re already running in) This will fail if all the requirements for running flake8 aren\u0027t installed. So if you don\u0027t have the requirements installed this will fail.\n\nUsing tox solves that aspect of it (well except it presumes tox is installed and in your shells PATH when you run git) which I think is better behavior because it doesn\u0027t depend as much on your local environment and also it isolates this from everything on your system.\n\nThat being said I don\u0027t think a git hook for this is a good thing because it\u0027s a mess no matter which way you look at either you make assumptions about the environment the commit is happening in. (I can safetly say this would not work as expected in my dev env.) or you have  to eat the overhead of creating a new venv to properly isolate this from the rest of the system. How hard is it to just tell people to run \u0027tox\u0027 manually before pushing changes...","commit_id":"9452f89d6bc595523f5b0ba67be5edf58e049aa0"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b2735da84d916a6d9f8bf7fed29dc4625f3e6160","unresolved":false,"context_lines":[{"line_number":17,"context_line":"PRE_COMMIT_SCRIPT\u003d.git/hooks/pre-commit"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"make_hook() {"},{"line_number":20,"context_line":"    echo \"exec tox -e pep8\" \u003e\u003e $PRE_COMMIT_SCRIPT"},{"line_number":21,"context_line":"    chmod +x $PRE_COMMIT_SCRIPT"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if [ -w $PRE_COMMIT_SCRIPT -a -x $PRE_COMMIT_SCRIPT ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a1a9d01_362e51a6","line":20,"updated":"2015-10-01 15:06:56.000000000","message":"This should call tox -e fast8 now.\n\n(I might actually start using this, seems handy...)","commit_id":"2a79bc3591cf997cbe29b682660ed434037d9aaa"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"0db288637ed0589a74ec66e2a4a1242b65f46be6","unresolved":false,"context_lines":[{"line_number":17,"context_line":"PRE_COMMIT_SCRIPT\u003d.git/hooks/pre-commit"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"make_hook() {"},{"line_number":20,"context_line":"    echo \"exec tox -e pep8\" \u003e\u003e $PRE_COMMIT_SCRIPT"},{"line_number":21,"context_line":"    chmod +x $PRE_COMMIT_SCRIPT"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if [ -w $PRE_COMMIT_SCRIPT -a -x $PRE_COMMIT_SCRIPT ]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"9a1a9d01_f95e8a78","line":20,"in_reply_to":"9a1a9d01_362e51a6","updated":"2015-10-01 15:19:26.000000000","message":"Definitely, thanks for the reminder. And for adding fast8. That will be good to have here.","commit_id":"2a79bc3591cf997cbe29b682660ed434037d9aaa"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0e667f84913ca08f5cc224b7aad8c912525bd874","unresolved":false,"context_lines":[{"line_number":17,"context_line":"PRE_COMMIT_SCRIPT\u003d.git/hooks/pre-commit"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"make_hook() {"},{"line_number":20,"context_line":"    echo \"exec tox -e fast8\" \u003e\u003e $PRE_COMMIT_SCRIPT"},{"line_number":21,"context_line":"    chmod +x $PRE_COMMIT_SCRIPT"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    if [ -w $PRE_COMMIT_SCRIPT -a -x $PRE_COMMIT_SCRIPT ]; then"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7a2fa921_2d406806","line":20,"updated":"2015-10-09 15:30:37.000000000","message":"This breaks things if you use a flow like:\n\n 1. Start on master\n 2. git checkout stable/kilo\n 3. git cherry-pick -x \u003cabcd\u003e\n\nIt fails because this tox env doesn\u0027t exist on the old branch.","commit_id":"f3b8fcb035a5e0927fe3e54b2692ba50e7b05d20"}]}