)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"02850e081eeefdf3b66ad80b7416dc607336568f","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if lvm_conf and os.path.isfile(lvm_conf):"},{"line_number":77,"context_line":"            LVM.LVM_CMD_PREFIX \u003d [\u0027env\u0027,"},{"line_number":78,"context_line":"                                  \u0027LC_ALL\u003dC\u0027,"},{"line_number":79,"context_line":"                                  \u0027LVM_SYSTEM_DIR\u003d/etc/cinder\u0027]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if create_vg and physical_volumes is not None:"},{"line_number":82,"context_line":"            self.pv_list \u003d physical_volumes"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_0b5a9850","line":79,"updated":"2015-09-22 21:19:22.000000000","message":"Probably makes sense to move this earlier like this, but it occurs to me that I think I messed this up anyway. \n\nThe config setting in the LVM driver: https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/lvm.py#L57\n\nTakes a path for a cinder-lvm conf file, however here we just say if it exists, use /etc/cinder; I think this should be done differently. The config option should be something like \"user_cinder_lvm_conf\" True/False (default False), and then stick with using /etc/cinder like we\u0027re doing here but don\u0027t lie and say we\u0027re letting you specify the conf when you\u0027re not.\n\nThat introduces a compatibility problem obviously, so the other option is fix this setting here to do what it\u0027s actually supposed to.","commit_id":"adf2d4306a6886268ffb1a6e4c8fe7ef2fe683e3"},{"author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"change_message_id":"c4b16f38353763fb60519eab6e1a59cfd28309ce","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if lvm_conf and os.path.isfile(lvm_conf):"},{"line_number":77,"context_line":"            LVM.LVM_CMD_PREFIX \u003d [\u0027env\u0027,"},{"line_number":78,"context_line":"                                  \u0027LC_ALL\u003dC\u0027,"},{"line_number":79,"context_line":"                                  \u0027LVM_SYSTEM_DIR\u003d/etc/cinder\u0027]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if create_vg and physical_volumes is not None:"},{"line_number":82,"context_line":"            self.pv_list \u003d physical_volumes"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_0ecaa66e","line":79,"in_reply_to":"ba15a1d1_0b5a9850","updated":"2015-09-22 21:35:15.000000000","message":"John, see my follow on bug \u0026 proposed fix that uses the directory containing lvm_conf as the value for LVM_SYSTEM_DIR:  https://bugs.launchpad.net/cinder/+bug/1498651","commit_id":"adf2d4306a6886268ffb1a6e4c8fe7ef2fe683e3"}]}