)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9031483ae4ee8ade6fe70a3a79869b832f448605","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # before the first LVM command is executed, and use the directory"},{"line_number":76,"context_line":"        # where specified lvm_conf file is located as value."},{"line_number":77,"context_line":"        if lvm_conf and os.path.isfile(lvm_conf):"},{"line_number":78,"context_line":"            lvm_sys_dir \u003d os.path.dirname(os.path.realpath(lvm_conf))"},{"line_number":79,"context_line":"            LVM.LVM_CMD_PREFIX \u003d [\u0027env\u0027,"},{"line_number":80,"context_line":"                                  \u0027LC_ALL\u003dC\u0027,"},{"line_number":81,"context_line":"                                  \u0027LVM_SYSTEM_DIR\u003d\u0027 + lvm_sys_dir]"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_0b711444","line":78,"updated":"2015-09-23 15:23:09.000000000","message":"I suspect we don\u0027t really want realpath() here.  If someone is using a symlinked dir it would be less confusing to just keep it.","commit_id":"31bc27471480ef2a15f0cb3a2a88e3e18f0886b5"},{"author":{"_account_id":842,"name":"Fergal Mc Carthy","email":"fergal.mc.carthy@suse.com","username":"fergal-mccarthy"},"change_message_id":"8446146411bfcdf5c33ba69418c4a44ad53408c1","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        # before the first LVM command is executed, and use the directory"},{"line_number":76,"context_line":"        # where specified lvm_conf file is located as value."},{"line_number":77,"context_line":"        if lvm_conf and os.path.isfile(lvm_conf):"},{"line_number":78,"context_line":"            lvm_sys_dir \u003d os.path.dirname(os.path.realpath(lvm_conf))"},{"line_number":79,"context_line":"            LVM.LVM_CMD_PREFIX \u003d [\u0027env\u0027,"},{"line_number":80,"context_line":"                                  \u0027LC_ALL\u003dC\u0027,"},{"line_number":81,"context_line":"                                  \u0027LVM_SYSTEM_DIR\u003d\u0027 + lvm_sys_dir]"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_22bb5974","line":78,"in_reply_to":"ba15a1d1_0b711444","updated":"2015-10-13 17:21:35.000000000","message":"Good spot Eric.\n\nI was using realpath here just from force of habit after years of having to ensure I was working with canonical paths.\n\nHowever in this case we don\u0027t necessary care that the path is canonical, so I\u0027ll remove it.","commit_id":"31bc27471480ef2a15f0cb3a2a88e3e18f0886b5"}]}