)]}'
{"cinder/volume/drivers/solidfire.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"264e35dea675eabc06fec3c3168b747a3a8afffa","unresolved":false,"context_lines":[{"line_number":548,"context_line":""},{"line_number":549,"context_line":"        data[\u0027total_capacity_gb\u0027] \u003d results[\u0027maxProvisionedSpace\u0027]"},{"line_number":550,"context_line":"        data[\u0027free_capacity_gb\u0027] \u003d free_capacity"},{"line_number":551,"context_line":"        #BOOKMARK-jdg"},{"line_number":552,"context_line":"        #data[\u0027reserved_percentage\u0027] \u003d self.configuration.reserved_percentage"},{"line_number":553,"context_line":"        data[\u0027QoS_support\u0027] \u003d True"},{"line_number":554,"context_line":"        data[\u0027compression_percent\u0027] \u003d\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bqrs%3D","line":551,"updated":"2013-02-22 06:06:54.000000000","message":"Ooops, need to put this back","commit_id":"84a98d6071bad3541bd72ea25c75b928e57ba442"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"c5d3543f010e2e4ccf52e89ae20da92a010cd03a","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        sfaccount \u003d self._get_sfaccount(volume[\u0027project_id\u0027])"},{"line_number":459,"context_line":"        if sfaccount is None:"},{"line_number":460,"context_line":"            LOG.error(_(\"Account for Volume ID %s was not found on \""},{"line_number":461,"context_line":"                        \"the SolidFire Cluster!\"), volume[\u0027id\u0027])"},{"line_number":462,"context_line":"            LOG.error(_(\"This usually means the volume was never \""},{"line_number":463,"context_line":"                        \"succesfully created.\"))"},{"line_number":464,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BoGc%3D","line":461,"updated":"2013-02-25 11:21:14.000000000","message":"wanted the % operator?","commit_id":"98ff7f65ea0a18aba135005f33251cf66f32e794"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"8077c029abd2877cfd21fe8930961632bd70485e","unresolved":false,"context_lines":[{"line_number":458,"context_line":"        sfaccount \u003d self._get_sfaccount(volume[\u0027project_id\u0027])"},{"line_number":459,"context_line":"        if sfaccount is None:"},{"line_number":460,"context_line":"            LOG.error(_(\"Account for Volume ID %s was not found on \""},{"line_number":461,"context_line":"                        \"the SolidFire Cluster!\"), volume[\u0027id\u0027])"},{"line_number":462,"context_line":"            LOG.error(_(\"This usually means the volume was never \""},{"line_number":463,"context_line":"                        \"succesfully created.\"))"},{"line_number":464,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAM3%2F%2BloE%3D","line":461,"in_reply_to":"AAAAM3%2F%2BoGc%3D","updated":"2013-02-26 17:15:49.000000000","message":"Done\n\nSo technically this is fine for a single argument but for consistency you\u0027re right it should be changed.","commit_id":"98ff7f65ea0a18aba135005f33251cf66f32e794"},{"author":{"_account_id":1773,"name":"oliver-leahy-l","email":"oliver.leahy@hpe.com","username":"oliver-leahy-l"},"change_message_id":"34cc3eccc97c4bc30eb76332eafaf399e052de4d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from oslo.config import cfg"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from cinder import context"},{"line_number":31,"context_line":"from cinder import exception"},{"line_number":32,"context_line":"from cinder import flags"},{"line_number":33,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":34,"context_line":"from cinder.volume.drivers.san.san import SanISCSIDriver"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2BjOE%3D","line":31,"updated":"2013-02-27 18:29:07.000000000","message":"If we don\u0027t need the code defining FLAGS, then probably don\u0027t need the import either.","commit_id":"f2badf127addb6d791a0c8178a27950e0dead51f"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"6a09466382899f16ac64021c23f9551eb59c53f5","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                default\u003dFalse,"},{"line_number":47,"context_line":"                help\u003d\u0027Allow tenants to specify QOS on create\u0027), ]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":50,"context_line":"FLAGS.register_opts(sf_opts)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2BkLM%3D","line":49,"updated":"2013-02-27 06:49:50.000000000","message":"Do we still need these two lines?","commit_id":"f2badf127addb6d791a0c8178a27950e0dead51f"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"31adde554e461dafe93419050b8fe6b034426028","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":50,"context_line":"FLAGS.register_opts(sf_opts)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"class SolidFire(SanISCSIDriver):"},{"line_number":54,"context_line":"    \"\"\"OpenStack driver to enable SolidFire cluster."}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAM3%2F%2Bjco%3D","line":51,"updated":"2013-02-27 16:29:38.000000000","message":"With avishay on this, do we still need these two lines referencing FLAGS?","commit_id":"f2badf127addb6d791a0c8178a27950e0dead51f"}]}