)]}'
{"cinder/tests/unit/test_huawei_drivers.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"bb88b223fab2b70784896e422e0f7f70471d6aa1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"             \u0027display_description\u0027: \u0027test volume\u0027,"},{"line_number":85,"context_line":"             \u0027volume_type_id\u0027: None,"},{"line_number":86,"context_line":"             \u0027provider_location\u0027: \u002711\u0027,"},{"line_number":87,"context_line":"             \u0027volume\u0027: {\"volume_id\": \u002721ec7341-9256-497b-97d9-ef48edcf0635\u0027},"},{"line_number":88,"context_line":"             \u0027volume\u0027: {\u0027provider_location\u0027: \u002712\u0027},"},{"line_number":89,"context_line":"             }"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_571346b8","side":"PARENT","line":87,"updated":"2015-09-23 06:41:24.000000000","message":"Why not use \"{\"volume_id\": \u002721ec7341-9256-497b-97d9-ef48edcf0635\u0027, \u0027provider_location\u0027: \u002712\u0027}\"?","commit_id":"fcb11882072c16b0fc4e8b2d21ac7c3db56ccd84"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"4f4195c2afd6c311a7e6ea2a72d8e9d0146474df","unresolved":false,"context_lines":[{"line_number":84,"context_line":"             \u0027display_description\u0027: \u0027test volume\u0027,"},{"line_number":85,"context_line":"             \u0027volume_type_id\u0027: None,"},{"line_number":86,"context_line":"             \u0027provider_location\u0027: \u002711\u0027,"},{"line_number":87,"context_line":"             \u0027volume\u0027: {\"volume_id\": \u002721ec7341-9256-497b-97d9-ef48edcf0635\u0027},"},{"line_number":88,"context_line":"             \u0027volume\u0027: {\u0027provider_location\u0027: \u002712\u0027},"},{"line_number":89,"context_line":"             }"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_a4005d67","side":"PARENT","line":87,"in_reply_to":"ba15a1d1_32a81d8c","updated":"2015-09-23 13:48:10.000000000","message":"It might be good to include volume_id for completeness, but if none of the tests are using that right now, that can be something that is added in the future if needed.","commit_id":"fcb11882072c16b0fc4e8b2d21ac7c3db56ccd84"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"590e1171ea5de9ff7ffd219da4b480cddece369c","unresolved":false,"context_lines":[{"line_number":84,"context_line":"             \u0027display_description\u0027: \u0027test volume\u0027,"},{"line_number":85,"context_line":"             \u0027volume_type_id\u0027: None,"},{"line_number":86,"context_line":"             \u0027provider_location\u0027: \u002711\u0027,"},{"line_number":87,"context_line":"             \u0027volume\u0027: {\"volume_id\": \u002721ec7341-9256-497b-97d9-ef48edcf0635\u0027},"},{"line_number":88,"context_line":"             \u0027volume\u0027: {\u0027provider_location\u0027: \u002712\u0027},"},{"line_number":89,"context_line":"             }"},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_32a81d8c","side":"PARENT","line":87,"in_reply_to":"ba15a1d1_571346b8","updated":"2015-09-23 09:13:49.000000000","message":"Vincent Hou,\n\nI have removed this entry because in case of duplicate key name all the duplicate key values will be overwriiten by the last one. Which means current code is using \u0027volume\u0027: {\u0027provider_location\u0027: \u002712\u0027} instead of \u0027volume\u0027: {\"volume_id\": \u002721ec7341-9256-497b-97d9-ef48edcf0635\u0027}. But \u0027volume\u0027: {\u0027provider_location\u0027: \u002712\u0027} does not override \u0027provider_location\u0027: \u002711\u0027.\n\nSo I have kept the current test case as it is just by removing the duplicate key entry.","commit_id":"fcb11882072c16b0fc4e8b2d21ac7c3db56ccd84"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_cmode.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"467e1bdcc7704ff1398147b6d0739d48f244859e","unresolved":false,"context_lines":[{"line_number":154,"context_line":"                     \u0027netapp_raid_type\u0027: \u0027raiddp\u0027,"},{"line_number":155,"context_line":"                     \u0027netapp_disk_type\u0027: \u0027SSD\u0027,"},{"line_number":156,"context_line":"                     \u0027netapp_nodedup\u0027: \u0027true\u0027,"},{"line_number":157,"context_line":"                     \u0027reserved_percentage\u0027: 7,"},{"line_number":158,"context_line":"                     \u0027max_over_subscription_ratio\u0027: 19.0,"},{"line_number":159,"context_line":"                     \u0027provisioned_capacity_gb\u0027: 4456.0}]"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_32ad7d84","side":"PARENT","line":157,"updated":"2015-09-23 09:11:05.000000000","message":"Thanks for catching this!","commit_id":"fcb11882072c16b0fc4e8b2d21ac7c3db56ccd84"}]}