)]}'
{"cinder/tests/unit/test_huawei_drivers.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"19dc56db020092b141d0f71a36bf55125084174e","unresolved":false,"context_lines":[{"line_number":1671,"context_line":"                \"60\", ,\"61\", \"62\", \"63\"]\u0027"},{"line_number":1672,"context_line":"            }]"},{"line_number":1673,"context_line":"        }"},{"line_number":1674,"context_line":"        # Number of LUNs in QoS is equal to 64"},{"line_number":1675,"context_line":"        with mock.patch.object(rest_client.RestClient, \u0027get_qos\u0027,"},{"line_number":1676,"context_line":"                               return_value\u003dfake_qos_info_response_equal):"},{"line_number":1677,"context_line":"            (qos_id, lun_list) \u003d self.driver.restclient.find_available_qos(qos)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_46bc656c","line":1674,"updated":"2015-09-25 02:22:57.000000000","message":"Is it cover the case with LUNs larger than 64?\n\nAnd size of \"LUNLIST\" with 1 to 63 is equal to 63, not 64. Am I right here? :-)","commit_id":"6cff99b702c2df3003a6b4779030c43382ed5116"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"eaefec21521b55dc910bf91101eba988308bc861","unresolved":false,"context_lines":[{"line_number":1671,"context_line":"                \"60\", ,\"61\", \"62\", \"63\"]\u0027"},{"line_number":1672,"context_line":"            }]"},{"line_number":1673,"context_line":"        }"},{"line_number":1674,"context_line":"        # Number of LUNs in QoS is equal to 64"},{"line_number":1675,"context_line":"        with mock.patch.object(rest_client.RestClient, \u0027get_qos\u0027,"},{"line_number":1676,"context_line":"                               return_value\u003dfake_qos_info_response_equal):"},{"line_number":1677,"context_line":"            (qos_id, lun_list) \u003d self.driver.restclient.find_available_qos(qos)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_0109772c","line":1674,"in_reply_to":"9a1a9d01_46bc656c","updated":"2015-09-25 02:38:11.000000000","message":"Yes, I got a mistake here, will fix it in next patch set, thanks! For the case that LUNs larger than 64, this is guaranteed by the storage array, so in fact there is no such case, thanks!","commit_id":"6cff99b702c2df3003a6b4779030c43382ed5116"}],"cinder/volume/drivers/huawei/rest_client.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"6188e06af85e2f63521a2ddf0bf75b1ca84d3086","unresolved":false,"context_lines":[{"line_number":1517,"context_line":"                    qos_flag \u003d qos_flag + 1"},{"line_number":1518,"context_line":"                lun_num \u003d len(item[\u0027LUNLIST\u0027].split(\",\"))"},{"line_number":1519,"context_line":"                if (qos_flag \u003d\u003d len(qos)"},{"line_number":1520,"context_line":"                        and lun_num \u003c constants.MAX_LUN_NUM_IN_QOS):"},{"line_number":1521,"context_line":"                    qos_id \u003d item[\u0027ID\u0027]"},{"line_number":1522,"context_line":"                    lun_list \u003d item[\u0027LUNLIST\u0027]"},{"line_number":1523,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_8dd9b5f5","line":1520,"updated":"2015-09-23 16:59:00.000000000","message":"I took a look in cinder/volume/drivers/huawei/constants.py and I do not see MAX_LUN_NUM_IN_QOS being defined and I do not see it in this patch. Is this in a different patch set or was this not defined?","commit_id":"24d295fe2fcef69fc768c941a359680c950b50d8"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2bd43c51d928f985447765c33ca1dc940ec167f3","unresolved":false,"context_lines":[{"line_number":1517,"context_line":"                    qos_flag \u003d qos_flag + 1"},{"line_number":1518,"context_line":"                lun_num \u003d len(item[\u0027LUNLIST\u0027].split(\",\"))"},{"line_number":1519,"context_line":"                if (qos_flag \u003d\u003d len(qos)"},{"line_number":1520,"context_line":"                        and lun_num \u003c constants.MAX_LUN_NUM_IN_QOS):"},{"line_number":1521,"context_line":"                    qos_id \u003d item[\u0027ID\u0027]"},{"line_number":1522,"context_line":"                    lun_list \u003d item[\u0027LUNLIST\u0027]"},{"line_number":1523,"context_line":"                    break"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba15a1d1_7fa71550","line":1520,"in_reply_to":"ba15a1d1_8dd9b5f5","updated":"2015-09-24 01:09:39.000000000","message":"Sorry for missing that, will add it in next patch set, thanks!","commit_id":"24d295fe2fcef69fc768c941a359680c950b50d8"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"19dc56db020092b141d0f71a36bf55125084174e","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"    def get_qos(self):"},{"line_number":1483,"context_line":"        url \u003d \"/ioclass\""},{"line_number":1484,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1485,"context_line":"        self._assert_rest_result(result, _(\u0027Get QoS information error.\u0027))"},{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"    def find_available_qos(self, qos):"},{"line_number":1488,"context_line":"        \"\"\"\"Find available QoS on the array.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_2649318c","line":1485,"updated":"2015-09-25 02:22:57.000000000","message":"I am doubting if this function is written in a correct way. :-(\nThis function has no return and _assert_rest_result has no return either.\n\nWhat can be the result, if we call result \u003d self.get_qos()??","commit_id":"6cff99b702c2df3003a6b4779030c43382ed5116"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"eaefec21521b55dc910bf91101eba988308bc861","unresolved":false,"context_lines":[{"line_number":1482,"context_line":"    def get_qos(self):"},{"line_number":1483,"context_line":"        url \u003d \"/ioclass\""},{"line_number":1484,"context_line":"        result \u003d self.call(url, None, \"GET\")"},{"line_number":1485,"context_line":"        self._assert_rest_result(result, _(\u0027Get QoS information error.\u0027))"},{"line_number":1486,"context_line":""},{"line_number":1487,"context_line":"    def find_available_qos(self, qos):"},{"line_number":1488,"context_line":"        \"\"\"\"Find available QoS on the array.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_215cbb24","line":1485,"in_reply_to":"9a1a9d01_2649318c","updated":"2015-09-25 02:38:11.000000000","message":"Thanks, will fix it in next patch set.","commit_id":"6cff99b702c2df3003a6b4779030c43382ed5116"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"19dc56db020092b141d0f71a36bf55125084174e","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"                        and lun_num \u003c constants.MAX_LUN_NUM_IN_QOS):"},{"line_number":1505,"context_line":"                    qos_id \u003d item[\u0027ID\u0027]"},{"line_number":1506,"context_line":"                    lun_list \u003d item[\u0027LUNLIST\u0027]"},{"line_number":1507,"context_line":"                    break"},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"        return (qos_id, lun_list)"},{"line_number":1510,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_a655411e","line":1507,"updated":"2015-09-25 02:22:57.000000000","message":"Can you add a comment here, explaining the case lun_num \u003e\u003d constants.MAX_LUN_NUM_IN_QOS?","commit_id":"6cff99b702c2df3003a6b4779030c43382ed5116"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"eaefec21521b55dc910bf91101eba988308bc861","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"                        and lun_num \u003c constants.MAX_LUN_NUM_IN_QOS):"},{"line_number":1505,"context_line":"                    qos_id \u003d item[\u0027ID\u0027]"},{"line_number":1506,"context_line":"                    lun_list \u003d item[\u0027LUNLIST\u0027]"},{"line_number":1507,"context_line":"                    break"},{"line_number":1508,"context_line":""},{"line_number":1509,"context_line":"        return (qos_id, lun_list)"},{"line_number":1510,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_016e57c9","line":1507,"in_reply_to":"9a1a9d01_a655411e","updated":"2015-09-25 02:38:11.000000000","message":"Sure, will add a comment here.","commit_id":"6cff99b702c2df3003a6b4779030c43382ed5116"}]}