)]}'
{"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"1687b60cc35fb0199012fe56ed3b7341c45767af","unresolved":false,"context_lines":[{"line_number":801,"context_line":"                if vlun[\u0027active\u0027]:"},{"line_number":802,"context_line":"                    active_volume_vluns.append(vlun)"},{"line_number":803,"context_line":"                else:"},{"line_number":804,"context_line":"                    inactive_volume_vluns.append(vlun)"},{"line_number":805,"context_line":"        if active_volume_vluns:"},{"line_number":806,"context_line":"            volume_vluns \u003d active_volume_vluns"},{"line_number":807,"context_line":"        elif inactive_volume_vluns:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_03bd28d7","line":804,"updated":"2015-10-01 03:54:20.000000000","message":"You really should consider a comprehension here, I think it\u0027s going to be quite a bit more efficient for you.  It also means you don\u0027t need the extra if/elif blocks below because if there\u0027s nothing there you\u0027ll just get an empty list so it \"just works\".","commit_id":"64998f1c8c12a2c8575b0b7027e010955c2203eb"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"1687b60cc35fb0199012fe56ed3b7341c45767af","unresolved":false,"context_lines":[{"line_number":814,"context_line":"            LOG.warning(msg)"},{"line_number":815,"context_line":"            return"},{"line_number":816,"context_line":""},{"line_number":817,"context_line":"        # VLUN Type of MATCHED_SET 4 requires the port to be provided"},{"line_number":818,"context_line":"        removed_luns \u003d []"},{"line_number":819,"context_line":"        for vlun in volume_vluns:"},{"line_number":820,"context_line":"            if self.VLUN_TYPE_MATCHED_SET \u003d\u003d vlun[\u0027type\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_63c2e454","line":817,"updated":"2015-10-01 03:54:20.000000000","message":"Seems like some of this could be consolidated with the loop you already have above no?","commit_id":"64998f1c8c12a2c8575b0b7027e010955c2203eb"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"1687b60cc35fb0199012fe56ed3b7341c45767af","unresolved":false,"context_lines":[{"line_number":834,"context_line":"        try:"},{"line_number":835,"context_line":"            vluns \u003d self.client.getHostVLUNs(hostname)"},{"line_number":836,"context_line":"        except hpexceptions.HTTPNotFound:"},{"line_number":837,"context_line":"            LOG.debug(\"All VLUNs removed from host %s\", hostname)"},{"line_number":838,"context_line":"            pass"},{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        for vlun in vluns:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_c3a97091","line":837,"updated":"2015-10-01 03:54:20.000000000","message":"isn\u0027t this kind of a misleading message?  Maybe something more like \"No vluns found on host: %s\" ?","commit_id":"64998f1c8c12a2c8575b0b7027e010955c2203eb"}]}