)]}'
{"cinder/tests/unit/test_huawei_drivers.py":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"73f06906f5c2502686456f1068f07bcef78a2ed5","unresolved":false,"context_lines":[{"line_number":1622,"context_line":"        pool_info \u003d self.driver.restclient.find_pool_info(pool_name, pools)"},{"line_number":1623,"context_line":"        self.assertEqual(test_info, pool_info)"},{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        pools \u003d {"},{"line_number":1626,"context_line":"            \"error\": {\"code\": 0},"},{"line_number":1627,"context_line":"            \"data\": [{"},{"line_number":1628,"context_line":"                \"NAME\": \"test003\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_83bb540e","line":1625,"updated":"2015-09-24 21:41:16.000000000","message":"You can update pools from line 1597  to have test003. That will reduce duplication of test002 in following example","commit_id":"daf846d1013cc0b2ba466b1e3e0197f77a60bf15"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"c2366947f8bc7af9bb2d3b6f25206c6ebd0f6d82","unresolved":false,"context_lines":[{"line_number":1622,"context_line":"        pool_info \u003d self.driver.restclient.find_pool_info(pool_name, pools)"},{"line_number":1623,"context_line":"        self.assertEqual(test_info, pool_info)"},{"line_number":1624,"context_line":""},{"line_number":1625,"context_line":"        pools \u003d {"},{"line_number":1626,"context_line":"            \"error\": {\"code\": 0},"},{"line_number":1627,"context_line":"            \"data\": [{"},{"line_number":1628,"context_line":"                \"NAME\": \"test003\","}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_260e1135","line":1625,"in_reply_to":"9a1a9d01_83bb540e","updated":"2015-09-25 01:34:43.000000000","message":"Good suggestion, thanks!","commit_id":"daf846d1013cc0b2ba466b1e3e0197f77a60bf15"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2cdfa6925fed0f891dec0a3ca1ab86f33934ee5","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"                          self.driver.create_volume, test_volume)"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"        self.assertRaises(exception.VolumeBackendAPIException,"},{"line_number":1481,"context_line":"                          self.driver.create_volume, error_volume)"},{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"    def test_delete_volume_fail(self):"},{"line_number":1484,"context_line":"        self.driver.restclient.login()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_3c6e19ca","side":"PARENT","line":1481,"updated":"2015-09-25 08:15:27.000000000","message":"-1: If you remove the only 2 uses of error_volume in the tests that global variable should be removed.","commit_id":"40237051c8bf55cd20be7ced35140924d4e33820"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"ad8d5b6fd76a8468eddfb88458ee49bbe3c248a4","unresolved":false,"context_lines":[{"line_number":1478,"context_line":"                          self.driver.create_volume, test_volume)"},{"line_number":1479,"context_line":""},{"line_number":1480,"context_line":"        self.assertRaises(exception.VolumeBackendAPIException,"},{"line_number":1481,"context_line":"                          self.driver.create_volume, error_volume)"},{"line_number":1482,"context_line":""},{"line_number":1483,"context_line":"    def test_delete_volume_fail(self):"},{"line_number":1484,"context_line":"        self.driver.restclient.login()"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_adbf55cf","side":"PARENT","line":1481,"in_reply_to":"9a1a9d01_3c6e19ca","updated":"2015-09-25 10:01:40.000000000","message":"Done","commit_id":"40237051c8bf55cd20be7ced35140924d4e33820"}],"cinder/volume/drivers/huawei/rest_client.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2cdfa6925fed0f891dec0a3ca1ab86f33934ee5","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                       item[\u0027USAGETYPE\u0027] \u003d\u003d constants.FILE_SYSTEM_POOL_TYPE):"},{"line_number":217,"context_line":"                        break"},{"line_number":218,"context_line":"                    pool_info[\u0027ID\u0027] \u003d item[\u0027ID\u0027]"},{"line_number":219,"context_line":"                    if (\u0027DATASPACE\u0027 in item):"},{"line_number":220,"context_line":"                        pool_info[\u0027CAPACITY\u0027] \u003d item[\u0027DATASPACE\u0027]"},{"line_number":221,"context_line":"                    else:"},{"line_number":222,"context_line":"                        pool_info[\u0027CAPACITY\u0027] \u003d item[\u0027USERFREECAPACITY\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_59a43f56","line":219,"updated":"2015-09-25 08:15:27.000000000","message":"nit: No need for parenthesis","commit_id":"b3f7b8d912ae7bbce1548953c35dbc0fc5d35ec4"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"ad8d5b6fd76a8468eddfb88458ee49bbe3c248a4","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                       item[\u0027USAGETYPE\u0027] \u003d\u003d constants.FILE_SYSTEM_POOL_TYPE):"},{"line_number":217,"context_line":"                        break"},{"line_number":218,"context_line":"                    pool_info[\u0027ID\u0027] \u003d item[\u0027ID\u0027]"},{"line_number":219,"context_line":"                    if (\u0027DATASPACE\u0027 in item):"},{"line_number":220,"context_line":"                        pool_info[\u0027CAPACITY\u0027] \u003d item[\u0027DATASPACE\u0027]"},{"line_number":221,"context_line":"                    else:"},{"line_number":222,"context_line":"                        pool_info[\u0027CAPACITY\u0027] \u003d item[\u0027USERFREECAPACITY\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_8da131ac","line":219,"in_reply_to":"9a1a9d01_59a43f56","updated":"2015-09-25 10:01:40.000000000","message":"Done","commit_id":"b3f7b8d912ae7bbce1548953c35dbc0fc5d35ec4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2cdfa6925fed0f891dec0a3ca1ab86f33934ee5","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                    if (\u0027DATASPACE\u0027 in item):"},{"line_number":220,"context_line":"                        pool_info[\u0027CAPACITY\u0027] \u003d item[\u0027DATASPACE\u0027]"},{"line_number":221,"context_line":"                    else:"},{"line_number":222,"context_line":"                        pool_info[\u0027CAPACITY\u0027] \u003d item[\u0027USERFREECAPACITY\u0027]"},{"line_number":223,"context_line":"                    pool_info[\u0027TOTALCAPACITY\u0027] \u003d item[\u0027USERTOTALCAPACITY\u0027]"},{"line_number":224,"context_line":"                    break"},{"line_number":225,"context_line":"        return pool_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_d9f92f4f","line":222,"updated":"2015-09-25 08:15:27.000000000","message":"nit: This would look better as:\n\n pool_info[\u0027CAPACITY\u0027] \u003d item.get(\u0027DATASPACE\u0027, item[\u0027USERFREECAPACITY\u0027])","commit_id":"b3f7b8d912ae7bbce1548953c35dbc0fc5d35ec4"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"ad8d5b6fd76a8468eddfb88458ee49bbe3c248a4","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                    if (\u0027DATASPACE\u0027 in item):"},{"line_number":220,"context_line":"                        pool_info[\u0027CAPACITY\u0027] \u003d item[\u0027DATASPACE\u0027]"},{"line_number":221,"context_line":"                    else:"},{"line_number":222,"context_line":"                        pool_info[\u0027CAPACITY\u0027] \u003d item[\u0027USERFREECAPACITY\u0027]"},{"line_number":223,"context_line":"                    pool_info[\u0027TOTALCAPACITY\u0027] \u003d item[\u0027USERTOTALCAPACITY\u0027]"},{"line_number":224,"context_line":"                    break"},{"line_number":225,"context_line":"        return pool_info"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_6d113dac","line":222,"in_reply_to":"9a1a9d01_d9f92f4f","updated":"2015-09-25 10:01:40.000000000","message":"Done","commit_id":"b3f7b8d912ae7bbce1548953c35dbc0fc5d35ec4"}]}