)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e0e17a5c1bce19a809b0ad8d53c083b004ec8053","unresolved":false,"context_lines":[{"line_number":10,"context_line":"there is no pool info related to the volume, but the new"},{"line_number":11,"context_line":"version of Huawei driver assumes that the volume have the"},{"line_number":12,"context_line":"pool info and will read the pool info from the volume,"},{"line_number":13,"context_line":"and then the read failed. This will happen when we call"},{"line_number":14,"context_line":"create_volume_from_snapshot() in new version of Huawei"},{"line_number":15,"context_line":"driver when the volume is created by old version of Huawei"},{"line_number":16,"context_line":"driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_fcaf41e1","line":13,"updated":"2015-09-25 08:34:53.000000000","message":"nit: s/failed/fails","commit_id":"dffc0485e2b8e7512f5edb54c14049ec492f4ad6"}],"cinder/volume/drivers/huawei/huawei_driver.py":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2d7b250b2e2e8394b607254ca90710bd00474a65","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                        \u0027Please check the config file.\u0027)"},{"line_number":94,"context_line":"                LOG.error(msg)"},{"line_number":95,"context_line":"                raise exception.InvalidInput(msg)"},{"line_number":96,"context_line":"            for pool_name in pool_names.split(\";\"):"},{"line_number":97,"context_line":"                pool_info \u003d self.restclient.find_pool_info(pool_name,"},{"line_number":98,"context_line":"                                                           pools)"},{"line_number":99,"context_line":"                if pool_info:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_66f3a974","line":96,"updated":"2015-09-25 02:13:39.000000000","message":"I do not see this case is getting exercised in the unit tests","commit_id":"4deec3fef1da99f5468ba83ba42795323843949c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e0e17a5c1bce19a809b0ad8d53c083b004ec8053","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        pool_info \u003d self.restclient.find_pool_info(pool_name,"},{"line_number":85,"context_line":"                                                   pools)"},{"line_number":86,"context_line":"        if not pool_info:"},{"line_number":87,"context_line":"            # The following code is to keep compatibility with old version of"},{"line_number":88,"context_line":"            # Huawei driver."},{"line_number":89,"context_line":"            root \u003d huawei_utils.parse_xml_file(self.xml_file_path)"},{"line_number":90,"context_line":"            pool_names \u003d root.findtext(\u0027LUN/StoragePool\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_5c88ade7","line":87,"updated":"2015-09-25 08:34:53.000000000","message":"nit: Maybe change this comment to give detail like you do in commit message, ie:\n\n # In old driver version there is no pool info, we have search for it.","commit_id":"dffc0485e2b8e7512f5edb54c14049ec492f4ad6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e0e17a5c1bce19a809b0ad8d53c083b004ec8053","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        if not pool_info:"},{"line_number":87,"context_line":"            # The following code is to keep compatibility with old version of"},{"line_number":88,"context_line":"            # Huawei driver."},{"line_number":89,"context_line":"            root \u003d huawei_utils.parse_xml_file(self.xml_file_path)"},{"line_number":90,"context_line":"            pool_names \u003d root.findtext(\u0027LUN/StoragePool\u0027)"},{"line_number":91,"context_line":"            if not pool_names:"},{"line_number":92,"context_line":"                msg \u003d _(\u0027Invalid resource pool name. \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_fcce6182","line":89,"updated":"2015-09-25 08:34:53.000000000","message":"-1: From here to line 95 should be moved to a helper function in huawei_utils.py","commit_id":"dffc0485e2b8e7512f5edb54c14049ec492f4ad6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e0e17a5c1bce19a809b0ad8d53c083b004ec8053","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                pool_info \u003d self.restclient.find_pool_info(pool_name,"},{"line_number":98,"context_line":"                                                           pools)"},{"line_number":99,"context_line":"                if pool_info:"},{"line_number":100,"context_line":"                    break"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        volume_name \u003d huawei_utils.encode_name(volume[\u0027id\u0027])"},{"line_number":103,"context_line":"        volume_description \u003d volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_dc74bdfe","line":100,"updated":"2015-09-25 08:34:53.000000000","message":"?: Would it be possible to store this pool_info so the next time we don\u0027t have to search for it again?","commit_id":"dffc0485e2b8e7512f5edb54c14049ec492f4ad6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dbd36436e9a6beaf83bb05b4fb73be5ff8c1c61f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if not pool_info:"},{"line_number":86,"context_line":"            # The following code is to keep compatibility with old version of"},{"line_number":87,"context_line":"            # Huawei driver."},{"line_number":88,"context_line":"            root \u003d huawei_utils.parse_xml_file(self.xml_file_path)"},{"line_number":89,"context_line":"            pool_names \u003d root.findtext(\u0027LUN/StoragePool\u0027)"},{"line_number":90,"context_line":"            if not pool_names:"},{"line_number":91,"context_line":"                msg \u003d _(\u0027Invalid resource pool name. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_247ebf19","line":88,"updated":"2015-09-28 12:34:04.000000000","message":"-1: From here to line 94 should be moved to a helper function in huawei_utils.py","commit_id":"56ac8ecaa3696ef5f3d9cd75611f72e9d8e9e9c5"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"af7691111b002ab13200ba6d8b9fd7d7c3882b2f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        if not pool_info:"},{"line_number":86,"context_line":"            # The following code is to keep compatibility with old version of"},{"line_number":87,"context_line":"            # Huawei driver."},{"line_number":88,"context_line":"            root \u003d huawei_utils.parse_xml_file(self.xml_file_path)"},{"line_number":89,"context_line":"            pool_names \u003d root.findtext(\u0027LUN/StoragePool\u0027)"},{"line_number":90,"context_line":"            if not pool_names:"},{"line_number":91,"context_line":"                msg \u003d _(\u0027Invalid resource pool name. \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_27dd61e0","line":88,"in_reply_to":"9a1a9d01_247ebf19","updated":"2015-09-28 13:19:30.000000000","message":"Done, thanks!","commit_id":"56ac8ecaa3696ef5f3d9cd75611f72e9d8e9e9c5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dbd36436e9a6beaf83bb05b4fb73be5ff8c1c61f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                pool_info \u003d self.restclient.find_pool_info(pool_name,"},{"line_number":97,"context_line":"                                                           pools)"},{"line_number":98,"context_line":"                if pool_info:"},{"line_number":99,"context_line":"                    break"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        volume_name \u003d huawei_utils.encode_name(volume[\u0027id\u0027])"},{"line_number":102,"context_line":"        volume_description \u003d volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_e4776738","line":99,"updated":"2015-09-28 12:34:04.000000000","message":"?: Would it be possible to store this pool_info so the next time we don\u0027t have to search for it again?","commit_id":"56ac8ecaa3696ef5f3d9cd75611f72e9d8e9e9c5"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"af7691111b002ab13200ba6d8b9fd7d7c3882b2f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                pool_info \u003d self.restclient.find_pool_info(pool_name,"},{"line_number":97,"context_line":"                                                           pools)"},{"line_number":98,"context_line":"                if pool_info:"},{"line_number":99,"context_line":"                    break"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        volume_name \u003d huawei_utils.encode_name(volume[\u0027id\u0027])"},{"line_number":102,"context_line":"        volume_description \u003d volume[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a1a9d01_e759a95b","line":99,"in_reply_to":"9a1a9d01_e4776738","updated":"2015-09-28 13:19:30.000000000","message":"Thanks, it\u0027s a good suggestion. But the function \"find_pool_info\" is just a quick function that won\u0027t spend much time, so I think there is no strong reason to change this code.","commit_id":"56ac8ecaa3696ef5f3d9cd75611f72e9d8e9e9c5"}]}