)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77133ceb21415b338b8d8507ce125eb0855c2ae0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Einst Crazy \u003cyu.changcai@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-25 00:27:31 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Gluster: extand volume to the right path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\tAs it extand volume to the volume path, not the active one,"},{"line_number":10,"context_line":"\tit comes to extand to wrong path. extand the active one."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_eab8eae7","line":7,"updated":"2015-09-24 18:26:42.000000000","message":"Typo extend -\u003e extend","commit_id":"6e3df022eeebccf42bcf08b980d75a93454f28ea"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77133ceb21415b338b8d8507ce125eb0855c2ae0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Gluster: extand volume to the right path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\tAs it extand volume to the volume path, not the active one,"},{"line_number":10,"context_line":"\tit comes to extand to wrong path. extand the active one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tClosed-Bug: 1499452"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_eaaf8a92","line":9,"updated":"2015-09-24 18:26:42.000000000","message":"No tabs here and typo here.","commit_id":"6e3df022eeebccf42bcf08b980d75a93454f28ea"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"77133ceb21415b338b8d8507ce125eb0855c2ae0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"\tit comes to extand to wrong path. extand the active one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tClosed-Bug: 1499452"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2f19a721f4d3e9b05601e820e10a6eb1328a68a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_aa799231","line":13,"updated":"2015-09-24 18:26:42.000000000","message":"Closes-bug:","commit_id":"6e3df022eeebccf42bcf08b980d75a93454f28ea"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bde29cdfc73f75e2c4404a7c8040cd03242a700a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Gluster: extend volume to the right path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\tAs it extend volume to the volume path, not the active one,"},{"line_number":10,"context_line":"\tit comes to extend to wrong path. extend the active one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tClosed-Bug: 1499452"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_fc5e6144","line":9,"updated":"2015-09-25 08:47:21.000000000","message":"nit: s/extend volume to/extends volume on","commit_id":"e1cc2812c3da7d6feed35152b662891c215a3316"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bde29cdfc73f75e2c4404a7c8040cd03242a700a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Gluster: extend volume to the right path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"\tAs it extend volume to the volume path, not the active one,"},{"line_number":10,"context_line":"\tit comes to extend to wrong path. extend the active one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tClosed-Bug: 1499452"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_dc559d1d","line":10,"updated":"2015-09-25 08:47:21.000000000","message":"nit: s/extend to wrong/extend volume on the wrong\n\nnit: s/extend the/With this patch we extend the","commit_id":"e1cc2812c3da7d6feed35152b662891c215a3316"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bde29cdfc73f75e2c4404a7c8040cd03242a700a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"\tAs it extend volume to the volume path, not the active one,"},{"line_number":10,"context_line":"\tit comes to extend to wrong path. extend the active one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"\tClosed-Bug: 1499452"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2f19a721f4d3e9b05601e820e10a6eb1328a68a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_3c6db904","line":12,"updated":"2015-09-25 08:47:21.000000000","message":"nit: No tabs, please","commit_id":"e1cc2812c3da7d6feed35152b662891c215a3316"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"07ae43055c595b388d449b7c7db77379eb6c4518","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Einst Crazy \u003cyu.changcai@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-25 22:16:55 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Gluster: extend volume to the right path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As it extend volume on the volume path, not the active one,"},{"line_number":10,"context_line":"it comes to extend on wrong path. extend the active one."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_48fa1dbf","line":7,"updated":"2015-09-25 15:00:25.000000000","message":"s/Gluster/GlusterFS/","commit_id":"85ecb01bbadbcfc7b3aa62dfda17c09dd1fc5433"},{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"07ae43055c595b388d449b7c7db77379eb6c4518","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Gluster: extend volume to the right path"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As it extend volume on the volume path, not the active one,"},{"line_number":10,"context_line":"it comes to extend on wrong path. extend the active one."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1499452"},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_c82b8dea","line":10,"updated":"2015-09-25 15:00:25.000000000","message":"You should reword this:\n\nExtend volume uses the wrong volume file path.  It should extend the active volume file path.","commit_id":"85ecb01bbadbcfc7b3aa62dfda17c09dd1fc5433"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ae48370e1d707e47b22b4fc694e497dd4687a6e6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Extend volume uses the wrong volume file path. It should"},{"line_number":10,"context_line":"extend the active volume file path."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1499452"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I2f19a721f4d3e9b05601e820e10a6eb1328a68a9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_8ee1e200","line":11,"updated":"2015-09-28 14:27:53.000000000","message":"Please note that this also fixes something in backup too.","commit_id":"9cf400b7b124a5fd4054abb953a1928cf7d128bb"}],"cinder/tests/unit/test_glusterfs.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bde29cdfc73f75e2c4404a7c8040cd03242a700a","unresolved":false,"context_lines":[{"line_number":933,"context_line":"            mock_qemu_img_info.return_value \u003d img_info"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"            drv.extend_volume(volume, 3)"},{"line_number":936,"context_line":"            self.assertTrue(mock_resize_image.called)"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"    def test_create_snapshot_online(self):"},{"line_number":939,"context_line":"        drv \u003d self._driver"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_073bc2d2","line":936,"updated":"2015-09-25 08:47:21.000000000","message":"-1: Please use `mock_resize_image.assert_called_once_with` to make sure it is being called with the active volume path. Otherwise we are not really testing the change.","commit_id":"e1cc2812c3da7d6feed35152b662891c215a3316"},{"author":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"change_message_id":"42fad799c1282e4416e9a5565fdbf1c7c7faa972","unresolved":false,"context_lines":[{"line_number":933,"context_line":"            mock_qemu_img_info.return_value \u003d img_info"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"            drv.extend_volume(volume, 3)"},{"line_number":936,"context_line":"            self.assertTrue(mock_resize_image.called)"},{"line_number":937,"context_line":""},{"line_number":938,"context_line":"    def test_create_snapshot_online(self):"},{"line_number":939,"context_line":"        drv \u003d self._driver"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_08faefbd","line":936,"in_reply_to":"9a1a9d01_073bc2d2","updated":"2015-09-25 10:17:01.000000000","message":"Done","commit_id":"e1cc2812c3da7d6feed35152b662891c215a3316"}],"cinder/volume/drivers/glusterfs.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"07ae43055c595b388d449b7c7db77379eb6c4518","unresolved":false,"context_lines":[{"line_number":309,"context_line":""},{"line_number":310,"context_line":"    @remotefs_drv.locked_volume_id_operation"},{"line_number":311,"context_line":"    def extend_volume(self, volume, size_gb):"},{"line_number":312,"context_line":"        volume_dir \u003d self._local_volume_dir(volume)"},{"line_number":313,"context_line":"        volume_path \u003d os.path.join("},{"line_number":314,"context_line":"            volume_dir,"},{"line_number":315,"context_line":"            self.get_active_image_from_info(volume))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_c8a14dab","line":312,"updated":"2015-09-25 15:00:25.000000000","message":"This is equivalent to L243 and L452.  Maybe you should create a private method, e.g. _active_volume_path, to consolidate the redundant code.  Just a suggestion, nothing wrong with the code.","commit_id":"85ecb01bbadbcfc7b3aa62dfda17c09dd1fc5433"}]}