)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"73d5cf1189d0b2aa9c80dbb86eb06bff3df9b463","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"extend is not exception error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add extend exception when volume isn\u0027t available."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I93e81514c9c1bea9fa80cfb14c5f1d4b00dd0c28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_027f19ab","line":9,"updated":"2015-09-25 18:58:05.000000000","message":"What\u0027s the current behavior when this case is hit?  How does this patch change/improve on that situation?","commit_id":"02c71330ed5546dd291964eb98af1e4757324ff4"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"387939adad06392382bc45bcd8ac264c8b753aae","unresolved":false,"context_lines":[{"line_number":7,"context_line":"extend is not exception error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add extend exception when volume isn\u0027t available."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I93e81514c9c1bea9fa80cfb14c5f1d4b00dd0c28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_1fef6b88","line":10,"updated":"2015-09-25 21:02:59.000000000","message":"You also need API impact as this is behavior change in API","commit_id":"02c71330ed5546dd291964eb98af1e4757324ff4"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ac3bd95a7bf81e199615bfd29c42d2643db99e0c","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Jinnan \u003czhang.jinnan@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-27 16:12:02 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"extend is not exception error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volume extend error not catch exception"},{"line_number":10,"context_line":"when volume in used or other status."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9a1a9d01_1f166ca7","line":7,"updated":"2015-09-28 09:18:51.000000000","message":"Please, write more user-friendly commit message header","commit_id":"aec3e0373ef28b82deffd8a6f23163d7abcb9c8e"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"751f17e9adb317c4d686293d60745bd779a82b67","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Jinnan \u003czhang.jinnan@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-09-29 21:53:03 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"not exception error when extend error status volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volume extend error not catch exception"},{"line_number":10,"context_line":"when volume in used or other status."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_428b63c3","line":7,"updated":"2015-09-29 17:13:23.000000000","message":"Suggesting modification:\n\nVolume extension API does not throw HttpBadRequest response, when input to the API is invalid.\n\nThis patch handles invalid input to the volume extension API and sneds out HTTP bad request.","commit_id":"a7b56f5fe4ba923fe618476c2441ff92433093e7"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"841e2d2c01f9354863cbe6133c18ae851250bf83","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"not exception error when extend error status volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volume extend error not catch exception"},{"line_number":10,"context_line":"when volume in used or other status."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add extend exception when volume isn\u0027t available status."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_6014314c","line":9,"updated":"2015-09-30 16:14:50.000000000","message":"Suggestion: \u0027extend error not catch exception\u0027 to \u0027error does not catch exception\u0027","commit_id":"a7b56f5fe4ba923fe618476c2441ff92433093e7"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"841e2d2c01f9354863cbe6133c18ae851250bf83","unresolved":false,"context_lines":[{"line_number":7,"context_line":"not exception error when extend error status volume"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volume extend error not catch exception"},{"line_number":10,"context_line":"when volume in used or other status."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add extend exception when volume isn\u0027t available status."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_c38f4773","line":10,"updated":"2015-09-30 16:14:50.000000000","message":"Suggestion: \u0027volume in used\u0027 -\u003e \u0027volume is in use\u0027","commit_id":"a7b56f5fe4ba923fe618476c2441ff92433093e7"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"841e2d2c01f9354863cbe6133c18ae851250bf83","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Volume extend error not catch exception"},{"line_number":10,"context_line":"when volume in used or other status."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add extend exception when volume isn\u0027t available status."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1499948"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_03fd3fb3","line":12,"updated":"2015-09-30 16:14:50.000000000","message":"Suggestion: \u0027isn\u0027t available status.\u0027 to \u0027status isn\u0027t available.\u0027","commit_id":"a7b56f5fe4ba923fe618476c2441ff92433093e7"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"751f17e9adb317c4d686293d60745bd779a82b67","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Add extend exception when volume isn\u0027t available status."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-bug: #1499948"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I93e81514c9c1bea9fa80cfb14c5f1d4b00dd0c28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9a1a9d01_e26957fa","line":14,"updated":"2015-09-29 17:13:23.000000000","message":"Since this is changing API error response for invalid input case, I would suggest \"APIImpact\" keyword.","commit_id":"a7b56f5fe4ba923fe618476c2441ff92433093e7"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7252fa8c667d15c3d9bdbf99e666d2d930d430d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Zhang Jinnan \u003czhang.jinnan@99cloud.net\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-05 10:31:43 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Volume extend error not catch exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volume extension API does not throw HttpBadRequest response,"},{"line_number":10,"context_line":"when input to the API is invalid."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a2fa921_0bfe3137","line":7,"updated":"2015-10-07 13:05:49.000000000","message":"Suggest: \"Volume extend error does not catch exception\"","commit_id":"ac273c23005402d029cdd295552c66545ce569ee"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"7252fa8c667d15c3d9bdbf99e666d2d930d430d4","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Volume extension API does not throw HttpBadRequest response,"},{"line_number":10,"context_line":"when input to the API is invalid."},{"line_number":11,"context_line":"This patch handles invalid input to the volume extension API"},{"line_number":12,"context_line":"and sneds out HTTP bad request."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":"Change-Id: I93e81514c9c1bea9fa80cfb14c5f1d4b00dd0c28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7a2fa921_cbbd9969","line":12,"updated":"2015-10-07 13:05:49.000000000","message":"sneds-\u003e sends","commit_id":"ac273c23005402d029cdd295552c66545ce569ee"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"bbd183b0e1357725f29f53c24492a14a0d68f483","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Volume extension API does not throw HttpBadRequest response,"},{"line_number":10,"context_line":"when input to the API is invalid."},{"line_number":11,"context_line":"This patch handles invalid input to the volume extension API"},{"line_number":12,"context_line":"and sends out HTTP bad request."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact"},{"line_number":15,"context_line":"Change-Id: I93e81514c9c1bea9fa80cfb14c5f1d4b00dd0c28"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"7a2fa921_f992134b","line":12,"updated":"2015-10-11 18:17:18.000000000","message":"should update this to say it will return an HTTP Conflict","commit_id":"5b11dfd3b9e493c0bc6aa2e91963319684b8a427"},{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"0f3b70894c31671650c4969f35d530b11e9f13df","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Volume extend error does not catch exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Volume extension API does not throw HttpBadRequest response,"},{"line_number":10,"context_line":"when input to the API is invalid."},{"line_number":11,"context_line":"This patch handles invalid input to the volume extension API"},{"line_number":12,"context_line":"and return an HTTP Conflict."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a2fa921_3c4ab9ad","line":9,"updated":"2015-10-12 00:04:47.000000000","message":"Here, should be HttpConflict?","commit_id":"4280486fc727f5def53d0a0f79af6ac3642c4ae0"}],"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ac3bd95a7bf81e199615bfd29c42d2643db99e0c","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                    \u0027to extend, but current status is: \u0027"},{"line_number":323,"context_line":"                    \u0027%(vol_status)s.\u0027) % {\u0027vol_id\u0027: volume[\u0027id\u0027],"},{"line_number":324,"context_line":"                                          \u0027vol_status\u0027: volume[\u0027status\u0027]}"},{"line_number":325,"context_line":"            LOG.error(msg)"},{"line_number":326,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003derror.msg)"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        return webob.Response(status_int\u003d202)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a1a9d01_1f642c47","line":325,"updated":"2015-09-28 09:18:51.000000000","message":"LOG.error(error) or even LOG.exception(error) will be enough here","commit_id":"aec3e0373ef28b82deffd8a6f23163d7abcb9c8e"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"751f17e9adb317c4d686293d60745bd779a82b67","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            self.volume_api.extend(context, volume, size)"},{"line_number":320,"context_line":"        except exception.InvalidVolume as error:"},{"line_number":321,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003derror.msg)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9a1a9d01_e2507734","line":321,"updated":"2015-09-29 17:13:23.000000000","message":"I would suggest adding unit test to expect this exception","commit_id":"a7b56f5fe4ba923fe618476c2441ff92433093e7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"c34542a73b8d1f4e25dfc671c15416843c02d10a","unresolved":false,"context_lines":[{"line_number":318,"context_line":"        try:"},{"line_number":319,"context_line":"            self.volume_api.extend(context, volume, size)"},{"line_number":320,"context_line":"        except exception.InvalidVolume as error:"},{"line_number":321,"context_line":"            raise webob.exc.HTTPConflict(explanation\u003derror.msg)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        return webob.Response(status_int\u003d202)"},{"line_number":324,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a2fa921_09e572a6","line":321,"updated":"2015-10-09 09:49:33.000000000","message":"Looks like it should be HTTPBadRequest instead of HTTPConflict","commit_id":"5af80a2e148b36d6ced48b898cd5998a548052b6"}]}