)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"3417e0e3989f3d11965e4555c13148306fb75ced","unresolved":false,"context_lines":[{"line_number":14,"context_line":"file directly."},{"line_number":15,"context_line":"This patch propose to change the way to obtain authentication"},{"line_number":16,"context_line":"at _get_target_chap_auth()."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Anish Bhatt \u003canish@chelsio.com\u003e"},{"line_number":19,"context_line":"Change-Id: I5188ce5855d206c513f72e01f010175490ec89b2"},{"line_number":20,"context_line":"Partial-Bug: #1499795"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_dbd411ed","line":17,"updated":"2015-09-30 14:55:26.000000000","message":"I suggest adding in discussion about how _get_target_chap_auth() was removed from several files in favor of defining it inside the iscsi.py file.","commit_id":"7602273666ae0ee37e355f458a17dd343425a517"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"66e4325cf3b631b3b53469d2fcb29bc8facad9d7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"file directly."},{"line_number":15,"context_line":"This patch propose to change the way to obtain authentication"},{"line_number":16,"context_line":"at _get_target_chap_auth()."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Co-Authored-By: Anish Bhatt \u003canish@chelsio.com\u003e"},{"line_number":19,"context_line":"Change-Id: I5188ce5855d206c513f72e01f010175490ec89b2"},{"line_number":20,"context_line":"Partial-Bug: #1499795"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9a1a9d01_28984e1b","line":17,"in_reply_to":"9a1a9d01_dbd411ed","updated":"2015-09-30 22:50:53.000000000","message":"Done","commit_id":"7602273666ae0ee37e355f458a17dd343425a517"}],"cinder/tests/unit/targets/test_iet_driver.py":[{"author":{"_account_id":12088,"name":"Anish Bhatt","email":"anish.7@gmail.com","username":"anish"},"change_message_id":"a1b64f9286b803c702f3f6023a5a88bbb4765751","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":60,"context_line":"        self.assertEqual((\u0027otzLy2UYbYfnP4zXLG5z\u0027, \u0027234Zweo38VGBBvrpK9nt\u0027),"},{"line_number":61,"context_line":"                         self.target._get_target_chap_auth(ctxt,"},{"line_number":62,"context_line":"                                                           self.test_vol))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @mock.patch(\u0027cinder.volume.targets.iet.IetAdm._get_target\u0027,"},{"line_number":65,"context_line":"                return_value\u003d0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_faeb8e76","line":62,"updated":"2015-09-28 04:33:41.000000000","message":"I based my changes the same way, but maybe since it\u0027s the same code in all helpers, we could move it to test_base_iscsi_driver.py ?","commit_id":"4949338b6dee50dd732d0111841e17fafe36dd37"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"346cf34b92bc1130b983b3b826417f904019ad78","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":60,"context_line":"        self.assertEqual((\u0027otzLy2UYbYfnP4zXLG5z\u0027, \u0027234Zweo38VGBBvrpK9nt\u0027),"},{"line_number":61,"context_line":"                         self.target._get_target_chap_auth(ctxt,"},{"line_number":62,"context_line":"                                                           self.test_vol))"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    @mock.patch(\u0027cinder.volume.targets.iet.IetAdm._get_target\u0027,"},{"line_number":65,"context_line":"                return_value\u003d0)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_36d496bb","line":62,"in_reply_to":"9a1a9d01_faeb8e76","updated":"2015-09-29 00:08:30.000000000","message":"test_base_iscsi_driver.py uses fake target and _get_target_chap_auth in fake target is nothing to do(just pass). so I suppose we need to implement test of _get_target_chap_auth on each target individually.","commit_id":"4949338b6dee50dd732d0111841e17fafe36dd37"}],"cinder/volume/targets/iscsi.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"3417e0e3989f3d11965e4555c13148306fb75ced","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            if volume_info[\u0027provider_auth\u0027]:"},{"line_number":337,"context_line":"                return tuple(volume_info[\u0027provider_auth\u0027].split(\u0027 \u0027, 3)[1:])"},{"line_number":338,"context_line":"        except exception.NotFound:"},{"line_number":339,"context_line":"            LOG.debug(\u0027Failed to get CHAP auth from DB for %s\u0027, vol_id)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    @abc.abstractmethod"},{"line_number":342,"context_line":"    def _get_target_and_lun(self, context, volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_db23b154","line":339,"updated":"2015-09-30 14:55:26.000000000","message":"\".\" at EOL","commit_id":"7602273666ae0ee37e355f458a17dd343425a517"},{"author":{"_account_id":10115,"name":"Mitsuhiro Tanino","email":"mitsuhiro.tanino@lycorp.co.jp","username":"mtanino"},"change_message_id":"66e4325cf3b631b3b53469d2fcb29bc8facad9d7","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            if volume_info[\u0027provider_auth\u0027]:"},{"line_number":337,"context_line":"                return tuple(volume_info[\u0027provider_auth\u0027].split(\u0027 \u0027, 3)[1:])"},{"line_number":338,"context_line":"        except exception.NotFound:"},{"line_number":339,"context_line":"            LOG.debug(\u0027Failed to get CHAP auth from DB for %s\u0027, vol_id)"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"    @abc.abstractmethod"},{"line_number":342,"context_line":"    def _get_target_and_lun(self, context, volume):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_88f63a5b","line":339,"in_reply_to":"9a1a9d01_db23b154","updated":"2015-09-30 22:50:53.000000000","message":"Done","commit_id":"7602273666ae0ee37e355f458a17dd343425a517"}]}