)]}'
{"cinder/tests/unit/test_drbdmanagedrv.py":[{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"8942b9d5fb7e46c4fff827cafb36cad45ea1b98a","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        self.assertEqual(\"create_volume\", dmd.odm.calls[2][0])"},{"line_number":227,"context_line":"        self.assertEqual(1048576, dmd.odm.calls[2][2])"},{"line_number":228,"context_line":"        self.assertEqual(\"auto_deploy\", dmd.odm.calls[3][0])"},{"line_number":229,"context_line":"        self.assertEqual(len(dmd.odm.calls), 4)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_create_volume_controller_all_vols(self):"},{"line_number":232,"context_line":"        testvol \u003d {\u0027project_id\u0027: \u0027testprjid\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_c393b559","line":229,"updated":"2015-09-30 23:16:47.000000000","message":"Looks like you\u0027ve listed 5 calls here but are asserting that there should be 4, that\u0027s why the python gate tests aren\u0027t passing. Should work after that small fix!","commit_id":"f4ebe6df38a0a98529282b0f8d43809e1506e854"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"656bf152097eacc7f8ec34382f63ab3263c8e195","unresolved":false,"context_lines":[{"line_number":226,"context_line":"        self.assertEqual(\"create_volume\", dmd.odm.calls[2][0])"},{"line_number":227,"context_line":"        self.assertEqual(1048576, dmd.odm.calls[2][2])"},{"line_number":228,"context_line":"        self.assertEqual(\"auto_deploy\", dmd.odm.calls[3][0])"},{"line_number":229,"context_line":"        self.assertEqual(len(dmd.odm.calls), 4)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_create_volume_controller_all_vols(self):"},{"line_number":232,"context_line":"        testvol \u003d {\u0027project_id\u0027: \u0027testprjid\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_52176444","line":229,"in_reply_to":"9a1a9d01_c393b559","updated":"2015-10-01 07:59:15.000000000","message":"Done","commit_id":"f4ebe6df38a0a98529282b0f8d43809e1506e854"}],"cinder/volume/drivers/drbdmanagedrv.py":[{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"b7082b7359f7a4762b61a789a73f23239e9e5113","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027drbdmanage_devs_on_controller\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse,"},{"line_number":60,"context_line":"                help\u003d\u0027\u0027\u0027Whether the controller node should receive all"},{"line_number":61,"context_line":"                devices (eg. as DRBD client), too\u0027\u0027\u0027),"},{"line_number":62,"context_line":"    # TODO(PM): offsite_redundancy?"},{"line_number":63,"context_line":"    # TODO(PM): choose DRBDmanage storage pool?"},{"line_number":64,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_c42e7a8b","line":61,"updated":"2015-09-30 13:25:55.000000000","message":"The sentence structure here is a bit confusing. Maybe something like \"Indicates whether the controller node should receive all devices (eg. the DRBD client)\" would work if I understand it correctly. I\u0027m not sure what the trailing \"too\" is for.","commit_id":"28e051c112e5f9ad155514445503ae675309f416"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"a9236fe8940739c1e5876c6c19bc8fe918992b5b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    cfg.BoolOpt(\u0027drbdmanage_devs_on_controller\u0027,"},{"line_number":59,"context_line":"                default\u003dFalse,"},{"line_number":60,"context_line":"                help\u003d\u0027\u0027\u0027Whether the controller node should receive all"},{"line_number":61,"context_line":"                devices (eg. as DRBD client), too\u0027\u0027\u0027),"},{"line_number":62,"context_line":"    # TODO(PM): offsite_redundancy?"},{"line_number":63,"context_line":"    # TODO(PM): choose DRBDmanage storage pool?"},{"line_number":64,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_2f406206","line":61,"in_reply_to":"9a1a9d01_c42e7a8b","updated":"2015-09-30 17:18:17.000000000","message":"Thanks, I changed the text - hoping that it\u0027s easier to understand now.","commit_id":"28e051c112e5f9ad155514445503ae675309f416"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"caae545cff97b24dd8bd6cf911b000f684ad0399","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                                         dres,"},{"line_number":351,"context_line":"                                         self.empty_dict)"},{"line_number":352,"context_line":"            self._check_result(res, ignore\u003d[dm_exc.DM_EEXIST])"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        return 0"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def delete_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_0ad23428","line":353,"updated":"2015-09-30 15:24:40.000000000","message":"I am wondering if we need to add/update unit tests in order test out this new if statement.","commit_id":"28e051c112e5f9ad155514445503ae675309f416"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"a9236fe8940739c1e5876c6c19bc8fe918992b5b","unresolved":false,"context_lines":[{"line_number":350,"context_line":"                                         dres,"},{"line_number":351,"context_line":"                                         self.empty_dict)"},{"line_number":352,"context_line":"            self._check_result(res, ignore\u003d[dm_exc.DM_EEXIST])"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        return 0"},{"line_number":355,"context_line":""},{"line_number":356,"context_line":"    def delete_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_cfe1a62b","line":353,"in_reply_to":"9a1a9d01_0ad23428","updated":"2015-09-30 17:18:17.000000000","message":"Yeah, already done for patch set 2.","commit_id":"28e051c112e5f9ad155514445503ae675309f416"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"81476e9de801f1329b38cfdbf3801a6f4e937fcf","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                help\u003d\u0027\u0027\u0027If set, the controller will have all the"},{"line_number":61,"context_line":"                devices available, too, even if the controller node"},{"line_number":62,"context_line":"                doesn\u0027t have a local copy (ie. only other DRBD"},{"line_number":63,"context_line":"                storage have the data).\u0027\u0027\u0027),"},{"line_number":64,"context_line":"    # TODO(PM): offsite_redundancy?"},{"line_number":65,"context_line":"    # TODO(PM): choose DRBDmanage storage pool?"},{"line_number":66,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_0508da26","line":63,"updated":"2015-09-30 19:48:28.000000000","message":"Hmm, this still isn\u0027t really a very clear sentence to me. You say \u0027the controller will have all the devices available, too\u0027, but what does it mean for a controller to \u0027have\u0027 a device? And what is the \u0027too\u0027 in reference to?","commit_id":"f4ebe6df38a0a98529282b0f8d43809e1506e854"},{"author":{"_account_id":14339,"name":"Philipp Marek","email":"philipp.marek@linbit.com","username":"pmarek"},"change_message_id":"656bf152097eacc7f8ec34382f63ab3263c8e195","unresolved":false,"context_lines":[{"line_number":60,"context_line":"                help\u003d\u0027\u0027\u0027If set, the controller will have all the"},{"line_number":61,"context_line":"                devices available, too, even if the controller node"},{"line_number":62,"context_line":"                doesn\u0027t have a local copy (ie. only other DRBD"},{"line_number":63,"context_line":"                storage have the data).\u0027\u0027\u0027),"},{"line_number":64,"context_line":"    # TODO(PM): offsite_redundancy?"},{"line_number":65,"context_line":"    # TODO(PM): choose DRBDmanage storage pool?"},{"line_number":66,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_723dc8c2","line":63,"in_reply_to":"9a1a9d01_0508da26","updated":"2015-10-01 07:59:15.000000000","message":"New wording try...","commit_id":"f4ebe6df38a0a98529282b0f8d43809e1506e854"}]}