)]}'
{"cinder/volume/drivers/zfssa/zfssaiscsi.py":[{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"bf8e8f078b2e9f816fa7d3b839aab84c77d33135","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                       \u0027src_vref\u0027: src_vref[\u0027name\u0027]})"},{"line_number":462,"context_line":"            # Cleanup snapshot"},{"line_number":463,"context_line":"            self.delete_snapshot(zfssa_snapshot)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    @utils.synchronized(\u0027zfssaiscsi\u0027, external\u003dTrue)"},{"line_number":466,"context_line":"    def clone_image(self, context, volume,"},{"line_number":467,"context_line":"                    image_location, image_meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_5df8c3e5","line":464,"updated":"2015-11-04 00:56:53.000000000","message":"If the race conditions only exist between the same volume or image you could add the vol-id to the lock like we do with other locked-vol-operations","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"ed0212dcf572dc8508386e9d24ed1c49dd620bd6","unresolved":false,"context_lines":[{"line_number":461,"context_line":"                       \u0027src_vref\u0027: src_vref[\u0027name\u0027]})"},{"line_number":462,"context_line":"            # Cleanup snapshot"},{"line_number":463,"context_line":"            self.delete_snapshot(zfssa_snapshot)"},{"line_number":464,"context_line":""},{"line_number":465,"context_line":"    @utils.synchronized(\u0027zfssaiscsi\u0027, external\u003dTrue)"},{"line_number":466,"context_line":"    def clone_image(self, context, volume,"},{"line_number":467,"context_line":"                    image_location, image_meta,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_6d8ff9cc","line":464,"in_reply_to":"fa80f949_5df8c3e5","updated":"2015-11-04 16:25:11.000000000","message":"Thanks for the suggestion, however the race conditions don\u0027t exist only calls to the same volume/image. It\u0027s (b) in the explanation.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"bf8e8f078b2e9f816fa7d3b839aab84c77d33135","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        \"\"\""},{"line_number":490,"context_line":"        LOG.debug(\u0027Cloning image %(image)s to volume %(volume)s\u0027,"},{"line_number":491,"context_line":"                  {\u0027image\u0027: image_meta[\u0027id\u0027], \u0027volume\u0027: volume[\u0027name\u0027]})"},{"line_number":492,"context_line":"        lcfg \u003d self.configuration"},{"line_number":493,"context_line":"        cachevol_size \u003d 0"},{"line_number":494,"context_line":"        if not lcfg.zfssa_enable_local_cache:"},{"line_number":495,"context_line":"            return None, False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_fd3ad7cc","line":492,"updated":"2015-11-04 00:56:53.000000000","message":"Is there a reason we need to set this to 0 if we\u0027re still setting it on line 502?","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"ed0212dcf572dc8508386e9d24ed1c49dd620bd6","unresolved":false,"context_lines":[{"line_number":489,"context_line":"        \"\"\""},{"line_number":490,"context_line":"        LOG.debug(\u0027Cloning image %(image)s to volume %(volume)s\u0027,"},{"line_number":491,"context_line":"                  {\u0027image\u0027: image_meta[\u0027id\u0027], \u0027volume\u0027: volume[\u0027name\u0027]})"},{"line_number":492,"context_line":"        lcfg \u003d self.configuration"},{"line_number":493,"context_line":"        cachevol_size \u003d 0"},{"line_number":494,"context_line":"        if not lcfg.zfssa_enable_local_cache:"},{"line_number":495,"context_line":"            return None, False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_302aa87f","line":492,"in_reply_to":"fa80f949_fd3ad7cc","updated":"2015-11-04 16:25:11.000000000","message":"I\u0027m trying to be safe here, so that for some reason line 502 can\u0027t be reached, the driver does not throw an unrelated error (cachevol_size is not defined).","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"96061f5fa9f1c8d5af9c4ec8cb71f0ed93cf115e","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (not cache_vol.get(\u0027updated_at\u0027, None) or"},{"line_number":571,"context_line":"                    not cache_vol.get(\u0027image_id\u0027, None)):"},{"line_number":572,"context_line":"                exc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027"},{"line_number":573,"context_line":"                             \u0027properties\u0027), cachevol_name)"},{"line_number":574,"context_line":"                LOG.error(exc_msg)"},{"line_number":575,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexc_msg)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_9de663af","line":573,"updated":"2015-10-01 13:16:35.000000000","message":"\".\" at EOL","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ef01593ae59ae978b62d60e4dc0102fd09145bc9","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (not cache_vol.get(\u0027updated_at\u0027, None) or"},{"line_number":571,"context_line":"                    not cache_vol.get(\u0027image_id\u0027, None)):"},{"line_number":572,"context_line":"                exc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027"},{"line_number":573,"context_line":"                             \u0027properties\u0027), cachevol_name)"},{"line_number":574,"context_line":"                LOG.error(exc_msg)"},{"line_number":575,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexc_msg)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_74aedd86","line":573,"in_reply_to":"5a2ca52d_61e766ac","updated":"2015-11-04 19:27:18.000000000","message":"In such case, exc_msg will be tuple, not string","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"622c14e559458ee44737fcce20a0e564f6283831","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (not cache_vol.get(\u0027updated_at\u0027, None) or"},{"line_number":571,"context_line":"                    not cache_vol.get(\u0027image_id\u0027, None)):"},{"line_number":572,"context_line":"                exc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027"},{"line_number":573,"context_line":"                             \u0027properties\u0027), cachevol_name)"},{"line_number":574,"context_line":"                LOG.error(exc_msg)"},{"line_number":575,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexc_msg)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_f6001e04","line":573,"in_reply_to":"5a2ca52d_76008e66","updated":"2015-10-16 19:42:11.000000000","message":"I don\u0027t think it\u0027s the right format. \u0027run_tests.sh -p\u0027 complains that it\u0027s over-indented.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"9df9b39c7ba7640e70b6b2d4e950fe3d8643ecba","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (not cache_vol.get(\u0027updated_at\u0027, None) or"},{"line_number":571,"context_line":"                    not cache_vol.get(\u0027image_id\u0027, None)):"},{"line_number":572,"context_line":"                exc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027"},{"line_number":573,"context_line":"                             \u0027properties\u0027), cachevol_name)"},{"line_number":574,"context_line":"                LOG.error(exc_msg)"},{"line_number":575,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexc_msg)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_61e766ac","line":573,"in_reply_to":"5a2ca52d_81288234","updated":"2015-10-16 20:03:34.000000000","message":"Thanks Kedar for pointing out, but I don\u0027t think it\u0027s mandatory per the internationalization guideline.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13059,"name":"Kedar Vidvans","email":"kedar.vidvans@oracle.com","username":"kedar-vidvans"},"change_message_id":"aa464ec31eab4bc954b380933bfdacfab95ee2a0","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (not cache_vol.get(\u0027updated_at\u0027, None) or"},{"line_number":571,"context_line":"                    not cache_vol.get(\u0027image_id\u0027, None)):"},{"line_number":572,"context_line":"                exc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027"},{"line_number":573,"context_line":"                             \u0027properties\u0027), cachevol_name)"},{"line_number":574,"context_line":"                LOG.error(exc_msg)"},{"line_number":575,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexc_msg)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_81288234","line":573,"in_reply_to":"5a2ca52d_f6001e04","updated":"2015-10-16 19:52:20.000000000","message":"Diem, I think Ivan is asking to use % instead of , while passing variables to string.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5f97d0531566b4a958b5de1d0f0c0727d0ac0c6f","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (not cache_vol.get(\u0027updated_at\u0027, None) or"},{"line_number":571,"context_line":"                    not cache_vol.get(\u0027image_id\u0027, None)):"},{"line_number":572,"context_line":"                exc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027"},{"line_number":573,"context_line":"                             \u0027properties\u0027), cachevol_name)"},{"line_number":574,"context_line":"                LOG.error(exc_msg)"},{"line_number":575,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexc_msg)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_76008e66","line":573,"in_reply_to":"7a2fa921_bd2691b8","updated":"2015-10-16 19:29:45.000000000","message":"Should be \nexc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027\n                             \u0027properties\u0027) % cachevol_name)","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"69b0f5c2e9de289b1a40b261a5e40298bec51a60","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (not cache_vol.get(\u0027updated_at\u0027, None) or"},{"line_number":571,"context_line":"                    not cache_vol.get(\u0027image_id\u0027, None)):"},{"line_number":572,"context_line":"                exc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027"},{"line_number":573,"context_line":"                             \u0027properties\u0027), cachevol_name)"},{"line_number":574,"context_line":"                LOG.error(exc_msg)"},{"line_number":575,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexc_msg)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_bd2691b8","line":573,"in_reply_to":"9a1a9d01_9de663af","updated":"2015-10-06 15:25:18.000000000","message":"I don\u0027t think this is required by the guideline.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"14a0a580201875305ad88ebb87cc806a197a1845","unresolved":false,"context_lines":[{"line_number":570,"context_line":"            if (not cache_vol.get(\u0027updated_at\u0027, None) or"},{"line_number":571,"context_line":"                    not cache_vol.get(\u0027image_id\u0027, None)):"},{"line_number":572,"context_line":"                exc_msg \u003d (_(\u0027Cache volume %s does not have required \u0027"},{"line_number":573,"context_line":"                             \u0027properties\u0027), cachevol_name)"},{"line_number":574,"context_line":"                LOG.error(exc_msg)"},{"line_number":575,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexc_msg)"},{"line_number":576,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_879b1172","line":573,"in_reply_to":"fa80f949_74aedd86","updated":"2015-11-04 19:54:26.000000000","message":"Thanks Ivan, I get what you mean, will change to %.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"7804f4deb48c008af06cfee92a0e2daf0ca5e093","unresolved":false,"context_lines":[{"line_number":966,"context_line":"                self.zfssa.delete_lun(lcfg.zfssa_pool,"},{"line_number":967,"context_line":"                                      lcfg.zfssa_cache_project,"},{"line_number":968,"context_line":"                                      cache[\u0027share\u0027])"},{"line_number":969,"context_line":"            except exception.VolumeBackendAPIException:"},{"line_number":970,"context_line":"                pass"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_22c88ca5","line":969,"updated":"2015-10-16 21:15:42.000000000","message":"Why not logging this failure at least?","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"ad8a810a6d5eb1667db9880c0d495e7f4418621d","unresolved":false,"context_lines":[{"line_number":966,"context_line":"                self.zfssa.delete_lun(lcfg.zfssa_pool,"},{"line_number":967,"context_line":"                                      lcfg.zfssa_cache_project,"},{"line_number":968,"context_line":"                                      cache[\u0027share\u0027])"},{"line_number":969,"context_line":"            except exception.VolumeBackendAPIException:"},{"line_number":970,"context_line":"                pass"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_24a82c1f","line":969,"in_reply_to":"5a2ca52d_22c88ca5","updated":"2015-10-19 16:14:50.000000000","message":"The function zfssa.delete_lun already logs the exception before raising it. So logging the failure here is just a repeat.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ed6d508a6c632b5a1071512824e33f7d09ce4f36","unresolved":false,"context_lines":[{"line_number":966,"context_line":"                self.zfssa.delete_lun(lcfg.zfssa_pool,"},{"line_number":967,"context_line":"                                      lcfg.zfssa_cache_project,"},{"line_number":968,"context_line":"                                      cache[\u0027share\u0027])"},{"line_number":969,"context_line":"            except exception.VolumeBackendAPIException:"},{"line_number":970,"context_line":"                pass"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_ccefc0e7","line":969,"updated":"2015-11-06 05:17:03.000000000","message":"If this fails due to reasons other than the lun doesn\u0027t exist, you should at least log a warning.","commit_id":"94138e4245e6356cd828dd97c1f367165c29118b"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2b13ccbbe9df8751178439c0dc2099c9a2a611cf","unresolved":false,"context_lines":[{"line_number":966,"context_line":"                self.zfssa.delete_lun(lcfg.zfssa_pool,"},{"line_number":967,"context_line":"                                      lcfg.zfssa_cache_project,"},{"line_number":968,"context_line":"                                      cache[\u0027share\u0027])"},{"line_number":969,"context_line":"            except exception.VolumeBackendAPIException:"},{"line_number":970,"context_line":"                pass"},{"line_number":971,"context_line":""},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_f283c1ca","line":969,"in_reply_to":"fa80f949_ccefc0e7","updated":"2015-11-09 19:58:25.000000000","message":"Done","commit_id":"94138e4245e6356cd828dd97c1f367165c29118b"}],"cinder/volume/drivers/zfssa/zfssanfs.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5f97d0531566b4a958b5de1d0f0c0727d0ac0c6f","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        \"\"\""},{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            cachevol_props \u003d self.zfssa.get_volume(origin)"},{"line_number":501,"context_line":"        except Exception:"},{"line_number":502,"context_line":"            LOG.debug(\u0027Origin %s does not exist\u0027, origin)"},{"line_number":503,"context_line":"            return"},{"line_number":504,"context_line":"        numclones \u003d cachevol_props[\u0027numclones\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_f6ec9ebc","line":501,"updated":"2015-10-16 19:29:45.000000000","message":"Could we handle more specific exception here?","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"622c14e559458ee44737fcce20a0e564f6283831","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        \"\"\""},{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            cachevol_props \u003d self.zfssa.get_volume(origin)"},{"line_number":501,"context_line":"        except Exception:"},{"line_number":502,"context_line":"            LOG.debug(\u0027Origin %s does not exist\u0027, origin)"},{"line_number":503,"context_line":"            return"},{"line_number":504,"context_line":"        numclones \u003d cachevol_props[\u0027numclones\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_e16136d4","line":501,"in_reply_to":"5a2ca52d_f6ec9ebc","updated":"2015-10-16 19:42:11.000000000","message":"It\u0027s intended to be generic, so that any exception caught will be handled, and the function returns.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"96061f5fa9f1c8d5af9c4ec8cb71f0ed93cf115e","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            cachevol_props \u003d self.zfssa.get_volume(origin)"},{"line_number":501,"context_line":"        except Exception:"},{"line_number":502,"context_line":"            LOG.debug(\u0027Origin %s does not exist\u0027, origin)"},{"line_number":503,"context_line":"            return"},{"line_number":504,"context_line":"        numclones \u003d cachevol_props[\u0027numclones\u0027]"},{"line_number":505,"context_line":"        LOG.debug(\u0027Number of clones: %d\u0027, numclones)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a1a9d01_1da9f324","line":502,"updated":"2015-10-01 13:16:35.000000000","message":"\".\" at EOL","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"69b0f5c2e9de289b1a40b261a5e40298bec51a60","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            cachevol_props \u003d self.zfssa.get_volume(origin)"},{"line_number":501,"context_line":"        except Exception:"},{"line_number":502,"context_line":"            LOG.debug(\u0027Origin %s does not exist\u0027, origin)"},{"line_number":503,"context_line":"            return"},{"line_number":504,"context_line":"        numclones \u003d cachevol_props[\u0027numclones\u0027]"},{"line_number":505,"context_line":"        LOG.debug(\u0027Number of clones: %d\u0027, numclones)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_7d20f99b","line":502,"in_reply_to":"9a1a9d01_1da9f324","updated":"2015-10-06 15:25:18.000000000","message":"I don\u0027t think this is required by the guideline.","commit_id":"34ca40ca67ea0b123a97935d8663dd9bdb467eb7"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ed6d508a6c632b5a1071512824e33f7d09ce4f36","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        \"\"\""},{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            cachevol_props \u003d self.zfssa.get_volume(origin)"},{"line_number":501,"context_line":"        except Exception:"},{"line_number":502,"context_line":"            LOG.debug(\u0027Origin %s does not exist\u0027, origin)"},{"line_number":503,"context_line":"            return"},{"line_number":504,"context_line":"        numclones \u003d cachevol_props[\u0027numclones\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_8cd5381d","line":501,"updated":"2015-11-06 05:17:03.000000000","message":"This exception could mean the volume doesn\u0027t exist or something else.  It should be ignored only if it doesn\u0027t exist.  If it failed for other reasons, it should raise an exception.","commit_id":"94138e4245e6356cd828dd97c1f367165c29118b"},{"author":{"_account_id":13524,"name":"Diem Tran","email":"diem.tran@oracle.com","username":"dttran"},"change_message_id":"2b13ccbbe9df8751178439c0dc2099c9a2a611cf","unresolved":false,"context_lines":[{"line_number":498,"context_line":"        \"\"\""},{"line_number":499,"context_line":"        try:"},{"line_number":500,"context_line":"            cachevol_props \u003d self.zfssa.get_volume(origin)"},{"line_number":501,"context_line":"        except Exception:"},{"line_number":502,"context_line":"            LOG.debug(\u0027Origin %s does not exist\u0027, origin)"},{"line_number":503,"context_line":"            return"},{"line_number":504,"context_line":"        numclones \u003d cachevol_props[\u0027numclones\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_52cbad1e","line":501,"in_reply_to":"fa80f949_8cd5381d","updated":"2015-11-09 19:58:25.000000000","message":"zfssa.get_volume raises only exception.VolumeNotFound. I\u0027ve changed the code to log that error. Other exceptions are purposefully not handled, so that they can be caught further at Cinder level.","commit_id":"94138e4245e6356cd828dd97c1f367165c29118b"}]}