)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"408fe8ad2a12987025fab196bdd9a6a7124c3e47","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Setup error check \u0026 minor bug fix in CloudByte"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently in CloudByte Cinder driver there is now way of checking"},{"line_number":10,"context_line":"the \"absence\" or \"validity\" of configuration parameters, which are"},{"line_number":11,"context_line":"configured by clients during DevStack setup against CloudByte"},{"line_number":12,"context_line":"Storage in \"cinder.conf\". In this case the cinder-volume service"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_f470d1de","line":9,"updated":"2015-10-01 18:45:25.000000000","message":"...there is no way...","commit_id":"6feefe70ce4b9f0c01543fc71c944addf4ab6eb1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9dacb94186855167db76b73dd17a804e114eb21b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Setup error check \u0026 minor bug fix in CloudByte"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently in CloudByte Cinder driver there is now way of checking"},{"line_number":10,"context_line":"the \"absence\" or \"validity\" of configuration parameters, which are"},{"line_number":11,"context_line":"configured by clients during DevStack setup against CloudByte"},{"line_number":12,"context_line":"Storage in \"cinder.conf\". In this case the cinder-volume service"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a1a9d01_295d8fec","line":9,"updated":"2015-10-01 18:09:33.000000000","message":"typo now -\u003e no","commit_id":"6feefe70ce4b9f0c01543fc71c944addf4ab6eb1"}],"cinder/volume/drivers/cloudbyte/cloudbyte.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9dacb94186855167db76b73dd17a804e114eb21b","unresolved":false,"context_lines":[{"line_number":135,"context_line":""},{"line_number":136,"context_line":"        if empty_params:"},{"line_number":137,"context_line":"            msg \u003d (_("},{"line_number":138,"context_line":"                \"Cinder configuration parameter [%s] either not set\""},{"line_number":139,"context_line":"                \" or has empty values w.r.t CloudByte Storage.\") %"},{"line_number":140,"context_line":"                \u0027, \u0027.join(empty_params))"},{"line_number":141,"context_line":"            raise exception.InvalidInput(data\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_125b1030","line":138,"updated":"2015-10-01 18:09:33.000000000","message":"I think this should be \u0027parameter(s)\u0027 so that it is clear that the output may represent more than one configuration item.  Otherwise the resulting message could be quite confusing.","commit_id":"6feefe70ce4b9f0c01543fc71c944addf4ab6eb1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"9dacb94186855167db76b73dd17a804e114eb21b","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if invalid_params:"},{"line_number":166,"context_line":"            raise exception.InvalidInput("},{"line_number":167,"context_line":"                reason\u003d(\"Cinder configuration has invalid values\""},{"line_number":168,"context_line":"                        \" [%s] w.r.t CloudByte Storage.\") %"},{"line_number":169,"context_line":"                \u0027, \u0027.join(invalid_params))"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_925e4011","line":167,"updated":"2015-10-01 18:09:33.000000000","message":"Same comment here suggest \u0027value(s)\u0027 .","commit_id":"6feefe70ce4b9f0c01543fc71c944addf4ab6eb1"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"408fe8ad2a12987025fab196bdd9a6a7124c3e47","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if invalid_params:"},{"line_number":166,"context_line":"            raise exception.InvalidInput("},{"line_number":167,"context_line":"                reason\u003d(\"Cinder configuration has invalid values\""},{"line_number":168,"context_line":"                        \" [%s] w.r.t CloudByte Storage.\") %"},{"line_number":169,"context_line":"                \u0027, \u0027.join(invalid_params))"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_1d032178","line":167,"updated":"2015-10-01 18:45:25.000000000","message":"_()","commit_id":"6feefe70ce4b9f0c01543fc71c944addf4ab6eb1"},{"author":{"_account_id":14059,"name":"Abhishek Shrivastava","email":"abhishek@cloudbyte.com","username":"Abhishek01"},"change_message_id":"45f8d1569290c10b8d972a88ffeb1af8d100464b","unresolved":false,"context_lines":[{"line_number":164,"context_line":""},{"line_number":165,"context_line":"        if invalid_params:"},{"line_number":166,"context_line":"            raise exception.InvalidInput("},{"line_number":167,"context_line":"                reason\u003d(\"Cinder configuration has invalid values\""},{"line_number":168,"context_line":"                        \" [%s] w.r.t CloudByte Storage.\") %"},{"line_number":169,"context_line":"                \u0027, \u0027.join(invalid_params))"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a1a9d01_5da99923","line":167,"in_reply_to":"9a1a9d01_1d032178","updated":"2015-10-01 18:53:02.000000000","message":"I am sorry for all these issues but since the machine I used to do this commit has been destroyed so please accept my request and kindly review the duplicate of this patch https://review.openstack.org/#/c/230068","commit_id":"6feefe70ce4b9f0c01543fc71c944addf4ab6eb1"}]}