)]}'
{"cinder/tests/unit/test_backup_swift.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"07d72ab3090d4841e2dbe32b271315ea2f4043b4","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        container_name \u003d self.temp_dir.replace(tempfile.gettempdir() + \u0027/\u0027,"},{"line_number":268,"context_line":"                                               \u0027\u0027, 1)"},{"line_number":269,"context_line":"        self._create_backup_db_entry(volume_id\u003d\u00271234-5678-0001-0006\u0027,"},{"line_number":270,"context_line":"                                     container\u003dcontainer_name,"},{"line_number":271,"context_line":"                                     backup_id\u003d123)"},{"line_number":272,"context_line":"        self.stubs.Set(swift, \u0027Connection\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_244b3e89","line":269,"updated":"2015-10-06 19:19:44.000000000","message":"Shouldn\u0027t the last char in this volume_id be \u00278\u0027 (and increment the following volume_ids accordingly)?\n\n\u00271234-5678-0001-0006\u0027 was already used at line 212 and \u00271234-5678-0001-0007\u0027 at line 237.","commit_id":"72ffe11671044f4b04b69390641b588d8356c385"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f247ea5f2e6d1ddcfcac95d62b6e5fd503763ebc","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"        container_name \u003d self.temp_dir.replace(tempfile.gettempdir() + \u0027/\u0027,"},{"line_number":268,"context_line":"                                               \u0027\u0027, 1)"},{"line_number":269,"context_line":"        self._create_backup_db_entry(volume_id\u003d\u00271234-5678-0001-0006\u0027,"},{"line_number":270,"context_line":"                                     container\u003dcontainer_name,"},{"line_number":271,"context_line":"                                     backup_id\u003d123)"},{"line_number":272,"context_line":"        self.stubs.Set(swift, \u0027Connection\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_875ed410","line":269,"in_reply_to":"7a2fa921_244b3e89","updated":"2015-10-06 19:22:07.000000000","message":"Yeah, probably so. :)","commit_id":"72ffe11671044f4b04b69390641b588d8356c385"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e768513b2f8c3a49058b034a7bb3aa387c257b2c","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        self.assertEqual(container_name, backup[\u0027container\u0027])"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        # Create incremental backup with no change to contents"},{"line_number":282,"context_line":"        self._create_backup_db_entry(volume_id\u003d\u00271234-5678-0001-0007\u0027,"},{"line_number":283,"context_line":"                                     container\u003dcontainer_name,"},{"line_number":284,"context_line":"                                     backup_id\u003d124,"},{"line_number":285,"context_line":"                                     parent_id\u003d123)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_4793dc4f","line":282,"updated":"2015-10-06 19:33:29.000000000","message":"Also, this should use the same volume id as the entry above.","commit_id":"72ffe11671044f4b04b69390641b588d8356c385"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"05b6d522ab0d4a6c6324bbe585a61af724882e8b","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        self.assertEqual(container_name, backup[\u0027container\u0027])"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":"        # Create incremental backup with no change to contents"},{"line_number":282,"context_line":"        self._create_backup_db_entry(volume_id\u003d\u00271234-5678-0001-0007\u0027,"},{"line_number":283,"context_line":"                                     container\u003dcontainer_name,"},{"line_number":284,"context_line":"                                     backup_id\u003d124,"},{"line_number":285,"context_line":"                                     parent_id\u003d123)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_674a98c7","line":282,"in_reply_to":"7a2fa921_4793dc4f","updated":"2015-10-06 19:37:16.000000000","message":"agreed.","commit_id":"72ffe11671044f4b04b69390641b588d8356c385"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f00f8b9cde6c27145fa68834b41c58827d074e14","unresolved":false,"context_lines":[{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        container_name \u003d self.temp_dir.replace(tempfile.gettempdir() + \u0027/\u0027,"},{"line_number":380,"context_line":"                                               \u0027\u0027, 1)"},{"line_number":381,"context_line":"        self._create_backup_db_entry(volume_id\u003d\u00271234-5678-0001-0011\u0027,"},{"line_number":382,"context_line":"                                     container\u003dcontainer_name,"},{"line_number":383,"context_line":"                                     backup_id\u003d123)"},{"line_number":384,"context_line":"        self.stubs.Set(swift, \u0027Connection\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_b296b04a","line":381,"updated":"2015-10-06 20:11:21.000000000","message":"Is there a reason you skipped \u00271234-5678-0001-0010\u0027 ?   It doesn\u0027t matter for correctness, but perhaps raises unnecessary questions for humans reading the code.","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3889c152a6b0d7c15f62182f7a335d7b77aa055e","unresolved":false,"context_lines":[{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        container_name \u003d self.temp_dir.replace(tempfile.gettempdir() + \u0027/\u0027,"},{"line_number":380,"context_line":"                                               \u0027\u0027, 1)"},{"line_number":381,"context_line":"        self._create_backup_db_entry(volume_id\u003d\u00271234-5678-0001-0011\u0027,"},{"line_number":382,"context_line":"                                     container\u003dcontainer_name,"},{"line_number":383,"context_line":"                                     backup_id\u003d123)"},{"line_number":384,"context_line":"        self.stubs.Set(swift, \u0027Connection\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_384e0170","line":381,"in_reply_to":"7a2fa921_b296b04a","updated":"2015-10-06 20:32:33.000000000","message":"Not really.  These shouldn\u0027t be interpreted as meaning anything sequentially anyway, and I don\u0027t want to encourage people working on tests to try to follow a pattern.  They probably should just be random UUIDs, which is what is usually used in tests like this.","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f00f8b9cde6c27145fa68834b41c58827d074e14","unresolved":false,"context_lines":[{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        with tempfile.NamedTemporaryFile() as volume_file:"},{"line_number":490,"context_line":"            backup \u003d objects.Backup.get_by_id(self.ctxt, 123)"},{"line_number":491,"context_line":"            service.restore(backup, \u00271234-5678-1234-8888\u0027, volume_file)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_restore_delta(self):"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_eddd2943","line":491,"updated":"2015-10-06 20:11:21.000000000","message":"Would it make sense to use \u00271234-5678-0001-0015\u0027 here, the way you use matching volume_ids in the _create_backup_db_entry() and service.restore() at line 539?","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"836709bd5b9c4c966d9281bfe3867c08553a50b5","unresolved":false,"context_lines":[{"line_number":488,"context_line":""},{"line_number":489,"context_line":"        with tempfile.NamedTemporaryFile() as volume_file:"},{"line_number":490,"context_line":"            backup \u003d objects.Backup.get_by_id(self.ctxt, 123)"},{"line_number":491,"context_line":"            service.restore(backup, \u00271234-5678-1234-8888\u0027, volume_file)"},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"    def test_restore_delta(self):"},{"line_number":494,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_e5ac5d37","line":491,"in_reply_to":"7a2fa921_eddd2943","updated":"2015-10-06 21:44:46.000000000","message":"Done","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f00f8b9cde6c27145fa68834b41c58827d074e14","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            backup \u003d objects.Backup.get_by_id(self.ctxt, 123)"},{"line_number":552,"context_line":"            self.assertRaises(exception.SwiftConnectionFailed,"},{"line_number":553,"context_line":"                              service.restore,"},{"line_number":554,"context_line":"                              backup, \u00271234-5678-1234-8888\u0027, volume_file)"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def test_restore_unsupported_version(self):"},{"line_number":557,"context_line":"        container_name \u003d \u0027unsupported_version\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_f212e861","line":554,"updated":"2015-10-06 20:11:21.000000000","message":"Might as well make this \u00271234-5678-0001-0017\u0027 ?  Though it may raise before any","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"836709bd5b9c4c966d9281bfe3867c08553a50b5","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            backup \u003d objects.Backup.get_by_id(self.ctxt, 123)"},{"line_number":552,"context_line":"            self.assertRaises(exception.SwiftConnectionFailed,"},{"line_number":553,"context_line":"                              service.restore,"},{"line_number":554,"context_line":"                              backup, \u00271234-5678-1234-8888\u0027, volume_file)"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def test_restore_unsupported_version(self):"},{"line_number":557,"context_line":"        container_name \u003d \u0027unsupported_version\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_6567ed25","line":554,"in_reply_to":"7a2fa921_784c7970","updated":"2015-10-06 21:44:46.000000000","message":"Done","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3889c152a6b0d7c15f62182f7a335d7b77aa055e","unresolved":false,"context_lines":[{"line_number":551,"context_line":"            backup \u003d objects.Backup.get_by_id(self.ctxt, 123)"},{"line_number":552,"context_line":"            self.assertRaises(exception.SwiftConnectionFailed,"},{"line_number":553,"context_line":"                              service.restore,"},{"line_number":554,"context_line":"                              backup, \u00271234-5678-1234-8888\u0027, volume_file)"},{"line_number":555,"context_line":""},{"line_number":556,"context_line":"    def test_restore_unsupported_version(self):"},{"line_number":557,"context_line":"        container_name \u003d \u0027unsupported_version\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_784c7970","line":554,"in_reply_to":"7a2fa921_f212e861","updated":"2015-10-06 20:32:33.000000000","message":"I guess these error out before hitting that, but, I agree.","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f00f8b9cde6c27145fa68834b41c58827d074e14","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            backup \u003d objects.Backup.get_by_id(self.ctxt, 123)"},{"line_number":564,"context_line":"            self.assertRaises(exception.InvalidBackup,"},{"line_number":565,"context_line":"                              service.restore,"},{"line_number":566,"context_line":"                              backup, \u00271234-5678-1234-8888\u0027, volume_file)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def test_delete(self):"},{"line_number":569,"context_line":"        object_prefix \u003d \u0027test_prefix\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_6d911999","line":566,"updated":"2015-10-06 20:11:21.000000000","message":"\u00271234-5678-0001-0018\u0027 ?","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"836709bd5b9c4c966d9281bfe3867c08553a50b5","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            backup \u003d objects.Backup.get_by_id(self.ctxt, 123)"},{"line_number":564,"context_line":"            self.assertRaises(exception.InvalidBackup,"},{"line_number":565,"context_line":"                              service.restore,"},{"line_number":566,"context_line":"                              backup, \u00271234-5678-1234-8888\u0027, volume_file)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def test_delete(self):"},{"line_number":569,"context_line":"        object_prefix \u003d \u0027test_prefix\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_2571f5e0","line":566,"in_reply_to":"7a2fa921_3875a197","updated":"2015-10-06 21:44:46.000000000","message":"Done","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3889c152a6b0d7c15f62182f7a335d7b77aa055e","unresolved":false,"context_lines":[{"line_number":563,"context_line":"            backup \u003d objects.Backup.get_by_id(self.ctxt, 123)"},{"line_number":564,"context_line":"            self.assertRaises(exception.InvalidBackup,"},{"line_number":565,"context_line":"                              service.restore,"},{"line_number":566,"context_line":"                              backup, \u00271234-5678-1234-8888\u0027, volume_file)"},{"line_number":567,"context_line":""},{"line_number":568,"context_line":"    def test_delete(self):"},{"line_number":569,"context_line":"        object_prefix \u003d \u0027test_prefix\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_3875a197","line":566,"in_reply_to":"7a2fa921_6d911999","updated":"2015-10-06 20:32:33.000000000","message":"Ditto","commit_id":"aed26f5e927ff505aedf98a0df5d23559c90b8c5"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"f3f22b900c90d2d6b3987c40c38ba432526d24b8","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                          swift_dr.SwiftBackupDriver,"},{"line_number":135,"context_line":"                          self.ctxt)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_backup_uncompressed(self):"},{"line_number":138,"context_line":"        volume_id \u003d \u00272b9f10a3-42b4-4fdf-b316-000000ceb039\u0027"},{"line_number":139,"context_line":"        self._create_backup_db_entry(volume_id\u003dvolume_id)"},{"line_number":140,"context_line":"        self.flags(backup_compression_algorithm\u003d\u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_88e6e0b2","line":137,"updated":"2015-10-06 22:15:03.000000000","message":"Not sure if there\u0027s enforcement on what the volume_id\u0027s can look like, but if you\u0027re going to be using the id\u0027s to see what test they came from you could always set the volume_id to the testname (e.g. \"volume_id \u003d \u0027test-back-uncompressed\u0027\" to make it easier to debug","commit_id":"284eb741995e76ff18e4a1ef8a1a3ce99a9afcfd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f851ad52dd1704764ac2cfc79476cd8a7b5f56cc","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                          swift_dr.SwiftBackupDriver,"},{"line_number":135,"context_line":"                          self.ctxt)"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    def test_backup_uncompressed(self):"},{"line_number":138,"context_line":"        volume_id \u003d \u00272b9f10a3-42b4-4fdf-b316-000000ceb039\u0027"},{"line_number":139,"context_line":"        self._create_backup_db_entry(volume_id\u003dvolume_id)"},{"line_number":140,"context_line":"        self.flags(backup_compression_algorithm\u003d\u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_bb96884a","line":137,"in_reply_to":"7a2fa921_88e6e0b2","updated":"2015-10-06 22:37:41.000000000","message":"There doesn\u0027t seem to be (though I\u0027m not sure that\u0027s a good thing).\n\nThe main benefit of using UUIDs is that it\u0027s possible to write specific elastic recheck queries more easily against them, since backup drivers likely share some test names.  Your suggestion probably mostly works for that, but there\u0027s good precedent for just using UUIDs in Tempest.\n\nI put \"000000\" in all of them so it shouldn\u0027t be too hard to grep for them when looking at failures as well.","commit_id":"284eb741995e76ff18e4a1ef8a1a3ce99a9afcfd"}]}