)]}'
{"cinder/tests/test_hp3par.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"79b45684fb4c8a43e959e1201eb707117912a2f5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from hp3parclient import exceptions as hpexceptions"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from cinder import exception"},{"line_number":28,"context_line":"import cinder.flags"},{"line_number":29,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":30,"context_line":"from cinder import test"},{"line_number":31,"context_line":"from cinder.volume import configuration as conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BWM%3D","line":28,"updated":"2013-02-28 22:02:39.000000000","message":"remove import as this should not be used","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"20ec3a213d8992a4977e452d4e6f7908b26b41b6","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from hp3parclient import exceptions as hpexceptions"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from cinder import exception"},{"line_number":28,"context_line":"import cinder.flags"},{"line_number":29,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":30,"context_line":"from cinder import test"},{"line_number":31,"context_line":"from cinder.volume import configuration as conf"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BJ0%3D","line":28,"in_reply_to":"AAAANH%2F%2F%2BWM%3D","updated":"2013-03-01 00:21:24.000000000","message":"Done","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"79b45684fb4c8a43e959e1201eb707117912a2f5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from cinder.volume.drivers.san.hp import hp_3par_fc as hpfcdriver"},{"line_number":33,"context_line":"from cinder.volume.drivers.san.hp import hp_3par_iscsi as hpdriver"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FLAGS \u003d cinder.flags.FLAGS"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BWY%3D","line":35,"updated":"2013-02-28 22:02:39.000000000","message":"FLAGS should not be used anymore","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"20ec3a213d8992a4977e452d4e6f7908b26b41b6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"from cinder.volume.drivers.san.hp import hp_3par_fc as hpfcdriver"},{"line_number":33,"context_line":"from cinder.volume.drivers.san.hp import hp_3par_iscsi as hpdriver"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"FLAGS \u003d cinder.flags.FLAGS"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BJw%3D","line":35,"in_reply_to":"AAAANH%2F%2F%2BWY%3D","updated":"2013-03-01 00:21:24.000000000","message":"Done","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"79b45684fb4c8a43e959e1201eb707117912a2f5","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"from cinder import context"},{"line_number":52,"context_line":"from cinder import exception"},{"line_number":53,"context_line":"from cinder import flags"},{"line_number":54,"context_line":"from cinder.openstack.common import lockutils"},{"line_number":55,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":56,"context_line":"from cinder import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BVc%3D","line":53,"updated":"2013-02-28 22:02:39.000000000","message":"Remove the flags import as this should no longer be needed","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"20ec3a213d8992a4977e452d4e6f7908b26b41b6","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"from cinder import context"},{"line_number":52,"context_line":"from cinder import exception"},{"line_number":53,"context_line":"from cinder import flags"},{"line_number":54,"context_line":"from cinder.openstack.common import lockutils"},{"line_number":55,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":56,"context_line":"from cinder import utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BJs%3D","line":53,"in_reply_to":"AAAANH%2F%2F%2BVc%3D","updated":"2013-03-01 00:21:24.000000000","message":"Done","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"79b45684fb4c8a43e959e1201eb707117912a2f5","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                default\u003dFalse,"},{"line_number":93,"context_line":"                help\u003d\"Enable HTTP debugging to 3PAR\")"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":97,"context_line":"FLAGS.register_opts(hp3par_opts)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BV0%3D","line":95,"updated":"2013-02-28 22:02:39.000000000","message":"remove","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"20ec3a213d8992a4977e452d4e6f7908b26b41b6","unresolved":false,"context_lines":[{"line_number":92,"context_line":"                default\u003dFalse,"},{"line_number":93,"context_line":"                help\u003d\"Enable HTTP debugging to 3PAR\")"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":97,"context_line":"FLAGS.register_opts(hp3par_opts)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BJo%3D","line":95,"in_reply_to":"AAAANH%2F%2F%2BV0%3D","updated":"2013-03-01 00:21:24.000000000","message":"Done","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"79b45684fb4c8a43e959e1201eb707117912a2f5","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                help\u003d\"Enable HTTP debugging to 3PAR\")"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":97,"context_line":"FLAGS.register_opts(hp3par_opts)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BVw%3D","line":96,"updated":"2013-02-28 22:02:39.000000000","message":"remove as FLAGS should not be used","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"20ec3a213d8992a4977e452d4e6f7908b26b41b6","unresolved":false,"context_lines":[{"line_number":93,"context_line":"                help\u003d\"Enable HTTP debugging to 3PAR\")"},{"line_number":94,"context_line":"]"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":97,"context_line":"FLAGS.register_opts(hp3par_opts)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BJk%3D","line":96,"in_reply_to":"AAAANH%2F%2F%2BVw%3D","updated":"2013-03-01 00:21:24.000000000","message":"Done","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"79b45684fb4c8a43e959e1201eb707117912a2f5","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.sshpool \u003d None"},{"line_number":124,"context_line":"        self.config \u003d config"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def check_flags(self, FLAGS, required_flags):"},{"line_number":127,"context_line":"        for flag in required_flags:"},{"line_number":128,"context_line":"            if not getattr(FLAGS, flag, None):"},{"line_number":129,"context_line":"                raise exception.InvalidInput(reason\u003d_(\u0027%s is not set\u0027) % flag)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BVk%3D","line":126,"updated":"2013-02-28 22:02:39.000000000","message":"should this be self.configuration instead of FLAGS since FLAGS isn\u0027t passed into the function","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"20ec3a213d8992a4977e452d4e6f7908b26b41b6","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.sshpool \u003d None"},{"line_number":124,"context_line":"        self.config \u003d config"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    def check_flags(self, FLAGS, required_flags):"},{"line_number":127,"context_line":"        for flag in required_flags:"},{"line_number":128,"context_line":"            if not getattr(FLAGS, flag, None):"},{"line_number":129,"context_line":"                raise exception.InvalidInput(reason\u003d_(\u0027%s is not set\u0027) % flag)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BJU%3D","line":126,"in_reply_to":"AAAANH%2F%2F%2BVk%3D","updated":"2013-03-01 00:21:24.000000000","message":"renamed to options.","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4a7c29bc39fe7c88bade6b7d98156b911e1b562e","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"        if snapshot[\u0027volume_size\u0027] !\u003d volume[\u0027size\u0027]:"},{"line_number":659,"context_line":"            err \u003d \"You cannot change size of the volume.  It must \""},{"line_number":660,"context_line":"            \"be the same as it\u0027s Snapshot.\""},{"line_number":661,"context_line":"            LOG.error(err)"},{"line_number":662,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANn%2F%2F%2F%2FE%3D","line":660,"updated":"2013-03-03 18:22:05.000000000","message":"This message reads like the snapshot\u0027s source is the volume, but it is actually the other way around.  It\u0027s better to change \"it\u0027s Snapshot\" to \"the Snapshot\".","commit_id":"ffa8aad2fc0a4ca90ebf4c91cb5b0fe3c9be0099"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"779be52b7ceda34ddaa89c4057f96bb051587082","unresolved":false,"context_lines":[{"line_number":657,"context_line":""},{"line_number":658,"context_line":"        if snapshot[\u0027volume_size\u0027] !\u003d volume[\u0027size\u0027]:"},{"line_number":659,"context_line":"            err \u003d \"You cannot change size of the volume.  It must \""},{"line_number":660,"context_line":"            \"be the same as it\u0027s Snapshot.\""},{"line_number":661,"context_line":"            LOG.error(err)"},{"line_number":662,"context_line":"            raise exception.InvalidInput(reason\u003derr)"},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F8eI%3D","line":660,"in_reply_to":"AAAANn%2F%2F%2F%2FE%3D","updated":"2013-03-05 17:09:17.000000000","message":"Done","commit_id":"ffa8aad2fc0a4ca90ebf4c91cb5b0fe3c9be0099"}],"cinder/volume/drivers/san/hp/hp_3par_fc.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"79b45684fb4c8a43e959e1201eb707117912a2f5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from oslo.config import cfg"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from cinder import exception"},{"line_number":38,"context_line":"from cinder import flags"},{"line_number":39,"context_line":"from cinder.openstack.common import lockutils"},{"line_number":40,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":41,"context_line":"import cinder.volume.driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BVg%3D","line":38,"updated":"2013-02-28 22:02:39.000000000","message":"remove import not used anymore","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"20ec3a213d8992a4977e452d4e6f7908b26b41b6","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from oslo.config import cfg"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from cinder import exception"},{"line_number":38,"context_line":"from cinder import flags"},{"line_number":39,"context_line":"from cinder.openstack.common import lockutils"},{"line_number":40,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":41,"context_line":"import cinder.volume.driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BI0%3D","line":38,"in_reply_to":"AAAANH%2F%2F%2BVg%3D","updated":"2013-03-01 00:21:24.000000000","message":"Done","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"}],"cinder/volume/drivers/san/hp/hp_3par_iscsi.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"79b45684fb4c8a43e959e1201eb707117912a2f5","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from hp3parclient import exceptions as hpexceptions"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from cinder import exception"},{"line_number":37,"context_line":"from cinder import flags"},{"line_number":38,"context_line":"from cinder.openstack.common import lockutils"},{"line_number":39,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":40,"context_line":"import cinder.volume.driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BVY%3D","line":37,"updated":"2013-02-28 22:02:39.000000000","message":"remove import as flags should not be used anymore","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"20ec3a213d8992a4977e452d4e6f7908b26b41b6","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from hp3parclient import exceptions as hpexceptions"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from cinder import exception"},{"line_number":37,"context_line":"from cinder import flags"},{"line_number":38,"context_line":"from cinder.openstack.common import lockutils"},{"line_number":39,"context_line":"from cinder.openstack.common import log as logging"},{"line_number":40,"context_line":"import cinder.volume.driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BIw%3D","line":37,"in_reply_to":"AAAANH%2F%2F%2BVY%3D","updated":"2013-03-01 00:21:24.000000000","message":"Done","commit_id":"c72454a9eb817422f671d6c7d029b899aa20d2db"}]}