)]}'
{"cinder/scheduler/filters/capacity_filter.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"4f50caecc546cf418fc9e84b70331bb5258da6f3","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        if host_state.free_capacity_gb is None:"},{"line_number":36,"context_line":"            # Fail Safe"},{"line_number":37,"context_line":"            LOG.error(_(\"Free capacity not set:\""},{"line_number":38,"context_line":"                        \"volume node info collection broken.\"))"},{"line_number":39,"context_line":"            return False"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2BXE%3D","line":37,"updated":"2013-02-28 21:49:35.000000000","message":"Did you want a space between the colon and the rest of the text message?","commit_id":"5e7268156f68730554c75147ac90ccced82b27d6"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"6a74a3b8ac3d136db368c4fe364ef89fbeb9f15e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"\"\"Return True if host has sufficient capacity.\"\"\""},{"line_number":33,"context_line":"        volume_size \u003d filter_properties.get(\u0027size\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        if host_state.free_capacity_gb is None:"},{"line_number":36,"context_line":"            # Fail Safe"},{"line_number":37,"context_line":"            LOG.error(_(\"Free capacity not set: \""},{"line_number":38,"context_line":"                        \"volume node info collection broken.\"))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F%2BBQ%3D","line":35,"updated":"2013-03-01 01:46:00.000000000","message":"This change here requires an additional change in scheduler/host_manager.py line 102 to set host_state.free_capacity_gb initial value to None.","commit_id":"0e6522f16fd7bb7e2f6be079c1ad44e433596a6c"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"8f618a5a3f517cd87334749977a0555b4602302e","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        \"\"\"Return True if host has sufficient capacity.\"\"\""},{"line_number":33,"context_line":"        volume_size \u003d filter_properties.get(\u0027size\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        if host_state.free_capacity_gb is None:"},{"line_number":36,"context_line":"            # Fail Safe"},{"line_number":37,"context_line":"            LOG.error(_(\"Free capacity not set: \""},{"line_number":38,"context_line":"                        \"volume node info collection broken.\"))"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANH%2F%2F94Y%3D","line":35,"updated":"2013-03-01 05:17:38.000000000","message":"Nice catch","commit_id":"7392e958f887d8d9226c918dc00ff23bd2071b2d"},{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"8f618a5a3f517cd87334749977a0555b4602302e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        reserved \u003d float(host_state.reserved_percentage) / 100"},{"line_number":49,"context_line":"        free \u003d math.floor(free_space * (1 - reserved))"},{"line_number":50,"context_line":"        if free \u003c volume_size:"},{"line_number":51,"context_line":"            LOG.error(_(\"Insufficient free space for volume creation \""},{"line_number":52,"context_line":"                        \"(requested / avail): \""},{"line_number":53,"context_line":"                        \"%(requested)s/%(available)s\")"},{"line_number":54,"context_line":"                      % {\u0027requested\u0027: volume_size,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANH%2F%2F94c%3D","line":51,"updated":"2013-03-01 05:17:38.000000000","message":"I would say this is LOG.info at most, not LOG.error","commit_id":"7392e958f887d8d9226c918dc00ff23bd2071b2d"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"13a64c2b571edc6ae3d268e1082df1645cf7dad6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        reserved \u003d float(host_state.reserved_percentage) / 100"},{"line_number":49,"context_line":"        free \u003d math.floor(free_space * (1 - reserved))"},{"line_number":50,"context_line":"        if free \u003c volume_size:"},{"line_number":51,"context_line":"            LOG.error(_(\"Insufficient free space for volume creation \""},{"line_number":52,"context_line":"                        \"(requested / avail): \""},{"line_number":53,"context_line":"                        \"%(requested)s/%(available)s\")"},{"line_number":54,"context_line":"                      % {\u0027requested\u0027: volume_size,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAANH%2F%2F9Tk%3D","line":51,"in_reply_to":"AAAANH%2F%2F94c%3D","updated":"2013-03-01 15:49:05.000000000","message":"I\u0027m mixed here, a Tenant asks for a volume and doesn\u0027t get it and the db entry is placed in an error state.  Seems like an error to me, even if it is an expected error.  From my perspective when I\u0027m debugging using log files having this be an \"error\" message would sure make my life a lot easier.\n\nIt\u0027s certainly at least a warning IMO.","commit_id":"7392e958f887d8d9226c918dc00ff23bd2071b2d"}]}