)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"1e9626c373518c7f029782e898fad91cc49cb42b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alon Marx \u003calonma@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-10 00:00:49 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Author: Alon Marx"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement changes in the consistency_group handling in the xiv/ds8k driver."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_039bed66","line":7,"updated":"2015-10-09 22:34:18.000000000","message":"It is not necessary to have the Author line.","commit_id":"61d54bca9380c0a073c382bb3ec8a98ab51b0617"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"1709072ae7f5f601f101752aa333b9d6b9cce289","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alon Marx \u003calonma@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-10 00:00:49 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Author: Alon Marx"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implement changes in the consistency_group handling in the xiv/ds8k driver."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_d8e5bfdc","line":7,"in_reply_to":"7a2fa921_039bed66","updated":"2015-10-12 13:18:12.000000000","message":"Thanks. Will be removed.","commit_id":"61d54bca9380c0a073c382bb3ec8a98ab51b0617"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"094448530ff21ee992b6e635c51da65d3372bfc2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"   or from another consistency group (create_consistencygroup_from_src)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8da0e86ec321bf67b59fef8426fdd637dfe83bbe"},{"line_number":15,"context_line":"Implements: bp/xiv-ds8k-cg-updates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_eb8c4737","line":15,"updated":"2015-10-13 01:45:22.000000000","message":"This link doesn\u0027t work when I click on it.  It should be:\n\nbp xiv-ds8k-cg-updates\nor\nblueprint xiv-ds8k-cg-updates","commit_id":"d0175dd9e803b5f66c111bcb37c1d03e6f8a100c"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"7ee91da4360f176acdd393b6c375075bb2ab2fb4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"   or from another consistency group (create_consistencygroup_from_src)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8da0e86ec321bf67b59fef8426fdd637dfe83bbe"},{"line_number":15,"context_line":"Implements: bp/xiv-ds8k-cg-updates"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_12e20fa0","line":15,"in_reply_to":"7a2fa921_eb8c4737","updated":"2015-10-13 06:58:21.000000000","message":"Done","commit_id":"d0175dd9e803b5f66c111bcb37c1d03e6f8a100c"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"63da0befa448e2319151d077103e216c69b400bb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alon Marx \u003calonma@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-13 09:53:28 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement changes in the consistency_group handling in the xiv/ds8k driver."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The changes are:"},{"line_number":10,"context_line":"1. the ability to modify a consistecy group (update_consistencygroup)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a2ca52d_14946d35","line":7,"updated":"2015-10-13 12:53:29.000000000","message":"First line of commit message should be limited to 50 characters and should not end in a period.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"43fd2648752be373bf6f72b1abfd215aae14d631"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"58648001e80660151b39a4c3f58022a656a56fe1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Alon Marx \u003calonma@il.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-13 09:53:28 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement changes in the consistency_group handling in the xiv/ds8k driver."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The changes are:"},{"line_number":10,"context_line":"1. the ability to modify a consistecy group (update_consistencygroup)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a2ca52d_b2aca0ee","line":7,"in_reply_to":"5a2ca52d_14946d35","updated":"2015-10-13 15:36:13.000000000","message":"Done","commit_id":"43fd2648752be373bf6f72b1abfd215aae14d631"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"63da0befa448e2319151d077103e216c69b400bb","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The changes are:"},{"line_number":10,"context_line":"1. the ability to modify a consistecy group (update_consistencygroup)"},{"line_number":11,"context_line":"2. the ability to create a consistency group from a consistency group snapshot"},{"line_number":12,"context_line":"   or from another consistency group (create_consistencygroup_from_src)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8da0e86ec321bf67b59fef8426fdd637dfe83bbe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a2ca52d_37b96b2f","line":11,"updated":"2015-10-13 12:53:29.000000000","message":"Lines should be wrapped at 72 characters. \n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"43fd2648752be373bf6f72b1abfd215aae14d631"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"58648001e80660151b39a4c3f58022a656a56fe1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The changes are:"},{"line_number":10,"context_line":"1. the ability to modify a consistecy group (update_consistencygroup)"},{"line_number":11,"context_line":"2. the ability to create a consistency group from a consistency group snapshot"},{"line_number":12,"context_line":"   or from another consistency group (create_consistencygroup_from_src)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I8da0e86ec321bf67b59fef8426fdd637dfe83bbe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5a2ca52d_72b6083f","line":11,"in_reply_to":"5a2ca52d_37b96b2f","updated":"2015-10-13 15:36:13.000000000","message":"Done","commit_id":"43fd2648752be373bf6f72b1abfd215aae14d631"}],"cinder/tests/unit/test_ibm_xiv_ds8k.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"094448530ff21ee992b6e635c51da65d3372bfc2","unresolved":false,"context_lines":[{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        # Update consistency group"},{"line_number":863,"context_line":"        model_update, added, removed \u003d self.driver.update_consistencygroup("},{"line_number":864,"context_line":"            ctxt, CONSISTGROUP, [], [])"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        self.assertEqual(\u0027available\u0027,"},{"line_number":867,"context_line":"                         model_update[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_0b4983d0","line":864,"updated":"2015-10-13 01:45:22.000000000","message":"Can you add tests that add some volumes and remove some volumes rather than empty lists?","commit_id":"d0175dd9e803b5f66c111bcb37c1d03e6f8a100c"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"7ee91da4360f176acdd393b6c375075bb2ab2fb4","unresolved":false,"context_lines":[{"line_number":861,"context_line":""},{"line_number":862,"context_line":"        # Update consistency group"},{"line_number":863,"context_line":"        model_update, added, removed \u003d self.driver.update_consistencygroup("},{"line_number":864,"context_line":"            ctxt, CONSISTGROUP, [], [])"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"        self.assertEqual(\u0027available\u0027,"},{"line_number":867,"context_line":"                         model_update[\u0027status\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_52ff2734","line":864,"in_reply_to":"7a2fa921_0b4983d0","updated":"2015-10-13 06:58:21.000000000","message":"Done","commit_id":"d0175dd9e803b5f66c111bcb37c1d03e6f8a100c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"094448530ff21ee992b6e635c51da65d3372bfc2","unresolved":false,"context_lines":[{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        # Create consistency group from source"},{"line_number":882,"context_line":"        model_update, volumes \u003d self.driver.create_consistencygroup_from_src("},{"line_number":883,"context_line":"            ctxt, CONSISTGROUP, [], CG_SNAPSHOT, [])"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        # model_update can be None or return available in status"},{"line_number":886,"context_line":"        if model_update:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_ab872fd6","line":883,"updated":"2015-10-13 01:45:22.000000000","message":"Can  you add tests that have volumes in the CG and snapshots in the cgsnapshot rather than empty lists?","commit_id":"d0175dd9e803b5f66c111bcb37c1d03e6f8a100c"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"7ee91da4360f176acdd393b6c375075bb2ab2fb4","unresolved":false,"context_lines":[{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        # Create consistency group from source"},{"line_number":882,"context_line":"        model_update, volumes \u003d self.driver.create_consistencygroup_from_src("},{"line_number":883,"context_line":"            ctxt, CONSISTGROUP, [], CG_SNAPSHOT, [])"},{"line_number":884,"context_line":""},{"line_number":885,"context_line":"        # model_update can be None or return available in status"},{"line_number":886,"context_line":"        if model_update:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_f2fbd345","line":883,"in_reply_to":"7a2fa921_ab872fd6","updated":"2015-10-13 06:58:21.000000000","message":"Done","commit_id":"d0175dd9e803b5f66c111bcb37c1d03e6f8a100c"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"2cb7394294bd76f4f1fe66360747ebfecb99cde7","unresolved":false,"context_lines":[{"line_number":863,"context_line":"                          ctxt, CG_SNAPSHOT)"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    def test_update_consistencygroup_without_volumes(self):"},{"line_number":866,"context_line":"        \"\"\"Test update_consistencygroup when there are no volumes specified\"\"\""},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"        self.driver.do_setup(None)"},{"line_number":869,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_fbaad518","line":866,"updated":"2015-10-14 07:55:57.000000000","message":"Please add s top in the end.","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"66055a38da7beaec85b81432d240cd9d9521e4be","unresolved":false,"context_lines":[{"line_number":863,"context_line":"                          ctxt, CG_SNAPSHOT)"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"    def test_update_consistencygroup_without_volumes(self):"},{"line_number":866,"context_line":"        \"\"\"Test update_consistencygroup when there are no volumes specified\"\"\""},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"        self.driver.do_setup(None)"},{"line_number":869,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_a5b418f2","line":866,"in_reply_to":"5a2ca52d_fbaad518","updated":"2015-10-14 20:23:43.000000000","message":"Done","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"2cb7394294bd76f4f1fe66360747ebfecb99cde7","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                         \"removed volumes list is not empty\")"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def test_update_consistencygroup_with_volumes(self):"},{"line_number":885,"context_line":"        \"\"\"Test update_consistencygroup when there are volumes specified\"\"\""},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"        self.driver.do_setup(None)"},{"line_number":888,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_1ba8f11e","line":885,"updated":"2015-10-14 07:55:57.000000000","message":"Please add s top in the end.","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"66055a38da7beaec85b81432d240cd9d9521e4be","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                         \"removed volumes list is not empty\")"},{"line_number":883,"context_line":""},{"line_number":884,"context_line":"    def test_update_consistencygroup_with_volumes(self):"},{"line_number":885,"context_line":"        \"\"\"Test update_consistencygroup when there are volumes specified\"\"\""},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"        self.driver.do_setup(None)"},{"line_number":888,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_c5b7d4f3","line":885,"in_reply_to":"5a2ca52d_1ba8f11e","updated":"2015-10-14 20:23:43.000000000","message":"Done","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"2cb7394294bd76f4f1fe66360747ebfecb99cde7","unresolved":false,"context_lines":[{"line_number":901,"context_line":"                         \"removed volumes list is not empty\")"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"    def test_create_consistencygroup_from_src_without_volumes(self):"},{"line_number":904,"context_line":"        \"\"\"Test create_consistencygroup_from_src with no volumes specified\"\"\""},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        self.driver.do_setup(None)"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_bb63fd19","line":904,"updated":"2015-10-14 07:55:57.000000000","message":"Please add s top in the end.","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"66055a38da7beaec85b81432d240cd9d9521e4be","unresolved":false,"context_lines":[{"line_number":901,"context_line":"                         \"removed volumes list is not empty\")"},{"line_number":902,"context_line":""},{"line_number":903,"context_line":"    def test_create_consistencygroup_from_src_without_volumes(self):"},{"line_number":904,"context_line":"        \"\"\"Test create_consistencygroup_from_src with no volumes specified\"\"\""},{"line_number":905,"context_line":""},{"line_number":906,"context_line":"        self.driver.do_setup(None)"},{"line_number":907,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_85ca3c6d","line":904,"in_reply_to":"5a2ca52d_bb63fd19","updated":"2015-10-14 20:23:43.000000000","message":"Done","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"2cb7394294bd76f4f1fe66360747ebfecb99cde7","unresolved":false,"context_lines":[{"line_number":908,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        # Create consistency group from source"},{"line_number":911,"context_line":"        model_update, volumes_model_update \u003d \\"},{"line_number":912,"context_line":"            self.driver.create_consistencygroup_from_src("},{"line_number":913,"context_line":"                ctxt, CONSISTGROUP, [], CG_SNAPSHOT, [])"},{"line_number":914,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_5b00a934","line":911,"updated":"2015-10-14 07:55:57.000000000","message":"Try to use () to replace \\.","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"66055a38da7beaec85b81432d240cd9d9521e4be","unresolved":false,"context_lines":[{"line_number":908,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":909,"context_line":""},{"line_number":910,"context_line":"        # Create consistency group from source"},{"line_number":911,"context_line":"        model_update, volumes_model_update \u003d \\"},{"line_number":912,"context_line":"            self.driver.create_consistencygroup_from_src("},{"line_number":913,"context_line":"                ctxt, CONSISTGROUP, [], CG_SNAPSHOT, [])"},{"line_number":914,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_a582d8fe","line":911,"in_reply_to":"5a2ca52d_5b00a934","updated":"2015-10-14 20:23:43.000000000","message":"it is possible to do so, but it doesn\u0027t look better. At least not to me.","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"2cb7394294bd76f4f1fe66360747ebfecb99cde7","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"        # Create consistency group from source"},{"line_number":933,"context_line":"        model_update, volumes_model_update \u003d \\"},{"line_number":934,"context_line":"            self.driver.create_consistencygroup_from_src("},{"line_number":935,"context_line":"                ctxt, CONSISTGROUP, [VOLUME], CG_SNAPSHOT, [SNAPSHOT])"},{"line_number":936,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_bb953de5","line":933,"updated":"2015-10-14 07:55:57.000000000","message":"Try to use () to replace \\.","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"66055a38da7beaec85b81432d240cd9d9521e4be","unresolved":false,"context_lines":[{"line_number":930,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":931,"context_line":""},{"line_number":932,"context_line":"        # Create consistency group from source"},{"line_number":933,"context_line":"        model_update, volumes_model_update \u003d \\"},{"line_number":934,"context_line":"            self.driver.create_consistencygroup_from_src("},{"line_number":935,"context_line":"                ctxt, CONSISTGROUP, [VOLUME], CG_SNAPSHOT, [SNAPSHOT])"},{"line_number":936,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_c5859407","line":933,"in_reply_to":"5a2ca52d_bb953de5","updated":"2015-10-14 20:23:43.000000000","message":"it is possible to do so, but it doesn\u0027t look better. At least not to me.","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"}],"cinder/volume/drivers/ibm/xiv_ds8k.py":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"1e9626c373518c7f029782e898fad91cc49cb42b","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        return self.xiv_ds8k_proxy.delete_cgsnapshot(context, cgsnapshot)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":267,"context_line":"                                add_volumes, remove_volumes):"},{"line_number":268,"context_line":"        \"\"\"Adds or removes volume(s) to/from an existing consistency group\"\"\""},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_0300cd64","line":266,"updated":"2015-10-09 22:34:18.000000000","message":"Are there unit tests for these new supported methods?","commit_id":"61d54bca9380c0a073c382bb3ec8a98ab51b0617"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"1709072ae7f5f601f101752aa333b9d6b9cce289","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        return self.xiv_ds8k_proxy.delete_cgsnapshot(context, cgsnapshot)"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":267,"context_line":"                                add_volumes, remove_volumes):"},{"line_number":268,"context_line":"        \"\"\"Adds or removes volume(s) to/from an existing consistency group\"\"\""},{"line_number":269,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_98f7478c","line":266,"in_reply_to":"7a2fa921_0300cd64","updated":"2015-10-12 13:18:12.000000000","message":"Will be delivered in next patch.","commit_id":"61d54bca9380c0a073c382bb3ec8a98ab51b0617"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"78fc72c979a7c1a7ffbaac26c4a078c7f1b36893","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                add_volumes, remove_volumes):"},{"line_number":268,"context_line":"        \"\"\"Adds or removes volume(s) to/from an existing consistency group\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        return self.xiv_ds8k_proxy.update_consistencygroup("},{"line_number":271,"context_line":"            context, group, add_volumes, remove_volumes)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def create_consistencygroup_from_src("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_9fe65faf","line":270,"updated":"2015-10-12 01:54:18.000000000","message":"This xiv_ds8k_proxy is maintained outside of cinder, right?  I am wondering how do you make sure cinder driver uses correct version of this dependent XIVDS8K driver class, assuming there is a versioning control of this class.","commit_id":"61d54bca9380c0a073c382bb3ec8a98ab51b0617"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"1709072ae7f5f601f101752aa333b9d6b9cce289","unresolved":false,"context_lines":[{"line_number":267,"context_line":"                                add_volumes, remove_volumes):"},{"line_number":268,"context_line":"        \"\"\"Adds or removes volume(s) to/from an existing consistency group\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        return self.xiv_ds8k_proxy.update_consistencygroup("},{"line_number":271,"context_line":"            context, group, add_volumes, remove_volumes)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def create_consistencygroup_from_src("}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_b88563ae","line":270,"in_reply_to":"7a2fa921_9fe65faf","updated":"2015-10-12 13:18:12.000000000","message":"First of all, previous cinder versions did not have this function, so there is no problem in this specific case. \nIn addition, in our installation we verify that the driver fits the installed cinder version.","commit_id":"61d54bca9380c0a073c382bb3ec8a98ab51b0617"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"2cb7394294bd76f4f1fe66360747ebfecb99cde7","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":267,"context_line":"                                add_volumes, remove_volumes):"},{"line_number":268,"context_line":"        \"\"\"Adds or removes volume(s) to/from an existing consistency group\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        return self.xiv_ds8k_proxy.update_consistencygroup("},{"line_number":271,"context_line":"            context, group, add_volumes, remove_volumes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_7b6d6503","line":268,"updated":"2015-10-14 07:55:57.000000000","message":"Please add s top in the end.","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"66055a38da7beaec85b81432d240cd9d9521e4be","unresolved":false,"context_lines":[{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def update_consistencygroup(self, context, group,"},{"line_number":267,"context_line":"                                add_volumes, remove_volumes):"},{"line_number":268,"context_line":"        \"\"\"Adds or removes volume(s) to/from an existing consistency group\"\"\""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        return self.xiv_ds8k_proxy.update_consistencygroup("},{"line_number":271,"context_line":"            context, group, add_volumes, remove_volumes)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_e5b690db","line":268,"in_reply_to":"5a2ca52d_7b6d6503","updated":"2015-10-14 20:23:43.000000000","message":"Done","commit_id":"4f1333a3b9b6a1db1ea8ce33c76bb9d275300b87"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"7f88a146cdf90102204ecb08b5be06e3faee51b3","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def create_consistencygroup_from_src("},{"line_number":274,"context_line":"            self, context, group, volumes, cgsnapshot, snapshots,"},{"line_number":275,"context_line":"            source_cg\u003dNone, sorted_source_vols\u003dNone):"},{"line_number":276,"context_line":"        \"\"\"Creates a consistencygroup from source.\"\"\""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        return self.xiv_ds8k_proxy.create_consistencygroup_from_src("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_f5b440d2","line":275,"updated":"2015-10-19 03:40:22.000000000","message":"The last parameter name in driver.py is \"source_vols\", not \"sorted_source_vols\".  So it should be changed to \"source_vols\".","commit_id":"efbcdb908159f6bbfbb2cb971fb0b106cf40c257"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"b97e59a9df2e317add577dc552a386374c31604e","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def create_consistencygroup_from_src("},{"line_number":274,"context_line":"            self, context, group, volumes, cgsnapshot, snapshots,"},{"line_number":275,"context_line":"            source_cg\u003dNone, sorted_source_vols\u003dNone):"},{"line_number":276,"context_line":"        \"\"\"Creates a consistencygroup from source.\"\"\""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        return self.xiv_ds8k_proxy.create_consistencygroup_from_src("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_2c24a70b","line":275,"in_reply_to":"3a29b11f_f5b440d2","updated":"2015-10-19 11:32:31.000000000","message":"Good catch. Thanks!\n\nDone","commit_id":"efbcdb908159f6bbfbb2cb971fb0b106cf40c257"}]}