)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"37f22acab021f694abe9084d73a403d7b5b0e05b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Huawei driver handle volume exists error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently when we create a volume on the array"},{"line_number":10,"context_line":"but the volume already exists on the array,"},{"line_number":11,"context_line":"there will be a exception. But in fact it should"},{"line_number":12,"context_line":"just go on and needn\u0027t a exception."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_2187d7d8","line":9,"updated":"2015-10-12 15:29:03.000000000","message":"Suggestion: \u0027on the array\u0027 -\u003e  \u0027on an array\u0027","commit_id":"302ad1e74cc0212adb138c6738ad632ebe8f9e6d"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"37f22acab021f694abe9084d73a403d7b5b0e05b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Huawei driver handle volume exists error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently when we create a volume on the array"},{"line_number":10,"context_line":"but the volume already exists on the array,"},{"line_number":11,"context_line":"there will be a exception. But in fact it should"},{"line_number":12,"context_line":"just go on and needn\u0027t a exception."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_c1af032a","line":10,"updated":"2015-10-12 15:29:03.000000000","message":"Suggestion: \u0027 but the volume already exists on the array,\u0027 -\u003e \u0027where that volume already exists,\u0027","commit_id":"302ad1e74cc0212adb138c6738ad632ebe8f9e6d"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"37f22acab021f694abe9084d73a403d7b5b0e05b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently when we create a volume on the array"},{"line_number":10,"context_line":"but the volume already exists on the array,"},{"line_number":11,"context_line":"there will be a exception. But in fact it should"},{"line_number":12,"context_line":"just go on and needn\u0027t a exception."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I13a52e81c1c271ea6728cb4a23717609d95bae69"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_a1a68751","line":11,"updated":"2015-10-12 15:29:03.000000000","message":"a -\u003e an","commit_id":"302ad1e74cc0212adb138c6738ad632ebe8f9e6d"},{"author":{"_account_id":17405,"name":"Jacob Gregor","email":"jgregor@us.ibm.com","username":"jgregor"},"change_message_id":"37f22acab021f694abe9084d73a403d7b5b0e05b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently when we create a volume on the array"},{"line_number":10,"context_line":"but the volume already exists on the array,"},{"line_number":11,"context_line":"there will be a exception. But in fact it should"},{"line_number":12,"context_line":"just go on and needn\u0027t a exception."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I13a52e81c1c271ea6728cb4a23717609d95bae69"},{"line_number":15,"context_line":"Closes-Bug: #1504718"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a2fa921_016c1b07","line":12,"updated":"2015-10-12 15:29:03.000000000","message":"Suggestion: \u0027needn\u0027t a\u0027 -\u003e \u0027doesn\u0027t need an\u0027","commit_id":"302ad1e74cc0212adb138c6738ad632ebe8f9e6d"}],"cinder/tests/unit/test_huawei_drivers.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"b5e18c0974a3f1468cc32f61760a1e7d400ff569","unresolved":false,"context_lines":[{"line_number":1726,"context_line":"        self.driver.restclient.login()"},{"line_number":1727,"context_line":"        lun_param \u003d {\u0027NAME\u0027: \u0027IexzQZJWSXuX2e9I7c8GNQ\u0027}"},{"line_number":1728,"context_line":""},{"line_number":1729,"context_line":"        global MAP_COMMAND_TO_FAKE_RESPONSE"},{"line_number":1730,"context_line":"        FAKE_ERROR_VOLUME_EXIST \u003d \"\"\""},{"line_number":1731,"context_line":"        {"},{"line_number":1732,"context_line":"            \"error\":{"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_201d8a0f","line":1729,"updated":"2015-10-12 18:06:23.000000000","message":"Please, don\u0027t change global constants in the tests. Use mocks and setUp/rearDown methods for it","commit_id":"302ad1e74cc0212adb138c6738ad632ebe8f9e6d"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"446f22f9f5ec5e7fdac498ecc399f99183a3f87f","unresolved":false,"context_lines":[{"line_number":1740,"context_line":"        lun_param \u003d {\u0027NAME\u0027: \u0027IexzQZJWSXuX2e9I7c8GNQ\u0027}"},{"line_number":1741,"context_line":"        lun_info \u003d self.driver.restclient.create_volume(lun_param)"},{"line_number":1742,"context_line":"        self.assertEqual(\u002711\u0027, lun_info[\u0027ID\u0027])"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"    def create_fake_conf_file(self):"},{"line_number":1745,"context_line":"        \"\"\"Create a fake Config file."},{"line_number":1746,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_45f51f81","line":1743,"updated":"2015-10-13 07:17:44.000000000","message":"If I do not misunderstand it, shall we add one more case to test if result[\u0027error\u0027][\u0027code\u0027] !\u003d constants.ERROR_VOLUME_ALREADY_EXIST?\nAnd what if get_volume_by_name return None? Is it possible when it runs create_volume?","commit_id":"8ef8e3fb7eb5200a794e04ac68287f274ede4c4b"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"9192acd8b68325d8e262583ff831c825c7992c6a","unresolved":false,"context_lines":[{"line_number":1740,"context_line":"        lun_param \u003d {\u0027NAME\u0027: \u0027IexzQZJWSXuX2e9I7c8GNQ\u0027}"},{"line_number":1741,"context_line":"        lun_info \u003d self.driver.restclient.create_volume(lun_param)"},{"line_number":1742,"context_line":"        self.assertEqual(\u002711\u0027, lun_info[\u0027ID\u0027])"},{"line_number":1743,"context_line":""},{"line_number":1744,"context_line":"    def create_fake_conf_file(self):"},{"line_number":1745,"context_line":"        \"\"\"Create a fake Config file."},{"line_number":1746,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_8516d753","line":1743,"in_reply_to":"7a2fa921_45f51f81","updated":"2015-10-13 07:25:14.000000000","message":"Sure, will add more test cases, thanks!","commit_id":"8ef8e3fb7eb5200a794e04ac68287f274ede4c4b"}]}