)]}'
{"cinder/volume/drivers/huawei/huawei_iscsi.py":[{"author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"change_message_id":"d25415eaa8a1ff4758973c3a7f8bc35dee62f12e","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                if map[\u0027devlunid\u0027] \u003d\u003d lun_id:"},{"line_number":283,"context_line":"                    hostlun_id \u003d map[\u0027hostlunid\u0027]"},{"line_number":284,"context_line":"                    break"},{"line_number":285,"context_line":"                elif new_hostlunid_found is False:"},{"line_number":286,"context_line":"                    if new_hostlun_id \u003c int(map[\u0027hostlunid\u0027]):"},{"line_number":287,"context_line":"                        new_hostlunid_found \u003d True"},{"line_number":288,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2Ffs%3D","line":285,"updated":"2013-03-04 12:05:10.000000000","message":"If your goal is to find the smallest unused ID that is \u003e\u003d 1, this code doesn\u0027t seem to do that unless map_info is sorted by hostlunid.  For example, if the IDs you see are [2, 1], then if I\u0027m not mistaken you will re-use ID 1.","commit_id":"21e3f34a003acc707ed3d9e0796038308f4ebb99"},{"author":{"_account_id":6604,"name":"zhangchao","email":"zhangchao010@huawei.com","username":"zhangchao010"},"change_message_id":"1a29d86568a3d1ac9013e3c84701765429033845","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                if map[\u0027devlunid\u0027] \u003d\u003d lun_id:"},{"line_number":283,"context_line":"                    hostlun_id \u003d map[\u0027hostlunid\u0027]"},{"line_number":284,"context_line":"                    break"},{"line_number":285,"context_line":"                elif new_hostlunid_found is False:"},{"line_number":286,"context_line":"                    if new_hostlun_id \u003c int(map[\u0027hostlunid\u0027]):"},{"line_number":287,"context_line":"                        new_hostlunid_found \u003d True"},{"line_number":288,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F%2FWc%3D","line":285,"in_reply_to":"AAAAN3%2F%2F%2Ffs%3D","updated":"2013-03-04 14:21:05.000000000","message":"My goal: First, if the host LUN ID already exists, no need to map once more, just return its host LUN ID. Second, if not mapped, we get the smallest unused host LUN ID and map the LUN. In fact, in function _get_map_info, list map_info is already sorted by host LUN ID. So, it makes sure I will get the right host LUN ID. Please see function _get_map_info. Thanks for your review.","commit_id":"21e3f34a003acc707ed3d9e0796038308f4ebb99"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"cf692a307a45996d46804587e673158af760f5ea","unresolved":false,"context_lines":[{"line_number":555,"context_line":"    def _get_login_info(self):"},{"line_number":556,"context_line":"        \"\"\"Get login IP, username and password from config file.\"\"\""},{"line_number":557,"context_line":"        logininfo \u003d {}"},{"line_number":558,"context_line":"        tree \u003d ET.parse(FLAGS.cinder_huawei_conf_file)"},{"line_number":559,"context_line":"        root \u003d tree.getroot()"},{"line_number":560,"context_line":"        try:"},{"line_number":561,"context_line":"            logininfo[\u0027ControllerIP0\u0027] \u003d root.findtext(\u0027Storage/ControllerIP0\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F4yA%3D","line":558,"updated":"2013-03-07 16:25:48.000000000","message":"At this point you should go longer be using FLAGS, this driver will not work in a multi backend environments. The correct way to access the config file entries is by using self.configuration. You can look at some of the open cinder reviews or other drivers for examples. I looked at the open bug for the driver and did not see one to remove the usage of FLAGS for this driver.","commit_id":"83de75dcd9a42e1bf40bed424dbce583078c8270"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"cf692a307a45996d46804587e673158af760f5ea","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                    need_encryption \u003d True"},{"line_number":574,"context_line":"            if need_encryption:"},{"line_number":575,"context_line":"                try:"},{"line_number":576,"context_line":"                    tree.write(FLAGS.cinder_huawei_conf_file, \u0027UTF-8\u0027)"},{"line_number":577,"context_line":"                except Exception as err:"},{"line_number":578,"context_line":"                    LOG.error(_(\u0027Write login information to xml error. %s\u0027)"},{"line_number":579,"context_line":"                              % err)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F4yQ%3D","line":576,"updated":"2013-03-07 16:25:48.000000000","message":"same as above","commit_id":"83de75dcd9a42e1bf40bed424dbce583078c8270"}]}