)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"6e8178d0370dd9b2e973f6a42e83ef8352e88fc7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is a bug in python 3.4 such that if you call LOG.exception and"},{"line_number":10,"context_line":"you\u0027re not in a logging handler context it fails:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"http://bugs.python.org/issue17911"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This fixes the instance in the windows vhdutils module to use LOG.error"},{"line_number":15,"context_line":"rather than LOG.exception to avoid that traceback."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_5a250eac","line":12,"updated":"2015-10-12 21:48:36.000000000","message":"This is an unrelated patch in Python. (It only affects 3.5 and up, and doesn\u0027t affect logging at all AFAIK)... oh, so it incidentally fixed the regression vs Python2 of traceback.print_exception() when sys.exc_info() is None - great, but its going to confuse people reading this :).","commit_id":"1f40348cf34d22de49e09cb9268ff276245b630e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e6376425920f5379e66a4feda7edb7bb08f5524","unresolved":false,"context_lines":[{"line_number":9,"context_line":"There is a bug in python 3.4 such that if you call LOG.exception and"},{"line_number":10,"context_line":"you\u0027re not in a logging handler context it fails:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"http://bugs.python.org/issue17911"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This fixes the instance in the windows vhdutils module to use LOG.error"},{"line_number":15,"context_line":"rather than LOG.exception to avoid that traceback."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_1548c72c","line":12,"in_reply_to":"7a2fa921_5a250eac","updated":"2015-10-12 22:10:23.000000000","message":"OK, I guess I\u0027m not sure what the actual upstream bug is then, if there is one.  I could just remove this reference and say \u0027a bug fixed by 17911 in 3.5\u0027.","commit_id":"1f40348cf34d22de49e09cb9268ff276245b630e"},{"author":{"_account_id":17275,"name":"Nate Potter","email":"nathaniel.potter@intel.com","username":"npotter"},"change_message_id":"532e608d90e03cb6a33629cc5f6cd9045571c3ae","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-14 09:33:58 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"windows: don\u0027t use LOG.exception if not logging an exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a bug in python 3.4 such that if you call LOG.exception and"},{"line_number":10,"context_line":"you\u0027re not in a logging handler context it fails. That bug is fixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_1abf6bfc","line":7,"updated":"2015-10-14 19:48:23.000000000","message":"I think you need to limit the first line to 50 characters.","commit_id":"3522711b3e699e3dbc5c260b0f3f9ad6ea2d4ed7"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"681715fb912328d5adf407c4ca4b3992c50fdcec","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-14 09:33:58 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"windows: don\u0027t use LOG.exception if not logging an exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a bug in python 3.4 such that if you call LOG.exception and"},{"line_number":10,"context_line":"you\u0027re not in a logging handler context it fails. That bug is fixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_9a837bcc","line":7,"in_reply_to":"5a2ca52d_1abf6bfc","updated":"2015-10-14 20:04:18.000000000","message":"+1","commit_id":"3522711b3e699e3dbc5c260b0f3f9ad6ea2d4ed7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"8de9035056eb477de13dbcb936127c429b78bc99","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Matt Riedemann \u003cmriedem@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-14 09:33:58 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"windows: don\u0027t use LOG.exception if not logging an exception"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There is a bug in python 3.4 such that if you call LOG.exception and"},{"line_number":10,"context_line":"you\u0027re not in a logging handler context it fails. That bug is fixed"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_7730f5e8","line":7,"in_reply_to":"5a2ca52d_9a837bcc","updated":"2015-10-14 21:41:34.000000000","message":"No, you don\u0027t.","commit_id":"3522711b3e699e3dbc5c260b0f3f9ad6ea2d4ed7"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"681715fb912328d5adf407c4ca4b3992c50fdcec","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rather than LOG.exception to avoid that logging error."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Since LOG.exception was being used I\u0027m assuming the original author wanted"},{"line_number":19,"context_line":"traceback given this is a utility method, so we use the exc_info kwarg which"},{"line_number":20,"context_line":"will log a traceback if there is one."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1505240"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_ba8677d9","line":19,"updated":"2015-10-14 20:04:18.000000000","message":"And Subsequent lines should be wrapped at 72 characters.\n\nSee https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"3522711b3e699e3dbc5c260b0f3f9ad6ea2d4ed7"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"51f48b1e1eee08a6efa99e01838d64a8a31e64da","unresolved":false,"context_lines":[{"line_number":16,"context_line":"rather than LOG.exception to avoid that logging error."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Since LOG.exception was being used I\u0027m assuming the original author wanted"},{"line_number":19,"context_line":"traceback given this is a utility method, so we use the exc_info kwarg which"},{"line_number":20,"context_line":"will log a traceback if there is one."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1505240"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_976911c1","line":19,"in_reply_to":"5a2ca52d_ba8677d9","updated":"2015-10-14 21:42:47.000000000","message":"Then write a pep8 / hacking rule check to change it.  I\u0027m not updating this for that.","commit_id":"3522711b3e699e3dbc5c260b0f3f9ad6ea2d4ed7"}],"cinder/volume/drivers/windows/vhdutils.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5c04882b255b455b0bd7f27b488cde976d13af98","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                   {\u0027func_name\u0027: func_name,"},{"line_number":211,"context_line":"                    \u0027error_code\u0027: ret_val,"},{"line_number":212,"context_line":"                    \u0027error_message\u0027: error_message})"},{"line_number":213,"context_line":"            LOG.error(err, exc_info\u003dTrue)"},{"line_number":214,"context_line":"            raise exception.VolumeBackendAPIException(err)"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a2fa921_af93c54e","line":213,"updated":"2015-10-12 20:23:49.000000000","message":"Looks like we shouldn\u0027t use exc_info either:\n\nhttp://logs.openstack.org/44/233644/1/check/gate-cinder-python34/444dee9/console.html#_2015-10-12_14_12_11_481","commit_id":"3771926dd602001a52709f3d1edaace71a476d5c"},{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"6e8178d0370dd9b2e973f6a42e83ef8352e88fc7","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                # 17911 so use stack_info here."},{"line_number":220,"context_line":"                LOG.error(err, stack_info\u003dTrue)"},{"line_number":221,"context_line":"            else:"},{"line_number":222,"context_line":"                LOG.error(err, exc_info\u003dTrue)"},{"line_number":223,"context_line":"            raise exception.VolumeBackendAPIException(err)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_daf83ec7","line":222,"updated":"2015-10-12 21:48:36.000000000","message":"You could do\n\nLOG.error(err, exc_info\u003d(sys.exc_info() is not None)\n\nand that will work on all versions of Python I believe","commit_id":"1f40348cf34d22de49e09cb9268ff276245b630e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"19bca20020f1634720d686c275c2927a843385da","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                # 17911 so use stack_info here."},{"line_number":220,"context_line":"                LOG.error(err, stack_info\u003dTrue)"},{"line_number":221,"context_line":"            else:"},{"line_number":222,"context_line":"                LOG.error(err, exc_info\u003dTrue)"},{"line_number":223,"context_line":"            raise exception.VolumeBackendAPIException(err)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_15a0c78f","line":222,"in_reply_to":"7a2fa921_552abf2d","updated":"2015-10-12 22:14:22.000000000","message":"Actually this is on purpose regardless of whether or not we\u0027re handling an exception, to just dump the stacktrace which is why I\u0027m assuming LOG.exception was used in the first place, for the traceback to show the call chain that got us to this generic utility method.","commit_id":"1f40348cf34d22de49e09cb9268ff276245b630e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"7e6376425920f5379e66a4feda7edb7bb08f5524","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                # 17911 so use stack_info here."},{"line_number":220,"context_line":"                LOG.error(err, stack_info\u003dTrue)"},{"line_number":221,"context_line":"            else:"},{"line_number":222,"context_line":"                LOG.error(err, exc_info\u003dTrue)"},{"line_number":223,"context_line":"            raise exception.VolumeBackendAPIException(err)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_552abf2d","line":222,"in_reply_to":"7a2fa921_daf83ec7","updated":"2015-10-12 22:10:23.000000000","message":"Alright.","commit_id":"1f40348cf34d22de49e09cb9268ff276245b630e"}]}