)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"96343f728b69eb40d86fca572e26493e3f107a91","unresolved":false,"context_lines":[{"line_number":14,"context_line":"these additional models, it will lead to NULL key error, when"},{"line_number":15,"context_line":"either source or destination model has a NULL key pointer."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Besides the above change, LVM driver needs to implement retype,"},{"line_number":18,"context_line":"so that if the source volume and destination are on the"},{"line_number":19,"context_line":"back-end, we do not need to do the migration physically."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_1288e7e6","line":17,"updated":"2015-10-19 09:44:25.000000000","message":"-1: This part of the patch should go in another patch.","commit_id":"c98b62b86c21c8f61fd75e4b08a946a9f19a5c64"}],"cinder/tests/unit/db/test_finish_migration.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9d35d8b15e1b1e66ac56195146fb653b5acfcd45","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        source_type_id \u003d None"},{"line_number":46,"context_line":"        dest_type_id \u003d None"},{"line_number":47,"context_line":"        if source_type:"},{"line_number":48,"context_line":"            db.volume_type_create(ctxt, source_type)"},{"line_number":49,"context_line":"            source_type_id \u003d db.volume_type_get_by_name("},{"line_number":50,"context_line":"                ctxt, source_type[\u0027name\u0027])[\u0027id\u0027]"},{"line_number":51,"context_line":"        if dest_type:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_95dca9e5","line":48,"updated":"2015-10-20 08:42:28.000000000","message":"nit: This call returns an ORM object, so we can get the id from it","commit_id":"3865aaa743270610293fb87d76c7484e8ae7670f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4c670eba3c12cdf516ae99041b265f21a99211f5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        source_type_id \u003d None"},{"line_number":46,"context_line":"        dest_type_id \u003d None"},{"line_number":47,"context_line":"        if source_type:"},{"line_number":48,"context_line":"            db.volume_type_create(ctxt, source_type)"},{"line_number":49,"context_line":"            source_type_id \u003d db.volume_type_get_by_name("},{"line_number":50,"context_line":"                ctxt, source_type[\u0027name\u0027])[\u0027id\u0027]"},{"line_number":51,"context_line":"        if dest_type:"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_2fd2c75c","line":48,"in_reply_to":"3a29b11f_95dca9e5","updated":"2015-10-22 03:24:57.000000000","message":"+1","commit_id":"3865aaa743270610293fb87d76c7484e8ae7670f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4c670eba3c12cdf516ae99041b265f21a99211f5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        if source_type:"},{"line_number":48,"context_line":"            db.volume_type_create(ctxt, source_type)"},{"line_number":49,"context_line":"            source_type_id \u003d db.volume_type_get_by_name("},{"line_number":50,"context_line":"                ctxt, source_type[\u0027name\u0027])[\u0027id\u0027]"},{"line_number":51,"context_line":"        if dest_type:"},{"line_number":52,"context_line":"            db.volume_type_create(ctxt, dest_type)"},{"line_number":53,"context_line":"            dest_type_id \u003d db.volume_type_get_by_name("}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_4f3e238d","line":50,"updated":"2015-10-22 03:24:57.000000000","message":"This extra call to db can be removed if we can get id from line 48.","commit_id":"3865aaa743270610293fb87d76c7484e8ae7670f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9d35d8b15e1b1e66ac56195146fb653b5acfcd45","unresolved":false,"context_lines":[{"line_number":49,"context_line":"            source_type_id \u003d db.volume_type_get_by_name("},{"line_number":50,"context_line":"                ctxt, source_type[\u0027name\u0027])[\u0027id\u0027]"},{"line_number":51,"context_line":"        if dest_type:"},{"line_number":52,"context_line":"            db.volume_type_create(ctxt, dest_type)"},{"line_number":53,"context_line":"            dest_type_id \u003d db.volume_type_get_by_name("},{"line_number":54,"context_line":"                ctxt, dest_type[\u0027name\u0027])[\u0027id\u0027]"},{"line_number":55,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_b5d765be","line":52,"updated":"2015-10-20 08:42:28.000000000","message":"nit: Same here","commit_id":"3865aaa743270610293fb87d76c7484e8ae7670f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4c670eba3c12cdf516ae99041b265f21a99211f5","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        if dest_type:"},{"line_number":52,"context_line":"            db.volume_type_create(ctxt, dest_type)"},{"line_number":53,"context_line":"            dest_type_id \u003d db.volume_type_get_by_name("},{"line_number":54,"context_line":"                ctxt, dest_type[\u0027name\u0027])[\u0027id\u0027]"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        src_volume \u003d testutils.create_volume(ctxt, host\u003d\u0027src\u0027,"},{"line_number":57,"context_line":"                                             migration_status\u003d\u0027migrating\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a29b11f_ef55afc1","line":54,"updated":"2015-10-22 03:24:57.000000000","message":"Same here","commit_id":"3865aaa743270610293fb87d76c7484e8ae7670f"}]}