)]}'
{"cinder/volume/drivers/windows/windows_utils.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"507874f707beb9286f4b87ddf4cac6ce65d72b38","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            self._conn_wmi.WT_Host.NewHost(HostName\u003dtarget_name)"},{"line_number":286,"context_line":"        except wmi.x_wmi as exc:"},{"line_number":287,"context_line":"            excep_info \u003d exc.com_error.excepinfo[2]"},{"line_number":288,"context_line":"            if excep_info.find(six.u(\u0027The file exists\u0027)) !\u003d -1:"},{"line_number":289,"context_line":"                err_msg \u003d (_("},{"line_number":290,"context_line":"                    \u0027create_iscsi_target: error when creating iscsi target: \u0027"},{"line_number":291,"context_line":"                    \u0027%(tar_name)s . WMI exception: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_e52690b9","line":288,"updated":"2015-10-14 20:10:56.000000000","message":"This change is only needed for Python 3.2. Do you need Python 3.2 support? We are now targeting Python 3.4:\nhttps://wiki.openstack.org/wiki/Python3#Python_2:_Python_2.6_support_dropped.2C_Python_2.7_only\n\nOn Python 3.3 and newer, u\u0027unicode\u0027 syntax is valid.","commit_id":"9d34504ba2e0e13a0b32c1c35c8a3a279031673d"},{"author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"change_message_id":"46871d76a18ae6eb3f53ebd2fc5e0a48bbdfae21","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            self._conn_wmi.WT_Host.NewHost(HostName\u003dtarget_name)"},{"line_number":286,"context_line":"        except wmi.x_wmi as exc:"},{"line_number":287,"context_line":"            excep_info \u003d exc.com_error.excepinfo[2]"},{"line_number":288,"context_line":"            if excep_info.find(six.u(\u0027The file exists\u0027)) !\u003d -1:"},{"line_number":289,"context_line":"                err_msg \u003d (_("},{"line_number":290,"context_line":"                    \u0027create_iscsi_target: error when creating iscsi target: \u0027"},{"line_number":291,"context_line":"                    \u0027%(tar_name)s . WMI exception: \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_254fa8be","line":288,"in_reply_to":"5a2ca52d_e52690b9","updated":"2015-10-14 20:28:21.000000000","message":"Done","commit_id":"9d34504ba2e0e13a0b32c1c35c8a3a279031673d"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"ef00042586f81e194b54655afeba9ec9f420bebe","unresolved":false,"context_lines":[{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def check_min_windows_version(self, major, minor, build\u003d0):"},{"line_number":425,"context_line":"        version_str \u003d self.get_windows_version()"},{"line_number":426,"context_line":"        return list(map(int, version_str.split(\u0027.\u0027))) \u003e\u003d [major, minor, build]"},{"line_number":427,"context_line":""},{"line_number":428,"context_line":"    def get_windows_version(self):"},{"line_number":429,"context_line":"        return self._conn_cimv2.Win32_OperatingSystem()[0].Version"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_42402834","line":426,"updated":"2015-10-16 21:12:27.000000000","message":"FYI usually I replace map() with a list comprehension to get a list on Python 3. It avoids an useless copy on Python 2. But it\u0027s really a matter of taste, there is no real concern on performances here :-) I also like map() API, it avoids to use an explicit variable name and write it twice. It\u0027s also shorter.\n\nSorry for my useless comment.","commit_id":"e672a49953faa5ee05d3463d7022a957ed57256c"}]}