)]}'
{"cinder/volume/flows/api/create_volume.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d0afb49e2a71d8ffec90a33ba4638220ae274a36","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                msg \u003d _LE(\"Quota exceeded for %(s_pid)s, tried to create \""},{"line_number":573,"context_line":"                          \"%(s_size)sG volume (%(d_consumed)dG \""},{"line_number":574,"context_line":"                          \"of %(d_quota)dG already consumed)\")"},{"line_number":575,"context_line":"                LOG.exception(msg, {\u0027s_pid\u0027: context.project_id,"},{"line_number":576,"context_line":"                                    \u0027s_size\u0027: size,"},{"line_number":577,"context_line":"                                    \u0027d_consumed\u0027: _consumed(over_name),"},{"line_number":578,"context_line":"                                    \u0027d_quota\u0027: quotas[over_name]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_e0cec7b3","line":575,"updated":"2015-10-18 15:24:11.000000000","message":"Is exception the right level here?  So we\u0027ll get an exception message here, but then another exception message from the caller no?\n\nAlso, I\u0027m not sure why over-quota is an exception anyway, not even sure it\u0027s an error.  It\u0027s certainly not something that isn\u0027t expected to occur (an exception), it\u0027s completely reasonable to expect a user to attempt to create a resource when they may not have quota.","commit_id":"b34375698e2a202a62aadde933a7cbd348515e9a"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"f8989472af0c08f8ca991fc386567922c0fbeebe","unresolved":false,"context_lines":[{"line_number":572,"context_line":"                msg \u003d _LE(\"Quota exceeded for %(s_pid)s, tried to create \""},{"line_number":573,"context_line":"                          \"%(s_size)sG volume (%(d_consumed)dG \""},{"line_number":574,"context_line":"                          \"of %(d_quota)dG already consumed)\")"},{"line_number":575,"context_line":"                LOG.exception(msg, {\u0027s_pid\u0027: context.project_id,"},{"line_number":576,"context_line":"                                    \u0027s_size\u0027: size,"},{"line_number":577,"context_line":"                                    \u0027d_consumed\u0027: _consumed(over_name),"},{"line_number":578,"context_line":"                                    \u0027d_quota\u0027: quotas[over_name]})"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_571383b8","line":575,"in_reply_to":"3a29b11f_e0cec7b3","updated":"2015-10-20 00:59:58.000000000","message":"The issue is due to re-raising with new exception, due to which the traceback is lost. In such cases, isn\u0027t it always to better to log the exception? The caller (in this case, horizon) did not log/provide any details on the failure. Is the recommendation to fix horizon?\n\nI think over-quota is an error because it prevented me from creating a volume and there was no alternative tried automatically either.","commit_id":"b34375698e2a202a62aadde933a7cbd348515e9a"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"d0afb49e2a71d8ffec90a33ba4638220ae274a36","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                    consumed\u003d_consumed(over_name),"},{"line_number":583,"context_line":"                    quota\u003dquotas[over_name])"},{"line_number":584,"context_line":"            elif exceeded_vol_limit_name:"},{"line_number":585,"context_line":"                msg \u003d _LE(\"Quota %(s_name)s exceeded for %(s_pid)s, tried \""},{"line_number":586,"context_line":"                          \"to create volume (%(d_consumed)d volume(s) \""},{"line_number":587,"context_line":"                          \"already consumed).\")"},{"line_number":588,"context_line":"                LOG.exception(msg,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_e0a9e7e0","line":585,"updated":"2015-10-18 15:24:11.000000000","message":"I have the same thought/feeling as the comment above, additionaly;\n\nThis is a nit and one of those controversial notes; but this format should be of the form:\n\n# RIGHT\nmsg \u003d _(\u0027There was an error.\u0027)\nLOG.exception(msg)\nraise LocalExceptionClass(msg)","commit_id":"b34375698e2a202a62aadde933a7cbd348515e9a"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"f8989472af0c08f8ca991fc386567922c0fbeebe","unresolved":false,"context_lines":[{"line_number":582,"context_line":"                    consumed\u003d_consumed(over_name),"},{"line_number":583,"context_line":"                    quota\u003dquotas[over_name])"},{"line_number":584,"context_line":"            elif exceeded_vol_limit_name:"},{"line_number":585,"context_line":"                msg \u003d _LE(\"Quota %(s_name)s exceeded for %(s_pid)s, tried \""},{"line_number":586,"context_line":"                          \"to create volume (%(d_consumed)d volume(s) \""},{"line_number":587,"context_line":"                          \"already consumed).\")"},{"line_number":588,"context_line":"                LOG.exception(msg,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_d7279310","line":585,"in_reply_to":"3a29b11f_e0a9e7e0","updated":"2015-10-20 00:59:58.000000000","message":"sure. will use this format.","commit_id":"b34375698e2a202a62aadde933a7cbd348515e9a"}]}