)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11865,"name":"Clinton Knight","email":"cknight@netapp.com","username":"cknight"},"change_message_id":"280c99322ca2fdb874bc4cff2af898da378b3bdc","unresolved":false,"context_lines":[{"line_number":17,"context_line":"so any retry will be successful and the storage device"},{"line_number":18,"context_line":"does not contain any dead volumes."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Id93527a4cab314f27a13d8c08b772fed538d1092"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5a2ca52d_20f09566","line":20,"updated":"2015-10-16 15:32:33.000000000","message":"Bug number?","commit_id":"951bdc38ef4d7737349466bcaf12e03a9f7c6ece"}],"cinder/volume/drivers/netapp/eseries/library.py":[{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"f69438a974c18be56ddc6efcb93e5b2e5b382c6f","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                                             thin_provision\u003dthin_provision)"},{"line_number":426,"context_line":"            LOG.info(_LI(\"Created volume with \""},{"line_number":427,"context_line":"                         \"label %s.\"), eseries_volume_label)"},{"line_number":428,"context_line":"        except exception.NetAppDriverException as e:"},{"line_number":429,"context_line":"            LOG.error(_LE(\"Error creating volume. Msg - %s.\"), e)"},{"line_number":430,"context_line":"            # There was some kind failure creating the volume, make sure no"},{"line_number":431,"context_line":"            # partial flawed work exists"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_8ac66098","line":428,"updated":"2015-10-16 17:27:23.000000000","message":"you should probably keep\nwith excutils.save_and_reraise_exception():\nhere instead of the finally clause. That way the correct exception metadata will be raised.","commit_id":"8609c0eda0dfba61a755550a03515b7b858679b2"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"7d731565be93e4d341db49ad6a612346c5204296","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        except exception.NetAppDriverException as e:"},{"line_number":429,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":430,"context_line":"                LOG.error(_LE(\"Error creating volume. Msg - %s.\"), e)"},{"line_number":431,"context_line":"                # There was some kind failure creating the volume, make sure no"},{"line_number":432,"context_line":"                # partial flawed work exists"},{"line_number":433,"context_line":"                try:"},{"line_number":434,"context_line":"                    bad_vol \u003d self._get_volume(eseries_volume_label)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_fed91884","line":431,"updated":"2015-10-20 21:18:42.000000000","message":"small typo:\n\nsome kind *of* failure","commit_id":"a4bcb1e11bf48207c81e42ba3b9c96f5e13d3ef6"},{"author":{"_account_id":17950,"name":"Erik Johannes","email":"erik.johannes@netapp.com","username":"ejohannes"},"change_message_id":"465925b1355a3485566a920c5a6b227093c1f616","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        except exception.NetAppDriverException as e:"},{"line_number":429,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":430,"context_line":"                LOG.error(_LE(\"Error creating volume. Msg - %s.\"), e)"},{"line_number":431,"context_line":"                # There was some kind failure creating the volume, make sure no"},{"line_number":432,"context_line":"                # partial flawed work exists"},{"line_number":433,"context_line":"                try:"},{"line_number":434,"context_line":"                    bad_vol \u003d self._get_volume(eseries_volume_label)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_d05ce84c","line":431,"in_reply_to":"3a29b11f_fed91884","updated":"2015-11-04 18:54:01.000000000","message":"Yes, I don\u0027t think I meant that it was a kind, gentle, loving failure.  \nI will fix it when I work on that module again.","commit_id":"a4bcb1e11bf48207c81e42ba3b9c96f5e13d3ef6"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"dd08c9b50cb132803d2df807e09a188b108cc14f","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                # partial flawed work exists"},{"line_number":433,"context_line":"                try:"},{"line_number":434,"context_line":"                    bad_vol \u003d self._get_volume(eseries_volume_label)"},{"line_number":435,"context_line":"                except Exception:"},{"line_number":436,"context_line":"                    # Swallowing the exception intentionally because this is"},{"line_number":437,"context_line":"                    # emergency cleanup to make sure no intermediate volumes"},{"line_number":438,"context_line":"                    # were left. In this whole error situation, the more"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_c7af0be2","line":435,"updated":"2015-11-03 17:53:44.000000000","message":"Seems reasonable but are you sure you want to swallow ANY/ALL Exceptions in this case?  I\u0027d think you would have a specific NotFound exception here, no?","commit_id":"a4bcb1e11bf48207c81e42ba3b9c96f5e13d3ef6"},{"author":{"_account_id":17950,"name":"Erik Johannes","email":"erik.johannes@netapp.com","username":"ejohannes"},"change_message_id":"465925b1355a3485566a920c5a6b227093c1f616","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                # partial flawed work exists"},{"line_number":433,"context_line":"                try:"},{"line_number":434,"context_line":"                    bad_vol \u003d self._get_volume(eseries_volume_label)"},{"line_number":435,"context_line":"                except Exception:"},{"line_number":436,"context_line":"                    # Swallowing the exception intentionally because this is"},{"line_number":437,"context_line":"                    # emergency cleanup to make sure no intermediate volumes"},{"line_number":438,"context_line":"                    # were left. In this whole error situation, the more"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_7f2b1b95","line":435,"in_reply_to":"fa80f949_c7af0be2","updated":"2015-11-04 18:54:01.000000000","message":"Originally I had code to catch a specific not found exception, but then through feed back and realization, I changed it to just any exception.  This is just a crisis cleanup to make sure nothing partial exists, it either works or it doesn\u0027t.  The NotFound exception is what is expected/hoped for.  There is nothing really to do if some other kind of exception were to occur, we didn\u0027t get the info back for the volume existing (and we don\u0027t really expect to find it) so no cleanup operation is needed.","commit_id":"a4bcb1e11bf48207c81e42ba3b9c96f5e13d3ef6"}]}