)]}'
{"cinder/tests/unit/test_vmware_vmdk.py":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"cfe5e8ba2f0714c606ea7adb1845ed8a3e804664","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"    @ddt.data(\u00275.1\u0027, \u00275.5\u0027)"},{"line_number":1554,"context_line":"    def test_validate_vcenter_version(self, version):"},{"line_number":1555,"context_line":"        self._driver._validate_vcenter_version(ver.LooseVersion(version))"},{"line_number":1556,"context_line":""},{"line_number":1557,"context_line":"    def test_validate_vcenter_version_with_less_than_min_supported_version("},{"line_number":1558,"context_line":"            self):"},{"line_number":1559,"context_line":"        vc_version \u003d ver.LooseVersion(\u00275.0\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_8a46e621","line":1556,"updated":"2015-10-19 17:36:43.000000000","message":"Please add assertions to ensure no side effects.\n\nSimilar to old line #1555 \nassertFalse(log.error.called)","commit_id":"d4a58e4abdcdb3a5befaa32c7cb5d20d8eb4b68e"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"7806c6f3c1aa8ef12d5be1c5b1d74f09d0892c7a","unresolved":false,"context_lines":[{"line_number":1553,"context_line":"    @ddt.data(\u00275.1\u0027, \u00275.5\u0027)"},{"line_number":1554,"context_line":"    def test_validate_vcenter_version(self, version):"},{"line_number":1555,"context_line":"        self._driver._validate_vcenter_version(ver.LooseVersion(version))"},{"line_number":1556,"context_line":""},{"line_number":1557,"context_line":"    def test_validate_vcenter_version_with_less_than_min_supported_version("},{"line_number":1558,"context_line":"            self):"},{"line_number":1559,"context_line":"        vc_version \u003d ver.LooseVersion(\u00275.0\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3a29b11f_2514a342","line":1556,"in_reply_to":"3a29b11f_8a46e621","updated":"2015-10-19 17:58:12.000000000","message":"Sorry I disagree. It is not advisable to assert for logging calls or log messages. It was included previously because the method was supposed to print a deprecation warning. The logic is now changed-- either raise an exception or simply return based on vCenter version.","commit_id":"d4a58e4abdcdb3a5befaa32c7cb5d20d8eb4b68e"}],"cinder/volume/drivers/vmware/vmdk.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b0b52b81dae4cbb4364fa44520e927ad5c51dfbb","unresolved":false,"context_lines":[{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"    def _validate_vcenter_version(self, vc_version):"},{"line_number":1714,"context_line":"        if vc_version \u003c self.MIN_SUPPORTED_VC_VERSION:"},{"line_number":1715,"context_line":"            msg \u003d (\u0027Running Cinder with a VMware vCenter version less than \u0027"},{"line_number":1716,"context_line":"                   \u0027%s is not allowed.\u0027) % self.MIN_SUPPORTED_VC_VERSION"},{"line_number":1717,"context_line":"            LOG.error(msg)"},{"line_number":1718,"context_line":"            raise exceptions.VMwareDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_17704adb","line":1715,"updated":"2015-10-16 13:17:14.000000000","message":"Needs _() translation marker.","commit_id":"76b323d34eec3fd27dd06d01c508f843b7f316b3"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"e93038b7bbca3b9955ce07733966087a368de5c8","unresolved":false,"context_lines":[{"line_number":1712,"context_line":""},{"line_number":1713,"context_line":"    def _validate_vcenter_version(self, vc_version):"},{"line_number":1714,"context_line":"        if vc_version \u003c self.MIN_SUPPORTED_VC_VERSION:"},{"line_number":1715,"context_line":"            msg \u003d (\u0027Running Cinder with a VMware vCenter version less than \u0027"},{"line_number":1716,"context_line":"                   \u0027%s is not allowed.\u0027) % self.MIN_SUPPORTED_VC_VERSION"},{"line_number":1717,"context_line":"            LOG.error(msg)"},{"line_number":1718,"context_line":"            raise exceptions.VMwareDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_a69c5d6a","line":1715,"in_reply_to":"5a2ca52d_17704adb","updated":"2015-10-19 08:08:48.000000000","message":"Done","commit_id":"76b323d34eec3fd27dd06d01c508f843b7f316b3"}]}