)]}'
{"cinder/tests/test_storwize_svc.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"fb110b5c8986c21648cfda04d8982fb3d2df9a15","unresolved":false,"context_lines":[{"line_number":1238,"context_line":"        super(StorwizeSVCDriverTestCase, self).setUp()"},{"line_number":1239,"context_line":"        self.USESIM \u003d True"},{"line_number":1240,"context_line":"        if self.USESIM:"},{"line_number":1241,"context_line":"            self.driver \u003d StorwizeSVCFakeDriver("},{"line_number":1242,"context_line":"                                configuration\u003dconf.Configuration(None))"},{"line_number":1243,"context_line":"            self._def_flags \u003d {\u0027san_ip\u0027: \u0027hostname\u0027,"},{"line_number":1244,"context_line":"                               \u0027san_login\u0027: \u0027user\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F6RM%3D","line":1241,"updated":"2013-03-06 20:49:21.000000000","message":"The other drivers tests\u0027 mock out the configuration. Otherwise its annoying as hell to deal with in the tests. But it looks like u were able to get around it so its fine by me :)","commit_id":"d1fe6ee67640bb00f9fe0ebc7cef2c1da9abe6e9"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"1948267ff0fb008cb922779ffb1f1088ac05ef65","unresolved":false,"context_lines":[{"line_number":1297,"context_line":"        setattr(self.driver.configuration.local_conf, flag, value)"},{"line_number":1298,"context_line":""},{"line_number":1299,"context_line":"    def _reset_flags(self):"},{"line_number":1300,"context_line":"        self.driver.configuration.reset()"},{"line_number":1301,"context_line":"        for k, v in self._def_flags.iteritems():"},{"line_number":1302,"context_line":"            self._set_flag(k, v)"},{"line_number":1303,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F3zY%3D","line":1300,"updated":"2013-03-08 02:25:51.000000000","message":"Configuration object itself doesn\u0027t have a reset() method but Configuration.local_conf does.","commit_id":"6f8e27081500a3c16864b5700b51fa69eea6ea5a"}],"cinder/volume/drivers/storwize_svc.py":[{"author":{"_account_id":739,"name":"Michael Basnight","email":"mbasnight@gmail.com","username":"hubcap"},"change_message_id":"fb110b5c8986c21648cfda04d8982fb3d2df9a15","unresolved":false,"context_lines":[{"line_number":1256,"context_line":"        LOG.debug(_(\"Updating volume status\"))"},{"line_number":1257,"context_line":"        data \u003d {}"},{"line_number":1258,"context_line":""},{"line_number":1259,"context_line":"        data[\u0027volume_backend_name\u0027] \u003d \u0027IBM_STORWIZE_SVC\u0027  # To be overwritten"},{"line_number":1260,"context_line":"        data[\u0027vendor_name\u0027] \u003d \u0027IBM\u0027"},{"line_number":1261,"context_line":"        data[\u0027driver_version\u0027] \u003d \u00271.1\u0027"},{"line_number":1262,"context_line":"        protocol \u003d self.configuration.storwize_svc_connection_protocol"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F6RI%3D","line":1259,"updated":"2013-03-06 20:49:21.000000000","message":"You may consider using self.configuration.volume_backend_name or \u0027IBM.....\u0027 so that users can define \u003e 1 backend name for the same backend type. For instance, you can define 2 volume_types (if you want) with different volume_backend_names in the configs if you allow overriding of this. Im also slightly confused by the \"To be overwritten\" comment there but that was already there :)","commit_id":"d1fe6ee67640bb00f9fe0ebc7cef2c1da9abe6e9"}]}