)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"d07b5ba2a4714506e9ac40a06b43c9c6c7e10943","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Rename Huawei drivers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Rename Huawei18000ISCSIDriver and Huawei18000FCDriver"},{"line_number":10,"context_line":"to HuaweiVolumeISCSIDriver and HuaweiVolumeFCDriver."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":"Implements: blueprint huawei-driver-rename"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a26ad4f_7a9d1f58","line":10,"updated":"2015-10-30 11:33:26.000000000","message":"Should you have a way to deprecate the driver name instead of switching over right away?","commit_id":"f5319dd7686c961061343c4d6b3359249490d521"}],"cinder/tests/unit/test_huawei_drivers.py":[{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"894217cb914c9b7bf4fc50e72fe6228f5216e9a2","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                              \u0027pool_name\u0027: \u0027OpenStack_Pool\u0027,"},{"line_number":82,"context_line":"                              \u0027timestamp\u0027: \u00272015-07-13T11:41:00.513549\u0027,"},{"line_number":83,"context_line":"                              \u0027smartpartition\u0027: True,"},{"line_number":84,"context_line":"                              \u0027allocated_capacity_gb\u0027: 0,"},{"line_number":85,"context_line":"                              \u0027volume_backend_name\u0027: \u0027Huawei18000FCDriver\u0027,"},{"line_number":86,"context_line":"                              \u0027free_capacity_gb\u0027: 20.0,"},{"line_number":87,"context_line":"                              \u0027driver_version\u0027: \u00271.1.0\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_e207c1c7","line":84,"updated":"2015-10-23 12:02:01.000000000","message":"Should we change this to HuaweiVolumeFCDriver ?","commit_id":"066fd86631d2ffdab41d95167c02ee505d052d1c"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2d17ce806f730892c4fbea593163b3e2fdfd8845","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                              \u0027pool_name\u0027: \u0027OpenStack_Pool\u0027,"},{"line_number":82,"context_line":"                              \u0027timestamp\u0027: \u00272015-07-13T11:41:00.513549\u0027,"},{"line_number":83,"context_line":"                              \u0027smartpartition\u0027: True,"},{"line_number":84,"context_line":"                              \u0027allocated_capacity_gb\u0027: 0,"},{"line_number":85,"context_line":"                              \u0027volume_backend_name\u0027: \u0027Huawei18000FCDriver\u0027,"},{"line_number":86,"context_line":"                              \u0027free_capacity_gb\u0027: 20.0,"},{"line_number":87,"context_line":"                              \u0027driver_version\u0027: \u00271.1.0\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_ae58d231","line":84,"in_reply_to":"3a29b11f_e207c1c7","updated":"2015-10-23 13:11:45.000000000","message":"Done","commit_id":"066fd86631d2ffdab41d95167c02ee505d052d1c"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"894217cb914c9b7bf4fc50e72fe6228f5216e9a2","unresolved":false,"context_lines":[{"line_number":1360,"context_line":"    def do_setup(self):"},{"line_number":1361,"context_line":"        self.restclient \u003d Fake18000Client(configuration\u003dself.configuration)"},{"line_number":1362,"context_line":""},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"class Huawei18000ISCSIDriverTestCase(test.TestCase):"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_c2ac05a1","line":1363,"updated":"2015-10-23 12:02:01.000000000","message":"Should we also update test class name to HuaweiVolumeISCSIDriverTestCase ?","commit_id":"066fd86631d2ffdab41d95167c02ee505d052d1c"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2d17ce806f730892c4fbea593163b3e2fdfd8845","unresolved":false,"context_lines":[{"line_number":1360,"context_line":"    def do_setup(self):"},{"line_number":1361,"context_line":"        self.restclient \u003d Fake18000Client(configuration\u003dself.configuration)"},{"line_number":1362,"context_line":""},{"line_number":1363,"context_line":""},{"line_number":1364,"context_line":"class Huawei18000ISCSIDriverTestCase(test.TestCase):"},{"line_number":1365,"context_line":""},{"line_number":1366,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_4e449e48","line":1363,"in_reply_to":"3a29b11f_c2ac05a1","updated":"2015-10-23 13:11:45.000000000","message":"Done","commit_id":"066fd86631d2ffdab41d95167c02ee505d052d1c"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"894217cb914c9b7bf4fc50e72fe6228f5216e9a2","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"                                        target_list):"},{"line_number":1836,"context_line":"        return fake_fabric_mapping"},{"line_number":1837,"context_line":""},{"line_number":1838,"context_line":""},{"line_number":1839,"context_line":"class Huawei18000FCDriverTestCase(test.TestCase):"},{"line_number":1840,"context_line":""},{"line_number":1841,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_62cdf164","line":1838,"updated":"2015-10-23 12:02:01.000000000","message":"Should we also update test class name to HuaweiVolumeFCDriverTestCase ?","commit_id":"066fd86631d2ffdab41d95167c02ee505d052d1c"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2d17ce806f730892c4fbea593163b3e2fdfd8845","unresolved":false,"context_lines":[{"line_number":1835,"context_line":"                                        target_list):"},{"line_number":1836,"context_line":"        return fake_fabric_mapping"},{"line_number":1837,"context_line":""},{"line_number":1838,"context_line":""},{"line_number":1839,"context_line":"class Huawei18000FCDriverTestCase(test.TestCase):"},{"line_number":1840,"context_line":""},{"line_number":1841,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_0e4a2655","line":1838,"in_reply_to":"3a29b11f_62cdf164","updated":"2015-10-23 13:11:45.000000000","message":"Done","commit_id":"066fd86631d2ffdab41d95167c02ee505d052d1c"},{"author":{"_account_id":10485,"name":"Ankit Agrawal","email":"ankitagrawal8188@gmail.com","username":"ankitagrawal"},"change_message_id":"894217cb914c9b7bf4fc50e72fe6228f5216e9a2","unresolved":false,"context_lines":[{"line_number":2062,"context_line":"        invalid_host1 \u003d {\u0027host\u0027: \u0027ubuntu001@backend002#OpenStack_Pool\u0027,"},{"line_number":2063,"context_line":"                         \u0027capabilities\u0027:"},{"line_number":2064,"context_line":"                             {\u0027location_info\u0027: \u0027210235G7J20000000000\u0027,"},{"line_number":2065,"context_line":"                              \u0027allocated_capacity_gb\u0027: 0,"},{"line_number":2066,"context_line":"                              \u0027volume_backend_name\u0027: \u0027Huawei18000FCDriver\u0027,"},{"line_number":2067,"context_line":"                              \u0027storage_protocol\u0027: \u0027FC\u0027}}"},{"line_number":2068,"context_line":"        is_valid \u003d self.driver._check_migration_valid(invalid_host1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_42beb5ae","line":2065,"updated":"2015-10-23 12:02:01.000000000","message":"Should we change Huawei18000FCDriver to HuaweiVolumeFCDriver ? If yes there are few more occurrences below.","commit_id":"066fd86631d2ffdab41d95167c02ee505d052d1c"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2d17ce806f730892c4fbea593163b3e2fdfd8845","unresolved":false,"context_lines":[{"line_number":2062,"context_line":"        invalid_host1 \u003d {\u0027host\u0027: \u0027ubuntu001@backend002#OpenStack_Pool\u0027,"},{"line_number":2063,"context_line":"                         \u0027capabilities\u0027:"},{"line_number":2064,"context_line":"                             {\u0027location_info\u0027: \u0027210235G7J20000000000\u0027,"},{"line_number":2065,"context_line":"                              \u0027allocated_capacity_gb\u0027: 0,"},{"line_number":2066,"context_line":"                              \u0027volume_backend_name\u0027: \u0027Huawei18000FCDriver\u0027,"},{"line_number":2067,"context_line":"                              \u0027storage_protocol\u0027: \u0027FC\u0027}}"},{"line_number":2068,"context_line":"        is_valid \u003d self.driver._check_migration_valid(invalid_host1,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_ce766ea3","line":2065,"in_reply_to":"3a29b11f_42beb5ae","updated":"2015-10-23 13:11:45.000000000","message":"Done","commit_id":"066fd86631d2ffdab41d95167c02ee505d052d1c"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"bfbd74983992ee07e4cc966df0ae00c9f1310249","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                              \u0027pool_name\u0027: \u0027OpenStack_Pool\u0027,"},{"line_number":121,"context_line":"                              \u0027timestamp\u0027: \u00272015-07-13T11:41:00.513549\u0027,"},{"line_number":122,"context_line":"                              \u0027smartpartition\u0027: True,"},{"line_number":123,"context_line":"                              \u0027allocated_capacity_gb\u0027: 0,"},{"line_number":124,"context_line":"                              \u0027volume_backend_name\u0027: \u0027Huawei18000FCDriver\u0027,"},{"line_number":125,"context_line":"                              \u0027free_capacity_gb\u0027: 20.0,"},{"line_number":126,"context_line":"                              \u0027driver_version\u0027: \u00271.1.0\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_73ed9aee","line":123,"updated":"2015-11-04 17:00:30.000000000","message":"Do you plan to change all these test classes? Seems like if you are renaming it, it would be best to change the test stuff as well.","commit_id":"555e630ee4d79d9e87f2b9cd55b99114e63d57f7"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"bfbd74983992ee07e4cc966df0ae00c9f1310249","unresolved":false,"context_lines":[{"line_number":1484,"context_line":"        self.xml_file_path \u003d self.configuration.cinder_huawei_conf_file"},{"line_number":1485,"context_line":""},{"line_number":1486,"context_line":"    def do_setup(self):"},{"line_number":1487,"context_line":"        self.restclient \u003d Fake18000Client(configuration\u003dself.configuration)"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":""},{"line_number":1490,"context_line":"class Fake18000FCStorage(huawei_driver.HuaweiVolumeFCDriver):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_13bbeee6","line":1487,"updated":"2015-11-04 17:00:30.000000000","message":"same","commit_id":"555e630ee4d79d9e87f2b9cd55b99114e63d57f7"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"bfbd74983992ee07e4cc966df0ae00c9f1310249","unresolved":false,"context_lines":[{"line_number":1501,"context_line":""},{"line_number":1502,"context_line":"class Huawei18000ISCSIDriverTestCase(test.TestCase):"},{"line_number":1503,"context_line":""},{"line_number":1504,"context_line":"    def setUp(self):"},{"line_number":1505,"context_line":"        super(Huawei18000ISCSIDriverTestCase, self).setUp()"},{"line_number":1506,"context_line":"        self.tmp_dir \u003d tempfile.mkdtemp()"},{"line_number":1507,"context_line":"        self.fake_conf_file \u003d self.tmp_dir + \u0027/cinder_huawei_conf.xml\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_f3b74af3","line":1504,"updated":"2015-11-04 17:00:30.000000000","message":"same","commit_id":"555e630ee4d79d9e87f2b9cd55b99114e63d57f7"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"bfbd74983992ee07e4cc966df0ae00c9f1310249","unresolved":false,"context_lines":[{"line_number":1512,"context_line":"        self.configuration.cinder_huawei_conf_file \u003d self.fake_conf_file"},{"line_number":1513,"context_line":"        self.xml_file_path \u003d self.configuration.cinder_huawei_conf_file"},{"line_number":1514,"context_line":"        self.configuration.hypermetro_devices \u003d hypermetro_devices"},{"line_number":1515,"context_line":"        self.stubs.Set(time, \u0027sleep\u0027, Fake_sleep)"},{"line_number":1516,"context_line":"        driver \u003d Fake18000ISCSIStorage(configuration\u003dself.configuration)"},{"line_number":1517,"context_line":"        self.driver \u003d driver"},{"line_number":1518,"context_line":"        self.driver.do_setup()"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa80f949_93cfde7e","line":1515,"updated":"2015-11-04 17:00:30.000000000","message":"same","commit_id":"555e630ee4d79d9e87f2b9cd55b99114e63d57f7"}],"cinder/tests/unit/test_huawei_drivers_compatibility.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"442f29062ad7d1d05ff0facde817e4b3d68a501b","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def test_huawei_driver_iscsi_old(self):"},{"line_number":49,"context_line":"        self._load_driver("},{"line_number":50,"context_line":"            \u0027cinder.volume.drivers.huawei.huawei_driver.Huawei18000ISCSIDriver\u0027)"},{"line_number":51,"context_line":"        self.assertEqual(self._driver_module_name(), HUAWEI_ISCSI_MODULE)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_huawei_driver_iscsi_new(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_f08004f9","line":50,"updated":"2015-10-22 17:37:58.000000000","message":"pep8 is failing on this line so recheck will not fix that.  ./cinder/tests/unit/test_huawei_drivers_compatibility.py:50:80: E501 line too long (80 \u003e 79 characters)","commit_id":"06e02555c93974cde6214b58c56777bb9314f63f"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"0c6da8e72a8e34f5286d28cbaa921014c7a62c70","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_huawei_driver_iscsi_old(self):"},{"line_number":49,"context_line":"        self._load_driver("},{"line_number":50,"context_line":"            \u0027cinder.volume.drivers.huawei.huawei_driver.\u0027"},{"line_number":51,"context_line":"            \u0027Huawei18000ISCSIDriver\u0027)"},{"line_number":52,"context_line":"        self.assertEqual(self._driver_module_name(), HUAWEI_ISCSI_MODULE)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_huawei_driver_iscsi_new(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_12273dcb","line":51,"updated":"2015-11-05 15:46:29.000000000","message":"Is this staying?","commit_id":"91beb1d4520fc7c1a218c10598dd21bfb8a6b411"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"fb1fc8c3773ddf7b42398d1c02ef17822e0a46bf","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    def test_huawei_driver_iscsi_old(self):"},{"line_number":49,"context_line":"        self._load_driver("},{"line_number":50,"context_line":"            \u0027cinder.volume.drivers.huawei.huawei_driver.\u0027"},{"line_number":51,"context_line":"            \u0027Huawei18000ISCSIDriver\u0027)"},{"line_number":52,"context_line":"        self.assertEqual(self._driver_module_name(), HUAWEI_ISCSI_MODULE)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_huawei_driver_iscsi_new(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_69eb2679","line":51,"in_reply_to":"fa80f949_12273dcb","updated":"2015-11-06 04:46:10.000000000","message":"Yes, this is to test the *old* driver patch. We should leave some time to let user still use old patch, and map it to the new patch.","commit_id":"91beb1d4520fc7c1a218c10598dd21bfb8a6b411"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"0c6da8e72a8e34f5286d28cbaa921014c7a62c70","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_huawei_driver_fc_old(self):"},{"line_number":59,"context_line":"        self._load_driver("},{"line_number":60,"context_line":"            \u0027cinder.volume.drivers.huawei.huawei_driver.Huawei18000FCDriver\u0027)"},{"line_number":61,"context_line":"        self.assertEqual(self._driver_module_name(), HUAWEI_FC_MODULE)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    def test_huawei_driver_fc_new(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa80f949_d230d503","line":60,"updated":"2015-11-05 15:46:29.000000000","message":"Is this staying?","commit_id":"91beb1d4520fc7c1a218c10598dd21bfb8a6b411"}],"cinder/volume/drivers/huawei/huawei_driver.py":[{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"a7612b891b89e7bd29a1104d2fe3345fcd065d83","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                    if constants.MIGRATION_COMPLETE \u003d\u003d item[\u0027RUNNINGSTATUS\u0027]:"},{"line_number":189,"context_line":"                        return True"},{"line_number":190,"context_line":"                    if constants.MIGRATION_FAULT \u003d\u003d item[\u0027RUNNINGSTATUS\u0027]:"},{"line_number":191,"context_line":"                        err_msg \u003d _(\u0027Lun migration error.\u0027)"},{"line_number":192,"context_line":"                        LOG.error(err_msg)"},{"line_number":193,"context_line":"                        raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":194,"context_line":"        if not found_migration_task:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_ba5a4929","line":191,"updated":"2015-10-23 14:08:39.000000000","message":"To be consistent, it will be better to replace \u0027 with \".\n\u0027Lun migration error\u0027 -\u003e \"Lun migration error\"","commit_id":"72973b77cf55ca3140dcf699ac47908f39d2fba7"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"3849329a6805b9ceca6e0ea3568134c5d00fa128","unresolved":false,"context_lines":[{"line_number":188,"context_line":"                    if constants.MIGRATION_COMPLETE \u003d\u003d item[\u0027RUNNINGSTATUS\u0027]:"},{"line_number":189,"context_line":"                        return True"},{"line_number":190,"context_line":"                    if constants.MIGRATION_FAULT \u003d\u003d item[\u0027RUNNINGSTATUS\u0027]:"},{"line_number":191,"context_line":"                        err_msg \u003d _(\u0027Lun migration error.\u0027)"},{"line_number":192,"context_line":"                        LOG.error(err_msg)"},{"line_number":193,"context_line":"                        raise exception.VolumeBackendAPIException(data\u003derr_msg)"},{"line_number":194,"context_line":"        if not found_migration_task:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_5bbafb6f","line":191,"in_reply_to":"3a29b11f_ba5a4929","updated":"2015-10-26 01:02:00.000000000","message":"Done","commit_id":"72973b77cf55ca3140dcf699ac47908f39d2fba7"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"37076c1a742f1fcf83fe6ebb4490387a0c5aff57","unresolved":false,"context_lines":[{"line_number":841,"context_line":""},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"class HuaweiVolumeISCSIDriver(HuaweiBaseDriver, driver.ISCSIDriver):"},{"line_number":844,"context_line":"    \"\"\"ISCSI driver for Huawei OceanStor 18000 storage arrays."},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    Version history:"},{"line_number":847,"context_line":"        1.0.0 - Initial driver"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_26770e04","line":844,"updated":"2015-11-03 11:45:25.000000000","message":"The class name is \"HuaweiVolumeISCSIDriver\", but the comments is \"Huawei OceanStor 18000\", not only 18000.","commit_id":"f5319dd7686c961061343c4d6b3359249490d521"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2bc8824bc280cffb0c021f4023696845e3ecdaeb","unresolved":false,"context_lines":[{"line_number":841,"context_line":""},{"line_number":842,"context_line":""},{"line_number":843,"context_line":"class HuaweiVolumeISCSIDriver(HuaweiBaseDriver, driver.ISCSIDriver):"},{"line_number":844,"context_line":"    \"\"\"ISCSI driver for Huawei OceanStor 18000 storage arrays."},{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    Version history:"},{"line_number":847,"context_line":"        1.0.0 - Initial driver"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_88eee789","line":844,"in_reply_to":"fa80f949_26770e04","updated":"2015-11-04 02:17:34.000000000","message":"Done","commit_id":"f5319dd7686c961061343c4d6b3359249490d521"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"37076c1a742f1fcf83fe6ebb4490387a0c5aff57","unresolved":false,"context_lines":[{"line_number":845,"context_line":""},{"line_number":846,"context_line":"    Version history:"},{"line_number":847,"context_line":"        1.0.0 - Initial driver"},{"line_number":848,"context_line":"        1.1.0 - Provide Huawei OceanStor 18000 storage volume driver"},{"line_number":849,"context_line":"        1.1.1 - Code refactor"},{"line_number":850,"context_line":"                CHAP support"},{"line_number":851,"context_line":"                Multiple pools support"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_264e2ec2","line":848,"updated":"2015-11-03 11:45:25.000000000","message":"The same as above.","commit_id":"f5319dd7686c961061343c4d6b3359249490d521"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"37076c1a742f1fcf83fe6ebb4490387a0c5aff57","unresolved":false,"context_lines":[{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"class HuaweiVolumeFCDriver(HuaweiBaseDriver, driver.FibreChannelDriver):"},{"line_number":1042,"context_line":"    \"\"\"FC driver for Huawei OceanStor 18000 storage arrays."},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    Version history:"},{"line_number":1045,"context_line":"        1.0.0 - Initial driver"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_e65fc673","line":1042,"updated":"2015-11-03 11:45:25.000000000","message":"The same as above.","commit_id":"f5319dd7686c961061343c4d6b3359249490d521"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2bc8824bc280cffb0c021f4023696845e3ecdaeb","unresolved":false,"context_lines":[{"line_number":1039,"context_line":""},{"line_number":1040,"context_line":""},{"line_number":1041,"context_line":"class HuaweiVolumeFCDriver(HuaweiBaseDriver, driver.FibreChannelDriver):"},{"line_number":1042,"context_line":"    \"\"\"FC driver for Huawei OceanStor 18000 storage arrays."},{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    Version history:"},{"line_number":1045,"context_line":"        1.0.0 - Initial driver"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_0803d743","line":1042,"in_reply_to":"fa80f949_e65fc673","updated":"2015-11-04 02:17:34.000000000","message":"Done","commit_id":"f5319dd7686c961061343c4d6b3359249490d521"},{"author":{"_account_id":16883,"name":"huyang","email":"huyang1@huawei.com","username":"huyang"},"change_message_id":"37076c1a742f1fcf83fe6ebb4490387a0c5aff57","unresolved":false,"context_lines":[{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    Version history:"},{"line_number":1045,"context_line":"        1.0.0 - Initial driver"},{"line_number":1046,"context_line":"        1.1.0 - Provide Huawei OceanStor 18000 storage volume driver"},{"line_number":1047,"context_line":"        1.1.1 - Code refactor"},{"line_number":1048,"context_line":"                Multiple pools support"},{"line_number":1049,"context_line":"                SmartX support"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_e6c6e615","line":1046,"updated":"2015-11-03 11:45:25.000000000","message":"The same as above.","commit_id":"f5319dd7686c961061343c4d6b3359249490d521"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"2bc8824bc280cffb0c021f4023696845e3ecdaeb","unresolved":false,"context_lines":[{"line_number":1043,"context_line":""},{"line_number":1044,"context_line":"    Version history:"},{"line_number":1045,"context_line":"        1.0.0 - Initial driver"},{"line_number":1046,"context_line":"        1.1.0 - Provide Huawei OceanStor 18000 storage volume driver"},{"line_number":1047,"context_line":"        1.1.1 - Code refactor"},{"line_number":1048,"context_line":"                Multiple pools support"},{"line_number":1049,"context_line":"                SmartX support"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa80f949_48b6bf8b","line":1046,"in_reply_to":"fa80f949_e6c6e615","updated":"2015-11-04 02:17:34.000000000","message":"This is the version history and should leave it on, thanks.","commit_id":"f5319dd7686c961061343c4d6b3359249490d521"}],"cinder/volume/manager.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b2b81c5629958fda1792e19d5f90703045331ab2","unresolved":false,"context_lines":[{"line_number":112,"context_line":"CONF.register_opts(volume_manager_opts)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"MAPPING \u003d {"},{"line_number":115,"context_line":"    \u0027cinder.volume.drivers.huawei.huawei_driver.Huawei18000ISCSIDriver\u0027:"},{"line_number":116,"context_line":"    \u0027cinder.volume.drivers.huawei.huawei_driver.HuaweiISCSIDriver\u0027,"},{"line_number":117,"context_line":"    \u0027cinder.volume.drivers.huawei.huawei_driver.Huawei18000FCDriver\u0027:"},{"line_number":118,"context_line":"    \u0027cinder.volume.drivers.huawei.huawei_driver.HuaweiFCDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_36baccc1","line":115,"updated":"2015-11-30 19:20:40.000000000","message":"Don\u0027t you need the old mapping name to work as well with the new location/name? Otherwise this might break existing deployments upgrading to Mitaka.\n\ncinder.volume.drivers.huawei.huawei_18000.Huawei18000ISCSIDriver","commit_id":"e8d260ca7402193091ca5b050e0236ffe50c8fe1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2295c3a521c62347a3350029000048e2229c9bbf","unresolved":false,"context_lines":[{"line_number":112,"context_line":"CONF.register_opts(volume_manager_opts)"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"MAPPING \u003d {"},{"line_number":115,"context_line":"    \u0027cinder.volume.drivers.huawei.huawei_driver.Huawei18000ISCSIDriver\u0027:"},{"line_number":116,"context_line":"    \u0027cinder.volume.drivers.huawei.huawei_driver.HuaweiISCSIDriver\u0027,"},{"line_number":117,"context_line":"    \u0027cinder.volume.drivers.huawei.huawei_driver.Huawei18000FCDriver\u0027:"},{"line_number":118,"context_line":"    \u0027cinder.volume.drivers.huawei.huawei_driver.HuaweiFCDriver\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a8ffd7b_01b1e800","line":115,"in_reply_to":"9a8ffd7b_36baccc1","updated":"2015-12-03 03:35:19.000000000","message":"It looks like this driver was renamed in every release:).  I think it is fine but I do agree with Walt that the old mapping name should work as well.\n\nhttps://github.com/openstack/cinder/blob/stable/kilo/cinder/volume/manager.py#L111\n\nhttps://github.com/openstack/cinder/blob/stable/liberty/cinder/volume/manager.py#L115","commit_id":"e8d260ca7402193091ca5b050e0236ffe50c8fe1"}]}