)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1939cc096786a9e3a2b0811dc4f89e45db490a71","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This fix makes the driver use the \u0027default\u0027 group only if"},{"line_number":15,"context_line":"configured in the cinder.conf file. It also throws an error when"},{"line_number":16,"context_line":"initiator group is given without any initiators."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I417688cf632baa727e5aa339c8d362761a38dcc8"},{"line_number":19,"context_line":"Closes-Bug: #1508548"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a29b11f_d9117353","line":17,"updated":"2015-10-22 18:50:53.000000000","message":"I think this should have a DocImpact tag.","commit_id":"c305b3d6ca2d342e1bc2b31c25c4d1b40e4511bb"}],"cinder/volume/drivers/zfssa/zfssaiscsi.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"9e73929a9a32e1ebdece3e3403bc6d701cf0f199","unresolved":false,"context_lines":[{"line_number":700,"context_line":"                init_groups.append(\u0027default\u0027)"},{"line_number":701,"context_line":"            else:"},{"line_number":702,"context_line":"                exception_msg \u003d (_(\u0027Failed to find iSCSI initiator group \u0027"},{"line_number":703,"context_line":"                                   \u0027containing %(initiator)s\u0027)"},{"line_number":704,"context_line":"                                 % {\u0027initiator\u0027: connector[\u0027initiator\u0027]})"},{"line_number":705,"context_line":"                LOG.error(exception_msg)"},{"line_number":706,"context_line":"                raise exception.VolumeBackendAPIException(data\u003dexception_msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_1add6714","line":703,"updated":"2015-10-27 21:23:14.000000000","message":"\".\" at EOL","commit_id":"3b9535496ac8637f6a8f3011f6907b51677a31e3"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"e122d09b85dc7bf9e4c704cbdf01770ccbe6b43f","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            LOG.warning(_LW(\u0027zfssa_initiator_config not found. \u0027"},{"line_number":179,"context_line":"                            \u0027Using deprecated configuration options.\u0027))"},{"line_number":180,"context_line":"            if (lcfg.zfssa_initiator \u003d\u003d \u0027\u0027 and"},{"line_number":181,"context_line":"                (lcfg.zfssa_initiator_group !\u003d \u0027\u0027 and"},{"line_number":182,"context_line":"                 lcfg.zfssa_initiator_group !\u003d \u0027default\u0027)):"},{"line_number":183,"context_line":"                LOG.error(_LE(\u0027zfssa_initiator cannot be empty when \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_bca8618d","line":180,"updated":"2015-11-02 16:36:34.000000000","message":"if not lcfg.zfssa_initiator and (not lcfg.zfssa_initiator_group and lcfg.zfssa_initiator_group !\u003d \u0027default\u0027):\n\nNo need for the \u003d\u003d \u0027\u0027","commit_id":"0c6286ea4ed3ec07ff3e5707680687ecfe5e3b0d"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"b871fce45c8e317fb03ad1bfb6830aabd6f05651","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        else:"},{"line_number":178,"context_line":"            LOG.warning(_LW(\u0027zfssa_initiator_config not found. \u0027"},{"line_number":179,"context_line":"                            \u0027Using deprecated configuration options.\u0027))"},{"line_number":180,"context_line":"            if (lcfg.zfssa_initiator \u003d\u003d \u0027\u0027 and"},{"line_number":181,"context_line":"                (lcfg.zfssa_initiator_group !\u003d \u0027\u0027 and"},{"line_number":182,"context_line":"                 lcfg.zfssa_initiator_group !\u003d \u0027default\u0027)):"},{"line_number":183,"context_line":"                LOG.error(_LE(\u0027zfssa_initiator cannot be empty when \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"5a5ae5dd_9e07ba1b","line":180,"in_reply_to":"1a26ad4f_bca8618d","updated":"2016-02-04 22:24:30.000000000","message":"I agree with alex this can be cleaned up.","commit_id":"0c6286ea4ed3ec07ff3e5707680687ecfe5e3b0d"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"e122d09b85dc7bf9e4c704cbdf01770ccbe6b43f","unresolved":false,"context_lines":[{"line_number":695,"context_line":"        lcfg \u003d self.configuration"},{"line_number":696,"context_line":"        init_groups \u003d self.zfssa.get_initiator_initiatorgroup("},{"line_number":697,"context_line":"            connector[\u0027initiator\u0027])"},{"line_number":698,"context_line":"        if init_groups \u003d\u003d []:"},{"line_number":699,"context_line":"            if (lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027 or"},{"line_number":700,"context_line":"                    lcfg.zfssa_initiator_group \u003d\u003d \u0027\u0027):"},{"line_number":701,"context_line":"                init_groups.append(\u0027default\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_3c745134","line":698,"updated":"2015-11-02 16:36:34.000000000","message":"if not init_groups:","commit_id":"0c6286ea4ed3ec07ff3e5707680687ecfe5e3b0d"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"e122d09b85dc7bf9e4c704cbdf01770ccbe6b43f","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            connector[\u0027initiator\u0027])"},{"line_number":698,"context_line":"        if init_groups \u003d\u003d []:"},{"line_number":699,"context_line":"            if (lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027 or"},{"line_number":700,"context_line":"                    lcfg.zfssa_initiator_group \u003d\u003d \u0027\u0027):"},{"line_number":701,"context_line":"                init_groups.append(\u0027default\u0027)"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                exception_msg \u003d (_(\u0027Failed to find iSCSI initiator group \u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_fc901945","line":700,"updated":"2015-11-02 16:36:34.000000000","message":"or not lcfg.zfssa_initiator_group","commit_id":"0c6286ea4ed3ec07ff3e5707680687ecfe5e3b0d"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"0c2b72cfccef497ddb1211590ec32443f59bb93f","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            connector[\u0027initiator\u0027])"},{"line_number":698,"context_line":"        if not init_groups:"},{"line_number":699,"context_line":"            if (lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027 or"},{"line_number":700,"context_line":"                    not lcfg.zfssa_initiator_group):"},{"line_number":701,"context_line":"                init_groups.append(\u0027default\u0027)"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                exception_msg \u003d (_(\u0027Failed to find iSCSI initiator group \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_1bf4bc58","line":700,"updated":"2016-02-08 20:35:15.000000000","message":"Not sure this is something that we want. To default to \u0027default\u0027 is not a good idea. It\u0027s better to be explicit.","commit_id":"57882bf1d5ada7ba0e5584a67c2dd6b1bf7649f5"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"c536168cf71b4e8f35a4fe5b9fbe0d4f4a95a040","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            connector[\u0027initiator\u0027])"},{"line_number":698,"context_line":"        if not init_groups:"},{"line_number":699,"context_line":"            if (lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027 or"},{"line_number":700,"context_line":"                    not lcfg.zfssa_initiator_group):"},{"line_number":701,"context_line":"                init_groups.append(\u0027default\u0027)"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                exception_msg \u003d (_(\u0027Failed to find iSCSI initiator group \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_ee4f9c68","line":700,"in_reply_to":"5a5ae5dd_1b691cf9","updated":"2016-02-08 20:42:39.000000000","message":"So why this statement is here \u0027not lcfg.zfssa_initiator_group\u0027? IMO if there is no groups it would default to \u0027default\u0027 (line 701)","commit_id":"57882bf1d5ada7ba0e5584a67c2dd6b1bf7649f5"},{"author":{"_account_id":13013,"name":"abhiram moturi","email":"abhiram.moturi@oracle.com","username":"amoturi"},"change_message_id":"92f7197b9ff9a0a7fd5ccb5b7212005fb51824ee","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            connector[\u0027initiator\u0027])"},{"line_number":698,"context_line":"        if not init_groups:"},{"line_number":699,"context_line":"            if (lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027 or"},{"line_number":700,"context_line":"                    not lcfg.zfssa_initiator_group):"},{"line_number":701,"context_line":"                init_groups.append(\u0027default\u0027)"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                exception_msg \u003d (_(\u0027Failed to find iSCSI initiator group \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_1b691cf9","line":700,"in_reply_to":"5a5ae5dd_1bf4bc58","updated":"2016-02-08 20:37:21.000000000","message":"we don\u0027t default to \u0027default\u0027. We also check if the initiator_group is \u0027default\u0027 in the config file. see above line.","commit_id":"57882bf1d5ada7ba0e5584a67c2dd6b1bf7649f5"},{"author":{"_account_id":13013,"name":"abhiram moturi","email":"abhiram.moturi@oracle.com","username":"amoturi"},"change_message_id":"2045689e51290565b394d4c24b94521a0bfe5872","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            connector[\u0027initiator\u0027])"},{"line_number":698,"context_line":"        if not init_groups:"},{"line_number":699,"context_line":"            if (lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027 or"},{"line_number":700,"context_line":"                    not lcfg.zfssa_initiator_group):"},{"line_number":701,"context_line":"                init_groups.append(\u0027default\u0027)"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                exception_msg \u003d (_(\u0027Failed to find iSCSI initiator group \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_ee60fca6","line":700,"in_reply_to":"5a5ae5dd_ee4f9c68","updated":"2016-02-08 20:50:18.000000000","message":"even during do_setup() if lcfg.zfssa_initiator_group is None, we use \u0027default\u0027. I wanted volume attach to work in that case as well. (when zfssa_initiator_group is not given and we use \u0027default\u0027)","commit_id":"57882bf1d5ada7ba0e5584a67c2dd6b1bf7649f5"},{"author":{"_account_id":11509,"name":"Juan Zuluaga","email":"juan.c.zuluaga@oracle.com","username":"juzuluag"},"change_message_id":"b318bd93f97ffd135cc5013b69babd6259c53503","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            connector[\u0027initiator\u0027])"},{"line_number":698,"context_line":"        if not init_groups:"},{"line_number":699,"context_line":"            if (lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027 or"},{"line_number":700,"context_line":"                    not lcfg.zfssa_initiator_group):"},{"line_number":701,"context_line":"                init_groups.append(\u0027default\u0027)"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                exception_msg \u003d (_(\u0027Failed to find iSCSI initiator group \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_eeb8fcc9","line":700,"in_reply_to":"5a5ae5dd_ee60fca6","updated":"2016-02-08 20:56:27.000000000","message":"We shouldn\u0027t use \u0027default\u0027 when it\u0027s not explicitly specified on cinder.conf. It\u0027s better to failed (raise an exception and log it)  when there is no initgroup specified at all. The side effects of having default are not good at all.","commit_id":"57882bf1d5ada7ba0e5584a67c2dd6b1bf7649f5"},{"author":{"_account_id":13013,"name":"abhiram moturi","email":"abhiram.moturi@oracle.com","username":"amoturi"},"change_message_id":"6d72fd892abe575c52557405485666901d471954","unresolved":false,"context_lines":[{"line_number":697,"context_line":"            connector[\u0027initiator\u0027])"},{"line_number":698,"context_line":"        if not init_groups:"},{"line_number":699,"context_line":"            if (lcfg.zfssa_initiator_group \u003d\u003d \u0027default\u0027 or"},{"line_number":700,"context_line":"                    not lcfg.zfssa_initiator_group):"},{"line_number":701,"context_line":"                init_groups.append(\u0027default\u0027)"},{"line_number":702,"context_line":"            else:"},{"line_number":703,"context_line":"                exception_msg \u003d (_(\u0027Failed to find iSCSI initiator group \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a5ae5dd_ae420466","line":700,"in_reply_to":"5a5ae5dd_eeb8fcc9","updated":"2016-02-08 21:03:13.000000000","message":"Done","commit_id":"57882bf1d5ada7ba0e5584a67c2dd6b1bf7649f5"}]}