)]}'
{"cinder/tests/unit/api/v2/test_volumes.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"bc4e2d7c2e59aa6dc0e34cb874b05b38c54d7b38","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"        \"\"\"Test to get a volume with an alpha-numeric display name.\"\"\""},{"line_number":1325,"context_line":"        self._test_get_volumes_by_name(get_all, \u0027Volume-573108026\u0027)"},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"    @mock.patch(\u0027cinder.volume.api.API.get_all\u0027)"},{"line_number":1328,"context_line":"    def test_get_volumes_filter_with_double_quoted_string(self, get_all):"},{"line_number":1329,"context_line":"        \"\"\"Test to get a volume with a double-quoted display name.\"\"\""},{"line_number":1330,"context_line":"        self._test_get_volumes_by_name(get_all, \u0027\"Volume-573108026\"\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_5c514861","line":1327,"updated":"2015-10-30 08:09:41.000000000","message":"Nit: all of these mock.patch decorators could be replaced with a single `with mock.patch(...) as mock_get_all:` from within _test_get_volumes_by_name to eliminate the repeated decorators.","commit_id":"137cc38f2f51d40e8e44510f0054b9d93715b3ac"}],"cinder/volume/api.py":[{"author":{"_account_id":10439,"name":"Xi Yang","email":"yang.xi@99cloud.net","username":"phenom"},"change_message_id":"3f12d346429db4da684d556f4b07f79b37336539","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"        return self.volume_rpcapi.list_replication_targets(ctxt, volume)"},{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"    def _starts_and_ends_with(self, main_str, check_str):"},{"line_number":1735,"context_line":"        return main_str.startswith(check_str) and main_str.endswith(check_str)"},{"line_number":1736,"context_line":""},{"line_number":1737,"context_line":"    def _handle_quotes(self, display_name):"},{"line_number":1738,"context_line":"        \"\"\"Adds extra quotes to a quoted display_name. \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_7dd90b83","line":1735,"updated":"2015-10-23 14:37:55.000000000","message":"What if a user creates a volume whose names is like \"vol001\u0027 or \u0027vol001\"? Could we consider this situation?","commit_id":"32227610405ff50a4a8b88c3515ff6fa5b3ccc05"},{"author":{"_account_id":15225,"name":"Deepti Ramakrishna","email":"deepti.ramakrishna@intel.com","username":"dramakri"},"change_message_id":"8ab43710260fd3b7f4430f0792d092f8c7557551","unresolved":false,"context_lines":[{"line_number":1732,"context_line":"        return self.volume_rpcapi.list_replication_targets(ctxt, volume)"},{"line_number":1733,"context_line":""},{"line_number":1734,"context_line":"    def _starts_and_ends_with(self, main_str, check_str):"},{"line_number":1735,"context_line":"        return main_str.startswith(check_str) and main_str.endswith(check_str)"},{"line_number":1736,"context_line":""},{"line_number":1737,"context_line":"    def _handle_quotes(self, display_name):"},{"line_number":1738,"context_line":"        \"\"\"Adds extra quotes to a quoted display_name. \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_b6afc693","line":1735,"in_reply_to":"3a29b11f_7dd90b83","updated":"2015-10-27 07:09:37.000000000","message":"The latest patch should handle even these kind of names. In fact, I added a test for exactly this case.","commit_id":"32227610405ff50a4a8b88c3515ff6fa5b3ccc05"}]}