)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16258,"name":"nikesh","email":"nike.niec@gmail.com","username":"nikem"},"change_message_id":"4252aa7826a5fcb6c166bdee0f054e7005a283d2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Patzig \u003ctom.patzig@sap.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-04 13:30:41 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Execute mount.nfs check with absolute path /sbin/mount.nfs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the existence of \u0027mount.nfs\u0027 is checked by running the relative binary"},{"line_number":10,"context_line":"mount.nfs with a non-root user,in this case cinder."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa80f949_28f7a2d4","line":7,"updated":"2015-11-04 15:30:23.000000000","message":"The first line should be limited to 50 characters\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"474cf6c9ca44eb41e04b931771268a14a3ef4848"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cfa06f6ea22f51b11a7824f5bfb71c0144d5f18a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tom Patzig \u003ctom.patzig@sap.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-04 13:30:41 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Execute mount.nfs check with absolute path /sbin/mount.nfs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently the existence of \u0027mount.nfs\u0027 is checked by running the relative binary"},{"line_number":10,"context_line":"mount.nfs with a non-root user,in this case cinder."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa80f949_714caf70","line":7,"in_reply_to":"fa80f949_28f7a2d4","updated":"2015-11-04 18:49:34.000000000","message":"We should follow the guidelines but I won\u0027t block patch it this case","commit_id":"474cf6c9ca44eb41e04b931771268a14a3ef4848"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"fb61fdbba8c9c2437cce9b2e8a769dcf01c9e270","unresolved":false,"context_lines":[{"line_number":16,"context_line":"/sbin in their PATH to search for executables."},{"line_number":17,"context_line":"The change runs the mount.nfs check by using the absolute binary path /sbin/mount.nfs."},{"line_number":18,"context_line":"This seems to be common for most distributions (SUSE, RedHat, CentOS, Ubuntu, Debian)."},{"line_number":19,"context_line":"The check can still be executed as non privileged user, by not relying on correct PATH"},{"line_number":20,"context_line":"variable and using the absolute path."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I3c1ecfdadd9ea492d58d69cbdf33045b002668c7"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"fa80f949_516bbc1e","line":19,"updated":"2015-11-04 12:47:16.000000000","message":"Please have a look [1]: Subsequent lines should be wrapped at 72 characters.\n\n[1]: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"474cf6c9ca44eb41e04b931771268a14a3ef4848"}],"cinder/volume/drivers/nfs.py":[{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2e3a19eb0aa2cbffbeae9337c852d9ea6e8ce3ae","unresolved":false,"context_lines":[{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self.shares \u003d {}  # address : options"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Check if /sbin/mount.nfs is installed on this system; note that we don\u0027t"},{"line_number":147,"context_line":"        # need to be root, to see if the package is installed."},{"line_number":148,"context_line":"        # We rely on the absolute path /sbin/mount.nfs, because this seems to be"},{"line_number":149,"context_line":"        # common on most distributions (SUSE, RedHat, CentOS, Ubuntu, Debian)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_0a7ad3f1","line":146,"updated":"2015-11-04 16:00:17.000000000","message":"This line need to be wrapped (79 chars)","commit_id":"474cf6c9ca44eb41e04b931771268a14a3ef4848"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2e3a19eb0aa2cbffbeae9337c852d9ea6e8ce3ae","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        # Check if /sbin/mount.nfs is installed on this system; note that we don\u0027t"},{"line_number":147,"context_line":"        # need to be root, to see if the package is installed."},{"line_number":148,"context_line":"        # We rely on the absolute path /sbin/mount.nfs, because this seems to be"},{"line_number":149,"context_line":"        # common on most distributions (SUSE, RedHat, CentOS, Ubuntu, Debian)"},{"line_number":150,"context_line":"        # and it does not depend on correct PATH of the executing user, when trying"},{"line_number":151,"context_line":"        # to find the relative binary."}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_2a7d57e7","line":148,"updated":"2015-11-04 16:00:17.000000000","message":"This line need to be wrapped (79 chars)","commit_id":"474cf6c9ca44eb41e04b931771268a14a3ef4848"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"2e3a19eb0aa2cbffbeae9337c852d9ea6e8ce3ae","unresolved":false,"context_lines":[{"line_number":147,"context_line":"        # need to be root, to see if the package is installed."},{"line_number":148,"context_line":"        # We rely on the absolute path /sbin/mount.nfs, because this seems to be"},{"line_number":149,"context_line":"        # common on most distributions (SUSE, RedHat, CentOS, Ubuntu, Debian)"},{"line_number":150,"context_line":"        # and it does not depend on correct PATH of the executing user, when trying"},{"line_number":151,"context_line":"        # to find the relative binary."},{"line_number":152,"context_line":"        package \u003d \u0027/sbin/mount.nfs\u0027"},{"line_number":153,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_aa694727","line":150,"updated":"2015-11-04 16:00:17.000000000","message":"This line need to be wrapped (79 chars)","commit_id":"474cf6c9ca44eb41e04b931771268a14a3ef4848"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"cfa06f6ea22f51b11a7824f5bfb71c0144d5f18a","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        # common on most distributions (SUSE, RedHat, CentOS, Ubuntu, Debian)"},{"line_number":150,"context_line":"        # and it does not depend on correct PATH of the executing user, when trying"},{"line_number":151,"context_line":"        # to find the relative binary."},{"line_number":152,"context_line":"        package \u003d \u0027/sbin/mount.nfs\u0027"},{"line_number":153,"context_line":"        try:"},{"line_number":154,"context_line":"            self._execute(package, check_exit_code\u003dFalse,"},{"line_number":155,"context_line":"                          run_as_root\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_7156efd3","line":152,"updated":"2015-11-04 18:49:34.000000000","message":"Could we do not hardcode path to the binary?","commit_id":"474cf6c9ca44eb41e04b931771268a14a3ef4848"}]}