)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2393fc7ccce7ecfb7d53e19a22b92218c2e85afd","unresolved":false,"context_lines":[{"line_number":13,"context_line":"folder."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch is WIP for now."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Implements: blueprint rebrand-hp-3par-driver"},{"line_number":18,"context_line":"Change-Id: I529429e00ef5e1b7263d40d9d50ed8ac8535d34a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a26ad4f_334604c0","line":16,"updated":"2015-10-30 02:40:19.000000000","message":"DocImpact keyword?","commit_id":"0e6af6df89a35438341562d3936734c708ca01be"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"5e72bfa1099c95b68efe104c8ec3ffd429c2dfa9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"folder."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch is WIP for now."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Implements: blueprint rebrand-hp-3par-driver"},{"line_number":18,"context_line":"Change-Id: I529429e00ef5e1b7263d40d9d50ed8ac8535d34a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1a26ad4f_6e00fc01","line":16,"in_reply_to":"1a26ad4f_334604c0","updated":"2015-10-30 18:19:49.000000000","message":"Done","commit_id":"0e6af6df89a35438341562d3936734c708ca01be"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"58426a9a79fd089cf988701da6a899045d22ebd4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anthony Lee \u003canthony.mic.lee@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-02 15:23:00 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor HP 3PAR drivers to now be HPE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch refactors the HP 3PAR FC and iSCSI drivers to be"},{"line_number":10,"context_line":"HPE 3PAR FC and HPE 3PAR iSCI."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1a26ad4f_22cd02b7","line":7,"updated":"2015-11-02 23:32:01.000000000","message":"Can you please explain why we are doing this?","commit_id":"4802d3face45be6d9b6367657b64b3d5055ef155"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"8b4fc52953c2a0944084366aea97c3e624134657","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Anthony Lee \u003canthony.mic.lee@hpe.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-02 15:23:00 -0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Refactor HP 3PAR drivers to now be HPE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch refactors the HP 3PAR FC and iSCSI drivers to be"},{"line_number":10,"context_line":"HPE 3PAR FC and HPE 3PAR iSCI."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"da85f559_59e7dbab","line":7,"in_reply_to":"1a26ad4f_22cd02b7","updated":"2015-11-11 21:17:00.000000000","message":"Done","commit_id":"4802d3face45be6d9b6367657b64b3d5055ef155"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7edbfe43707d5f975f5d261de381f5cf9bd35eea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Refactor HP 3PAR drivers to now be HPE"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch refactors the HP 3PAR FC and iSCSI drivers to be"},{"line_number":10,"context_line":"HPE 3PAR FC and HPE 3PAR iSCI."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The drivers are now located in the cinder/volume/drivers/hpe"},{"line_number":13,"context_line":"folder."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"da85f559_e3413f64","line":10,"updated":"2015-11-11 20:24:27.000000000","message":"Explain that HPE is Hewlett Packard Enterprise","commit_id":"2c2d11651fea3bd8080935c3c7a8534c3d381019"},{"author":{"_account_id":11047,"name":"Mark Sturdevant","email":"mark.sturdevant@ibm.com","username":"markstur"},"change_message_id":"7edbfe43707d5f975f5d261de381f5cf9bd35eea","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The drivers are now located in the cinder/volume/drivers/hpe"},{"line_number":13,"context_line":"folder."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch is WIP for now."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Implements: blueprint rebrand-hp-3par-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":12,"id":"da85f559_a379f7c9","line":15,"updated":"2015-11-11 20:24:27.000000000","message":"reminder to remove this when ready","commit_id":"2c2d11651fea3bd8080935c3c7a8534c3d381019"}],"cinder/tests/unit/test_hpe3par.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"FILTER_FUNCTION \u003d \\"},{"line_number":53,"context_line":"    \"stats.total_volumes \u003c 400 \u0026\u0026 stats.capacity_utilization \u003c 0.8\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"CHAP_USER_KEY \u003d \"HPQ-cinder-CHAP-name\""},{"line_number":56,"context_line":"CHAP_PASS_KEY \u003d \"HPQ-cinder-CHAP-secret\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"FLASH_CACHE_ENABLED \u003d 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_04ffe934","line":55,"updated":"2015-10-30 20:10:21.000000000","message":"are these staying the same?","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":52,"context_line":"FILTER_FUNCTION \u003d \\"},{"line_number":53,"context_line":"    \"stats.total_volumes \u003c 400 \u0026\u0026 stats.capacity_utilization \u003c 0.8\""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"CHAP_USER_KEY \u003d \"HPQ-cinder-CHAP-name\""},{"line_number":56,"context_line":"CHAP_PASS_KEY \u003d \"HPQ-cinder-CHAP-secret\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"FLASH_CACHE_ENABLED \u003d 1"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_5f9608f1","line":55,"in_reply_to":"1a26ad4f_04ffe934","updated":"2015-10-30 20:57:39.000000000","message":"still deciding whether these need to change","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    RETYPE_VOLUME_TYPE_BAD_PERSONA \u003d {"},{"line_number":384,"context_line":"        \u0027name\u0027: \u0027bad_persona\u0027,"},{"line_number":385,"context_line":"        \u0027id\u0027: \u0027any_id\u0027,"},{"line_number":386,"context_line":"        \u0027extra_specs\u0027: {"},{"line_number":387,"context_line":"            \u0027hp3par:persona\u0027: \u002799 - invalid\u0027"},{"line_number":388,"context_line":"        }"},{"line_number":389,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_6496ddf1","line":386,"updated":"2015-10-30 20:10:21.000000000","message":"hpe3par:persona","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    RETYPE_VOLUME_TYPE_BAD_PERSONA \u003d {"},{"line_number":384,"context_line":"        \u0027name\u0027: \u0027bad_persona\u0027,"},{"line_number":385,"context_line":"        \u0027id\u0027: \u0027any_id\u0027,"},{"line_number":386,"context_line":"        \u0027extra_specs\u0027: {"},{"line_number":387,"context_line":"            \u0027hp3par:persona\u0027: \u002799 - invalid\u0027"},{"line_number":388,"context_line":"        }"},{"line_number":389,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_7ff2e470","line":386,"in_reply_to":"1a26ad4f_6496ddf1","updated":"2015-10-30 20:57:39.000000000","message":"Done","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        \u0027id\u0027: \u0027any_id\u0027,"},{"line_number":394,"context_line":"        \u0027extra_specs\u0027: {"},{"line_number":395,"context_line":"            \u0027cpg\u0027: \u0027bogus\u0027,"},{"line_number":396,"context_line":"            \u0027snap_cpg\u0027: \u0027bogus\u0027,"},{"line_number":397,"context_line":"            \u0027hp3par:persona\u0027: \u00272 - Generic-ALUA\u0027"},{"line_number":398,"context_line":"        }"},{"line_number":399,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_24a0e542","line":396,"updated":"2015-10-30 20:10:21.000000000","message":"hpe3par:persona","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        \u0027id\u0027: \u0027any_id\u0027,"},{"line_number":394,"context_line":"        \u0027extra_specs\u0027: {"},{"line_number":395,"context_line":"            \u0027cpg\u0027: \u0027bogus\u0027,"},{"line_number":396,"context_line":"            \u0027snap_cpg\u0027: \u0027bogus\u0027,"},{"line_number":397,"context_line":"            \u0027hp3par:persona\u0027: \u00272 - Generic-ALUA\u0027"},{"line_number":398,"context_line":"        }"},{"line_number":399,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_1fe97080","line":396,"in_reply_to":"1a26ad4f_24a0e542","updated":"2015-10-30 20:57:39.000000000","message":"Done","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":925,"context_line":"                \u0027qos\u0027: self.QOS,"},{"line_number":926,"context_line":"                \u0027tpvv\u0027: True,"},{"line_number":927,"context_line":"                \u0027tdvv\u0027: False,"},{"line_number":928,"context_line":"                \u0027hp3par:flash_cache\u0027: \u0027true\u0027,"},{"line_number":929,"context_line":"                \u0027volume_type\u0027: self.volume_type_flash_cache}}"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"        with mock.patch.object(hpecommon.HPE3PARCommon,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_a4ab951c","line":928,"updated":"2015-10-30 20:10:21.000000000","message":"hpe3par:flash_cache","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":925,"context_line":"                \u0027qos\u0027: self.QOS,"},{"line_number":926,"context_line":"                \u0027tpvv\u0027: True,"},{"line_number":927,"context_line":"                \u0027tdvv\u0027: False,"},{"line_number":928,"context_line":"                \u0027hp3par:flash_cache\u0027: \u0027true\u0027,"},{"line_number":929,"context_line":"                \u0027volume_type\u0027: self.volume_type_flash_cache}}"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"        with mock.patch.object(hpecommon.HPE3PARCommon,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_df03f840","line":928,"in_reply_to":"1a26ad4f_a4ab951c","updated":"2015-10-30 20:57:39.000000000","message":"Done","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":986,"context_line":"                \u0027qos\u0027: self.QOS,"},{"line_number":987,"context_line":"                \u0027tpvv\u0027: True,"},{"line_number":988,"context_line":"                \u0027tdvv\u0027: False,"},{"line_number":989,"context_line":"                \u0027hp3par:flash_cache\u0027: \u0027true\u0027,"},{"line_number":990,"context_line":"                \u0027volume_type\u0027: self.volume_type_flash_cache}}"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        with mock.patch.object(hpecommon.HPE3PARCommon,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_c4a6d152","line":989,"updated":"2015-10-30 20:10:21.000000000","message":"hpe3par:flash_cache","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":986,"context_line":"                \u0027qos\u0027: self.QOS,"},{"line_number":987,"context_line":"                \u0027tpvv\u0027: True,"},{"line_number":988,"context_line":"                \u0027tdvv\u0027: False,"},{"line_number":989,"context_line":"                \u0027hp3par:flash_cache\u0027: \u0027true\u0027,"},{"line_number":990,"context_line":"                \u0027volume_type\u0027: self.volume_type_flash_cache}}"},{"line_number":991,"context_line":""},{"line_number":992,"context_line":"        with mock.patch.object(hpecommon.HPE3PARCommon,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_fffef436","line":989,"in_reply_to":"1a26ad4f_c4a6d152","updated":"2015-10-30 20:57:39.000000000","message":"Done","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"            expected \u003d ["},{"line_number":1792,"context_line":"                mock.call.setVolumeMetaData("},{"line_number":1793,"context_line":"                    self.VOLUME_3PAR_NAME,"},{"line_number":1794,"context_line":"                    \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":1795,"context_line":"                    \u0027abcdef\u0027)]"},{"line_number":1796,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_447161df","line":1793,"updated":"2015-10-30 20:10:21.000000000","message":"does this need to change?","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":1790,"context_line":""},{"line_number":1791,"context_line":"            expected \u003d ["},{"line_number":1792,"context_line":"                mock.call.setVolumeMetaData("},{"line_number":1793,"context_line":"                    self.VOLUME_3PAR_NAME,"},{"line_number":1794,"context_line":"                    \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":1795,"context_line":"                    \u0027abcdef\u0027)]"},{"line_number":1796,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_3fa30c51","line":1793,"in_reply_to":"1a26ad4f_447161df","updated":"2015-10-30 20:57:39.000000000","message":"still deciding if these need to change","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":1818,"context_line":"            expected \u003d ["},{"line_number":1819,"context_line":"                mock.call.removeVolumeMetaData("},{"line_number":1820,"context_line":"                    self.VOLUME_3PAR_NAME,"},{"line_number":1821,"context_line":"                    \u0027HPQ-CS-instance_uuid\u0027)]"},{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":1824,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_84677924","line":1821,"updated":"2015-10-30 20:10:21.000000000","message":"does this need to change?","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":1818,"context_line":"            expected \u003d ["},{"line_number":1819,"context_line":"                mock.call.removeVolumeMetaData("},{"line_number":1820,"context_line":"                    self.VOLUME_3PAR_NAME,"},{"line_number":1821,"context_line":"                    \u0027HPQ-CS-instance_uuid\u0027)]"},{"line_number":1822,"context_line":""},{"line_number":1823,"context_line":"            mock_client.assert_has_calls(expected)"},{"line_number":1824,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_df8a18bf","line":1821,"in_reply_to":"1a26ad4f_84677924","updated":"2015-10-30 20:57:39.000000000","message":"still deciding if these need to change","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2393fc7ccce7ecfb7d53e19a22b92218c2e85afd","unresolved":false,"context_lines":[{"line_number":998,"context_line":""},{"line_number":999,"context_line":"            pools.append(pool)"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"        self.stats \u003d {\u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":1002,"context_line":"                      \u0027storage_protocol\u0027: None,"},{"line_number":1003,"context_line":"                      \u0027vendor_name\u0027: \u0027Hewlett-Packard\u0027,"},{"line_number":1004,"context_line":"                      \u0027volume_backend_name\u0027: None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_7386bcba","line":1001,"updated":"2015-10-30 02:40:19.000000000","message":"Shouldn\u0027t this reflect latest version?","commit_id":"0e6af6df89a35438341562d3936734c708ca01be"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"5e72bfa1099c95b68efe104c8ec3ffd429c2dfa9","unresolved":false,"context_lines":[{"line_number":998,"context_line":""},{"line_number":999,"context_line":"            pools.append(pool)"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"        self.stats \u003d {\u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":1002,"context_line":"                      \u0027storage_protocol\u0027: None,"},{"line_number":1003,"context_line":"                      \u0027vendor_name\u0027: \u0027Hewlett-Packard\u0027,"},{"line_number":1004,"context_line":"                      \u0027volume_backend_name\u0027: None,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_50391f40","line":1001,"in_reply_to":"1a26ad4f_7386bcba","updated":"2015-10-30 18:19:49.000000000","message":"Done","commit_id":"0e6af6df89a35438341562d3936734c708ca01be"},{"author":{"_account_id":14377,"name":"Apoorva","email":"apps.desh@gmail.com","username":"apoorvad"},"change_message_id":"2393fc7ccce7ecfb7d53e19a22b92218c2e85afd","unresolved":false,"context_lines":[{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"        self.stats \u003d {\u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":1002,"context_line":"                      \u0027storage_protocol\u0027: None,"},{"line_number":1003,"context_line":"                      \u0027vendor_name\u0027: \u0027Hewlett-Packard\u0027,"},{"line_number":1004,"context_line":"                      \u0027volume_backend_name\u0027: None,"},{"line_number":1005,"context_line":"                      \u0027pools\u0027: pools}"},{"line_number":1006,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_93a03845","line":1003,"updated":"2015-10-30 02:40:19.000000000","message":"Do you plan to change this too?","commit_id":"0e6af6df89a35438341562d3936734c708ca01be"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"5e72bfa1099c95b68efe104c8ec3ffd429c2dfa9","unresolved":false,"context_lines":[{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"        self.stats \u003d {\u0027driver_version\u0027: \u00271.0\u0027,"},{"line_number":1002,"context_line":"                      \u0027storage_protocol\u0027: None,"},{"line_number":1003,"context_line":"                      \u0027vendor_name\u0027: \u0027Hewlett-Packard\u0027,"},{"line_number":1004,"context_line":"                      \u0027volume_backend_name\u0027: None,"},{"line_number":1005,"context_line":"                      \u0027pools\u0027: pools}"},{"line_number":1006,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1a26ad4f_103c072e","line":1003,"in_reply_to":"1a26ad4f_93a03845","updated":"2015-10-30 18:19:49.000000000","message":"Done","commit_id":"0e6af6df89a35438341562d3936734c708ca01be"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        \"\"\""},{"line_number":1855,"context_line":"        LOG.debug(\"Attach Volume\\n%s\", pprint.pformat(volume))"},{"line_number":1856,"context_line":"        try:"},{"line_number":1857,"context_line":"            self.update_volume_key_value_pair(volume,"},{"line_number":1858,"context_line":"                                              \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":1859,"context_line":"                                              instance_uuid)"},{"line_number":1860,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_5f75a895","line":1857,"updated":"2015-10-30 20:10:21.000000000","message":"staying?","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":1854,"context_line":"        \"\"\""},{"line_number":1855,"context_line":"        LOG.debug(\"Attach Volume\\n%s\", pprint.pformat(volume))"},{"line_number":1856,"context_line":"        try:"},{"line_number":1857,"context_line":"            self.update_volume_key_value_pair(volume,"},{"line_number":1858,"context_line":"                                              \u0027HPQ-CS-instance_uuid\u0027,"},{"line_number":1859,"context_line":"                                              instance_uuid)"},{"line_number":1860,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_ff8594ac","line":1857,"in_reply_to":"1a26ad4f_5f75a895","updated":"2015-10-30 20:57:39.000000000","message":"still deciding if these should change","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"        \"\"\""},{"line_number":1870,"context_line":"        LOG.debug(\"Detach Volume\\n%s\", pprint.pformat(volume))"},{"line_number":1871,"context_line":"        try:"},{"line_number":1872,"context_line":"            self.clear_volume_key_value_pair(volume, \u0027HPQ-CS-instance_uuid\u0027)"},{"line_number":1873,"context_line":"        except Exception:"},{"line_number":1874,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_7f78a48f","line":1871,"updated":"2015-10-30 20:10:21.000000000","message":"staying?","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":1868,"context_line":""},{"line_number":1869,"context_line":"        \"\"\""},{"line_number":1870,"context_line":"        LOG.debug(\"Detach Volume\\n%s\", pprint.pformat(volume))"},{"line_number":1871,"context_line":"        try:"},{"line_number":1872,"context_line":"            self.clear_volume_key_value_pair(volume, \u0027HPQ-CS-instance_uuid\u0027)"},{"line_number":1873,"context_line":"        except Exception:"},{"line_number":1874,"context_line":"            with excutils.save_and_reraise_exception():"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_bf8f1ccb","line":1871,"in_reply_to":"1a26ad4f_7f78a48f","updated":"2015-10-30 20:57:39.000000000","message":"still deciding if these should change","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"58426a9a79fd089cf988701da6a899045d22ebd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a26ad4f_820176b1","side":"PARENT","line":279,"updated":"2015-11-02 23:32:01.000000000","message":"Why was this removed?","commit_id":"aa6265b1080a0b397ba6664a4f8a2856981301ad"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"8b4fc52953c2a0944084366aea97c3e624134657","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"1a26ad4f_4d3e2f8d","side":"PARENT","line":279,"in_reply_to":"1a26ad4f_820176b1","updated":"2015-11-11 21:17:00.000000000","message":"Done","commit_id":"aa6265b1080a0b397ba6664a4f8a2856981301ad"}],"cinder/volume/drivers/hpe/hpe_3par_fc.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                      driver.BaseVD):"},{"line_number":57,"context_line":"    \"\"\"OpenStack Fibre Channel driver to enable 3PAR storage array."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    Version history:"},{"line_number":60,"context_line":"        1.0   - Initial driver"},{"line_number":61,"context_line":"        1.1   - QoS, extend volume, multiple iscsi ports, remove domain,"},{"line_number":62,"context_line":"                session changes, faster clone, requires 3.1.2 MU2 firmware,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_7f9f44b4","line":59,"updated":"2015-10-30 20:10:21.000000000","message":"preserving changelog?","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                      driver.BaseVD):"},{"line_number":57,"context_line":"    \"\"\"OpenStack Fibre Channel driver to enable 3PAR storage array."},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    Version history:"},{"line_number":60,"context_line":"        1.0   - Initial driver"},{"line_number":61,"context_line":"        1.1   - QoS, extend volume, multiple iscsi ports, remove domain,"},{"line_number":62,"context_line":"                session changes, faster clone, requires 3.1.2 MU2 firmware,"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_5fde0812","line":59,"in_reply_to":"1a26ad4f_7f9f44b4","updated":"2015-10-30 20:57:39.000000000","message":"Yes, the original hp drivers are being removed so it seems good to keep that history in this new file.","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"58426a9a79fd089cf988701da6a899045d22ebd4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def _check_flags(self, common):"},{"line_number":118,"context_line":"        \"\"\"Sanity check to ensure we have required options set.\"\"\""},{"line_number":119,"context_line":"        required_flags \u003d [\u0027hpe3par_api_url\u0027, \u0027hpe3par_username\u0027,"},{"line_number":120,"context_line":"                          \u0027hpe3par_password\u0027,"},{"line_number":121,"context_line":"                          \u0027san_ip\u0027, \u0027san_login\u0027, \u0027san_password\u0027]"},{"line_number":122,"context_line":"        common.check_flags(self.configuration, required_flags)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_826ad67f","line":120,"updated":"2015-11-02 23:32:01.000000000","message":"this breaks backwards compatibility for customers that upgrade.","commit_id":"4802d3face45be6d9b6367657b64b3d5055ef155"},{"author":{"_account_id":8857,"name":"Michael Denny","email":"michael.denny@hp.com","username":"mdenny"},"change_message_id":"5aea84c68b97cb7183402a9b8fd7e173d54e9535","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    def _check_flags(self, common):"},{"line_number":118,"context_line":"        \"\"\"Sanity check to ensure we have required options set.\"\"\""},{"line_number":119,"context_line":"        required_flags \u003d [\u0027hpe3par_api_url\u0027, \u0027hpe3par_username\u0027,"},{"line_number":120,"context_line":"                          \u0027hpe3par_password\u0027,"},{"line_number":121,"context_line":"                          \u0027san_ip\u0027, \u0027san_login\u0027, \u0027san_password\u0027]"},{"line_number":122,"context_line":"        common.check_flags(self.configuration, required_flags)"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_39ae97e6","line":120,"in_reply_to":"1a26ad4f_826ad67f","updated":"2015-11-11 20:58:00.000000000","message":"tested with old config working with deprecated warning and new config hpepassword working as well","commit_id":"4802d3face45be6d9b6367657b64b3d5055ef155"}],"cinder/volume/drivers/hpe/hpe_3par_iscsi.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                         driver.BaseVD):"},{"line_number":62,"context_line":"    \"\"\"OpenStack iSCSI driver to enable 3PAR storage array."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    Version history:"},{"line_number":65,"context_line":"        1.0   - Initial driver"},{"line_number":66,"context_line":"        1.1   - QoS, extend volume, multiple iscsi ports, remove domain,"},{"line_number":67,"context_line":"                session changes, faster clone, requires 3.1.2 MU2 firmware."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_3fa9ccdf","line":64,"updated":"2015-10-30 20:10:21.000000000","message":"preserving changelog?","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                         driver.BaseVD):"},{"line_number":62,"context_line":"    \"\"\"OpenStack iSCSI driver to enable 3PAR storage array."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    Version history:"},{"line_number":65,"context_line":"        1.0   - Initial driver"},{"line_number":66,"context_line":"        1.1   - QoS, extend volume, multiple iscsi ports, remove domain,"},{"line_number":67,"context_line":"                session changes, faster clone, requires 3.1.2 MU2 firmware."}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_1fe890b3","line":64,"in_reply_to":"1a26ad4f_3fa9ccdf","updated":"2015-10-30 20:57:39.000000000","message":"Yes, the hp drivers are being removed so it seems good to keep that history in this new file.","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"58426a9a79fd089cf988701da6a899045d22ebd4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _check_flags(self, common):"},{"line_number":127,"context_line":"        \"\"\"Sanity check to ensure we have required options set.\"\"\""},{"line_number":128,"context_line":"        required_flags \u003d [\u0027hpe3par_api_url\u0027, \u0027hpe3par_username\u0027,"},{"line_number":129,"context_line":"                          \u0027hpe3par_password\u0027, \u0027san_ip\u0027, \u0027san_login\u0027,"},{"line_number":130,"context_line":"                          \u0027san_password\u0027]"},{"line_number":131,"context_line":"        common.check_flags(self.configuration, required_flags)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_620c5aed","line":129,"updated":"2015-11-02 23:32:01.000000000","message":"breaks backwards compatibility for customers that upgrade","commit_id":"4802d3face45be6d9b6367657b64b3d5055ef155"},{"author":{"_account_id":8857,"name":"Michael Denny","email":"michael.denny@hp.com","username":"mdenny"},"change_message_id":"5aea84c68b97cb7183402a9b8fd7e173d54e9535","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    def _check_flags(self, common):"},{"line_number":127,"context_line":"        \"\"\"Sanity check to ensure we have required options set.\"\"\""},{"line_number":128,"context_line":"        required_flags \u003d [\u0027hpe3par_api_url\u0027, \u0027hpe3par_username\u0027,"},{"line_number":129,"context_line":"                          \u0027hpe3par_password\u0027, \u0027san_ip\u0027, \u0027san_login\u0027,"},{"line_number":130,"context_line":"                          \u0027san_password\u0027]"},{"line_number":131,"context_line":"        common.check_flags(self.configuration, required_flags)"},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_d98f4b73","line":129,"in_reply_to":"1a26ad4f_620c5aed","updated":"2015-11-11 20:58:00.000000000","message":"tested with old config working with deprecated warning and new config hpepassword working as well","commit_id":"4802d3face45be6d9b6367657b64b3d5055ef155"}],"cinder/volume/manager.py":[{"author":{"_account_id":16917,"name":"Alex O\u0027Rourke","email":"alex.orourke@hpe.com","username":"aorourke"},"change_message_id":"ae2c916b73abf1c9c3e14c8d17384a2843c8e58b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    \u0027cinder.volume.drivers.hds.iscsi.HDSISCSIDriver\u0027:"},{"line_number":126,"context_line":"    \u0027cinder.volume.drivers.hitachi.hnas_iscsi.HDSISCSIDriver\u0027,"},{"line_number":127,"context_line":"    \u0027cinder.volume.drivers.san.hp.HP3PARFCDriver\u0027:"},{"line_number":128,"context_line":"    \u0027cinder.volume.drivers.hpe.HPE3PARFCDriver\u0027,"},{"line_number":129,"context_line":"    \u0027cinder.volume.drivers.san.hp.HP3PARISCSIDriver\u0027:"},{"line_number":130,"context_line":"    \u0027cinder.volume.drivers.hpe.HPE3PARISCSIDriver\u0027, }"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_1ff410f0","line":128,"updated":"2015-10-30 20:10:21.000000000","message":"does this stuff need to change?","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"13fa1812ce1ff86b39b9354bb9192bcb85da33b9","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    \u0027cinder.volume.drivers.hds.iscsi.HDSISCSIDriver\u0027:"},{"line_number":126,"context_line":"    \u0027cinder.volume.drivers.hitachi.hnas_iscsi.HDSISCSIDriver\u0027,"},{"line_number":127,"context_line":"    \u0027cinder.volume.drivers.san.hp.HP3PARFCDriver\u0027:"},{"line_number":128,"context_line":"    \u0027cinder.volume.drivers.hpe.HPE3PARFCDriver\u0027,"},{"line_number":129,"context_line":"    \u0027cinder.volume.drivers.san.hp.HP3PARISCSIDriver\u0027:"},{"line_number":130,"context_line":"    \u0027cinder.volume.drivers.hpe.HPE3PARISCSIDriver\u0027, }"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1a26ad4f_7f2f44f6","line":128,"in_reply_to":"1a26ad4f_1ff410f0","updated":"2015-10-30 20:57:39.000000000","message":"This part maps the usage of the old driver \u0027cinder.volume.drivers.san.hp.x\u0027 to the new driver at \u0027cinder.volume.drivers.hpe.x\u0027.  This is so cinder.conf entries that point to the old driver path still work when this patch is added.  It also gives a warning message in the logs.","commit_id":"40134f7fbc58bcd00efe6b0541dab4d0349cd2d8"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"58426a9a79fd089cf988701da6a899045d22ebd4","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u0027cinder.volume.drivers.hitachi.hnas_iscsi.HDSISCSIDriver\u0027,"},{"line_number":127,"context_line":"    \u0027cinder.volume.drivers.san.hp.hp_3par_fc.HP3PARFCDriver\u0027:"},{"line_number":128,"context_line":"    \u0027cinder.volume.drivers.hpe.hpe_3par_fc.HPE3PARFCDriver\u0027,"},{"line_number":129,"context_line":"    \u0027cinder.volume.drivers.san.hp..hp_3par_iscsi.HP3PARISCSIDriver\u0027:"},{"line_number":130,"context_line":"    \u0027cinder.volume.drivers.hpe.hpe_3par_iscsi.HPE3PARISCSIDriver\u0027, }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_42391ea3","line":129,"updated":"2015-11-02 23:32:01.000000000","message":"hp..hp_par_iscsi\n\nneed to remove one of the \u0027.\u0027 chars","commit_id":"4802d3face45be6d9b6367657b64b3d5055ef155"},{"author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"change_message_id":"8b4fc52953c2a0944084366aea97c3e624134657","unresolved":false,"context_lines":[{"line_number":126,"context_line":"    \u0027cinder.volume.drivers.hitachi.hnas_iscsi.HDSISCSIDriver\u0027,"},{"line_number":127,"context_line":"    \u0027cinder.volume.drivers.san.hp.hp_3par_fc.HP3PARFCDriver\u0027:"},{"line_number":128,"context_line":"    \u0027cinder.volume.drivers.hpe.hpe_3par_fc.HPE3PARFCDriver\u0027,"},{"line_number":129,"context_line":"    \u0027cinder.volume.drivers.san.hp..hp_3par_iscsi.HP3PARISCSIDriver\u0027:"},{"line_number":130,"context_line":"    \u0027cinder.volume.drivers.hpe.hpe_3par_iscsi.HPE3PARISCSIDriver\u0027, }"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_e2f70a89","line":129,"in_reply_to":"1a26ad4f_42391ea3","updated":"2015-11-11 21:17:00.000000000","message":"Done","commit_id":"4802d3face45be6d9b6367657b64b3d5055ef155"}]}