)]}'
{"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"8afc95bc956e7ee425f619db68a74dc4494c4612","unresolved":false,"context_lines":[{"line_number":1334,"context_line":"                        the other models, which join the volume model in"},{"line_number":1335,"context_line":"                        the database. Currently, the False value for this"},{"line_number":1336,"context_line":"                        parameter is specially for the case of updating"},{"line_number":1337,"context_line":"                        database during volume migration"},{"line_number":1338,"context_line":"    :returns: updated query or None"},{"line_number":1339,"context_line":"    \"\"\""},{"line_number":1340,"context_line":"    if not joined_load:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_7df112cd","line":1337,"updated":"2015-11-03 18:55:49.000000000","message":"We shouldn\u0027t have the note above about volume migration case IMO.  If we need the joined_load option, that\u0027s all well and good but my hope would be that this would be something we\u0027d use in other situations.  Otherwise the migrate calls should be filtering this data out after the fact on its own.\n\nCalling out a specific case like this also means that it\u0027s quite possible that later somebody modifies something and figures \"oh, this isn\u0027t needed any more because I changed migration\" so it gets changed again.\n\nBetter to just leave the specific use case out of it when dealing with the docstring on the API parameter IMO","commit_id":"e84222ea2bb7c04bddafc8470cb3441388722aaa"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"cb5b8a38f149adae3e3e6cb68ed1c757f8ce853e","unresolved":false,"context_lines":[{"line_number":1334,"context_line":"                        the other models, which join the volume model in"},{"line_number":1335,"context_line":"                        the database. Currently, the False value for this"},{"line_number":1336,"context_line":"                        parameter is specially for the case of updating"},{"line_number":1337,"context_line":"                        database during volume migration"},{"line_number":1338,"context_line":"    :returns: updated query or None"},{"line_number":1339,"context_line":"    \"\"\""},{"line_number":1340,"context_line":"    if not joined_load:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_7de592a6","line":1337,"in_reply_to":"fa80f949_7df112cd","updated":"2015-11-03 19:02:28.000000000","message":"I think adding the comment about the volume migration seems to make sense as a commit message comment, not buried in this param comment itself.","commit_id":"e84222ea2bb7c04bddafc8470cb3441388722aaa"}]}