)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2bb6b71d6a94979f5e4fc1cd875bf9b033ba0890","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xing Yang \u003cxing.yang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-07 21:24:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement update_migrated_volume for the ScaleIO driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the update_migrated_volume function"},{"line_number":10,"context_line":"for the ScaleIO driver. Without this, migrate volume does not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa80f949_2883ed05","line":7,"updated":"2015-11-05 17:19:29.000000000","message":"nit: header s/b 50 chars or less.","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"011bf8e7fee7bb13984423fa5305793aca911e14","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Xing Yang \u003cxing.yang@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-07 21:24:40 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implement update_migrated_volume for the ScaleIO driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the update_migrated_volume function"},{"line_number":10,"context_line":"for the ScaleIO driver. Without this, migrate volume does not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_e9ebdd76","line":7,"in_reply_to":"fa80f949_2883ed05","updated":"2015-11-09 16:56:08.000000000","message":"Done","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2bb6b71d6a94979f5e4fc1cd875bf9b033ba0890","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch implements the update_migrated_volume function"},{"line_number":10,"context_line":"for the ScaleIO driver. Without this, migrate volume does not"},{"line_number":11,"context_line":"work properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1512387"},{"line_number":14,"context_line":"Change-Id: I70fe4bd651b0ac87b9208efb5918a4cdaf6f06b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa80f949_a8f35d9d","line":12,"updated":"2015-11-05 17:19:29.000000000","message":"nit: It would help future searches of git log if you added a note that this commit also addresses a TODO now that os-brick 0.4.0 has been released.","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"011bf8e7fee7bb13984423fa5305793aca911e14","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch implements the update_migrated_volume function"},{"line_number":10,"context_line":"for the ScaleIO driver. Without this, migrate volume does not"},{"line_number":11,"context_line":"work properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1512387"},{"line_number":14,"context_line":"Change-Id: I70fe4bd651b0ac87b9208efb5918a4cdaf6f06b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_89033142","line":12,"in_reply_to":"fa80f949_a8f35d9d","updated":"2015-11-09 16:56:08.000000000","message":"Done","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8c73f0eb6e4eeae0367d1af65c9dddf85c7b2ea9","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the update_migrated_volume function"},{"line_number":10,"context_line":"for the ScaleIO driver. Without this, migrate volume does not"},{"line_number":11,"context_line":"work properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1512387"},{"line_number":14,"context_line":"Change-Id: I70fe4bd651b0ac87b9208efb5918a4cdaf6f06b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85f559_a93b9537","line":11,"updated":"2015-11-09 16:54:21.000000000","message":"Doesn\u0027t this mean that there\u0027s a bug elsewhere in the driver w.r.t. name_id vs. id?  Even if you implement update_migrated_volume, are there no other places where this is problematic?\n\nAFAIK update_migrated_volume is an optional usability/cosmetic fix, so I don\u0027t really follow the bug report.","commit_id":"bbb8dd5f315b3306277db96ee104287d6caf1cdc"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"dd6506a4a0992dc0f51bc0c2c421f54120e88c61","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch implements the update_migrated_volume function"},{"line_number":10,"context_line":"for the ScaleIO driver. Without this, migrate volume does not"},{"line_number":11,"context_line":"work properly."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1512387"},{"line_number":14,"context_line":"Change-Id: I70fe4bd651b0ac87b9208efb5918a4cdaf6f06b4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"da85f559_7cbfa0fb","line":11,"in_reply_to":"da85f559_a93b9537","updated":"2015-11-09 21:42:36.000000000","message":"Hi Eric,\n\nWe do need to implement the update_migrated_volume() function for operations after the migrate to work.  Without this change, when the migrate finished, the original volume was deleted but the name on the new volume did not change to the old id even though the Cinder database did update.\n\nThe Volume Name is a base64() encoding of the Cinder Volume ID so any calls after the migrate fail since the lookup fails.\n\nI\u0027ll update the commit message to make it more clear.  Also I\u0027ll provide more details in the bug report.","commit_id":"bbb8dd5f315b3306277db96ee104287d6caf1cdc"}],"cinder/tests/unit/volume/drivers/emc/scaleio/test_misc.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2bb6b71d6a94979f5e4fc1cd875bf9b033ba0890","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_update_migrated_volume(self):"},{"line_number":142,"context_line":"        self.driver.update_migrated_volume("},{"line_number":143,"context_line":"            self.ctx, self.volume, self.new_volume, \u0027available\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_update_unavailable_migrated_volume(self):"},{"line_number":146,"context_line":"        test_vol \u003d self.driver.update_migrated_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_43a972de","line":143,"updated":"2015-11-05 17:19:29.000000000","message":"This test should mock out rename_volume and assert that it is called with appropriate args.\n\nAlso, it should check the model update that is returned.","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"011bf8e7fee7bb13984423fa5305793aca911e14","unresolved":false,"context_lines":[{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def test_update_migrated_volume(self):"},{"line_number":142,"context_line":"        self.driver.update_migrated_volume("},{"line_number":143,"context_line":"            self.ctx, self.volume, self.new_volume, \u0027available\u0027)"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    def test_update_unavailable_migrated_volume(self):"},{"line_number":146,"context_line":"        test_vol \u003d self.driver.update_migrated_volume("}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_a96e3594","line":143,"in_reply_to":"fa80f949_43a972de","updated":"2015-11-09 16:56:08.000000000","message":"Done","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2bb6b71d6a94979f5e4fc1cd875bf9b033ba0890","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        test_vol \u003d self.driver.update_migrated_volume("},{"line_number":147,"context_line":"            self.ctx, self.volume, self.new_volume, \u0027unavailable\u0027)"},{"line_number":148,"context_line":"        self.assertEqual(test_vol[\u0027_name_id\u0027], self.volume[\u0027id\u0027],"},{"line_number":149,"context_line":"                         \u0027Volume ID changed.\u0027)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_fail_update_migrated_volume(self):"},{"line_number":152,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.Invalid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_a3913e9b","line":149,"updated":"2015-11-05 17:19:29.000000000","message":"This test should mock out rename_volume and assert that it is called with appropriate args.\n\nAlso, it should check the model update that is returned.","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"011bf8e7fee7bb13984423fa5305793aca911e14","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        test_vol \u003d self.driver.update_migrated_volume("},{"line_number":147,"context_line":"            self.ctx, self.volume, self.new_volume, \u0027unavailable\u0027)"},{"line_number":148,"context_line":"        self.assertEqual(test_vol[\u0027_name_id\u0027], self.volume[\u0027id\u0027],"},{"line_number":149,"context_line":"                         \u0027Volume ID changed.\u0027)"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def test_fail_update_migrated_volume(self):"},{"line_number":152,"context_line":"        self.set_https_response_mode(self.RESPONSE_MODE.Invalid)"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_69684d88","line":149,"in_reply_to":"fa80f949_a3913e9b","updated":"2015-11-09 16:56:08.000000000","message":"Done","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2bb6b71d6a94979f5e4fc1cd875bf9b033ba0890","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self.volume,"},{"line_number":158,"context_line":"            self.new_volume,"},{"line_number":159,"context_line":"            \u0027available\u0027"},{"line_number":160,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_23cb0ea7","line":160,"updated":"2015-11-05 17:19:29.000000000","message":"It would be good to have unit tests for rename_volume itself.","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"011bf8e7fee7bb13984423fa5305793aca911e14","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            self.volume,"},{"line_number":158,"context_line":"            self.new_volume,"},{"line_number":159,"context_line":"            \u0027available\u0027"},{"line_number":160,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_090661ce","line":160,"in_reply_to":"fa80f949_23cb0ea7","updated":"2015-11-09 16:56:08.000000000","message":"Done","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"}],"cinder/volume/drivers/emc/scaleio.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6ce9e4f4c750352647c0ae1987105d92f425aca0","unresolved":false,"context_lines":[{"line_number":925,"context_line":"        location \u003d None"},{"line_number":926,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":927,"context_line":"            current_name \u003d new_volume[\u0027id\u0027]"},{"line_number":928,"context_line":"            new_name \u003d volume[\u0027id\u0027]"},{"line_number":929,"context_line":"            vol_id \u003d new_volume[\u0027provider_id\u0027]"},{"line_number":930,"context_line":"            LOG.info(_LI(\"Renaming %(id)s from %(old_name)s to %(new_name)s\"),"},{"line_number":931,"context_line":"                     {\u0027id\u0027: vol_id, \u0027old_name\u0027: current_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_4615bb3d","line":928,"updated":"2015-11-02 17:33:08.000000000","message":"I don\u0027t know why, but I can\u0027t get my head around this logic.  You are using the new_volume\u0027s id to get the current name.  And the new_name for the new_volume is the id of the original volume.  I think that matches the description, but for some reason these lines are very confusing.","commit_id":"05179c114d6aa3d5fb87059df75e8680afe398c3"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"53c4e6b5666be3dd7d9ce5732be877bec985f3ec","unresolved":false,"context_lines":[{"line_number":925,"context_line":"        location \u003d None"},{"line_number":926,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":927,"context_line":"            current_name \u003d new_volume[\u0027id\u0027]"},{"line_number":928,"context_line":"            new_name \u003d volume[\u0027id\u0027]"},{"line_number":929,"context_line":"            vol_id \u003d new_volume[\u0027provider_id\u0027]"},{"line_number":930,"context_line":"            LOG.info(_LI(\"Renaming %(id)s from %(old_name)s to %(new_name)s\"),"},{"line_number":931,"context_line":"                     {\u0027id\u0027: vol_id, \u0027old_name\u0027: current_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_8c131f0d","line":928,"in_reply_to":"1a26ad4f_4615bb3d","updated":"2015-11-05 11:00:54.000000000","message":"It is little confusing. The variable current_name is used only in log message and it is possible to use new_volume[\u0027id\u0027] directly there. Also, it is better to use current_name instead of old_name as the keyword argument in the log format string.","commit_id":"05179c114d6aa3d5fb87059df75e8680afe398c3"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4346fa2d3bd6021dfe4de47d5c2baa1436b197ae","unresolved":false,"context_lines":[{"line_number":925,"context_line":"        location \u003d None"},{"line_number":926,"context_line":"        if original_volume_status \u003d\u003d \u0027available\u0027:"},{"line_number":927,"context_line":"            current_name \u003d new_volume[\u0027id\u0027]"},{"line_number":928,"context_line":"            new_name \u003d volume[\u0027id\u0027]"},{"line_number":929,"context_line":"            vol_id \u003d new_volume[\u0027provider_id\u0027]"},{"line_number":930,"context_line":"            LOG.info(_LI(\"Renaming %(id)s from %(old_name)s to %(new_name)s\"),"},{"line_number":931,"context_line":"                     {\u0027id\u0027: vol_id, \u0027old_name\u0027: current_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_83d43a47","line":928,"in_reply_to":"fa80f949_8c131f0d","updated":"2015-11-05 17:34:02.000000000","message":"It is confusing. I added a long note to explain it.  Hope it helps.  I also changed \"old_name\" on line 930 to \"current_name\" so that we use the same term.","commit_id":"05179c114d6aa3d5fb87059df75e8680afe398c3"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6ce9e4f4c750352647c0ae1987105d92f425aca0","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            current_name \u003d new_volume[\u0027id\u0027]"},{"line_number":928,"context_line":"            new_name \u003d volume[\u0027id\u0027]"},{"line_number":929,"context_line":"            vol_id \u003d new_volume[\u0027provider_id\u0027]"},{"line_number":930,"context_line":"            LOG.info(_LI(\"Renaming %(id)s from %(old_name)s to %(new_name)s\"),"},{"line_number":931,"context_line":"                     {\u0027id\u0027: vol_id, \u0027old_name\u0027: current_name,"},{"line_number":932,"context_line":"                      \u0027new_name\u0027: new_name})"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_d34bcb85","line":930,"updated":"2015-11-02 17:33:08.000000000","message":"Suggest \u0027.\u0027 at EOL.","commit_id":"05179c114d6aa3d5fb87059df75e8680afe398c3"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4346fa2d3bd6021dfe4de47d5c2baa1436b197ae","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            current_name \u003d new_volume[\u0027id\u0027]"},{"line_number":928,"context_line":"            new_name \u003d volume[\u0027id\u0027]"},{"line_number":929,"context_line":"            vol_id \u003d new_volume[\u0027provider_id\u0027]"},{"line_number":930,"context_line":"            LOG.info(_LI(\"Renaming %(id)s from %(old_name)s to %(new_name)s\"),"},{"line_number":931,"context_line":"                     {\u0027id\u0027: vol_id, \u0027old_name\u0027: current_name,"},{"line_number":932,"context_line":"                      \u0027new_name\u0027: new_name})"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_c88ca181","line":930,"in_reply_to":"1a26ad4f_d34bcb85","updated":"2015-11-05 17:34:02.000000000","message":"Done","commit_id":"05179c114d6aa3d5fb87059df75e8680afe398c3"},{"author":{"_account_id":9171,"name":"Vipin Balachandran","email":"vipin.bl@gmail.com","username":"vbala"},"change_message_id":"53c4e6b5666be3dd7d9ce5732be877bec985f3ec","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        )"},{"line_number":965,"context_line":"        r \u003d self._check_response(r, request, False, params)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        if r.status_code !\u003d OK_STATUS_CODE:"},{"line_number":968,"context_line":"            response \u003d r.json()"},{"line_number":969,"context_line":"            msg \u003d (_(\"Error renaming volume %(vol)s: %(err)s.\") %"},{"line_number":970,"context_line":"                   {\u0027vol\u0027: vol_id, \u0027err\u0027: response[\u0027message\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_acbb83e4","line":967,"updated":"2015-11-05 11:00:54.000000000","message":"Do we need an info log if it is success? It might help in cleanup if the second rename fails.","commit_id":"05179c114d6aa3d5fb87059df75e8680afe398c3"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4346fa2d3bd6021dfe4de47d5c2baa1436b197ae","unresolved":false,"context_lines":[{"line_number":964,"context_line":"        )"},{"line_number":965,"context_line":"        r \u003d self._check_response(r, request, False, params)"},{"line_number":966,"context_line":""},{"line_number":967,"context_line":"        if r.status_code !\u003d OK_STATUS_CODE:"},{"line_number":968,"context_line":"            response \u003d r.json()"},{"line_number":969,"context_line":"            msg \u003d (_(\"Error renaming volume %(vol)s: %(err)s.\") %"},{"line_number":970,"context_line":"                   {\u0027vol\u0027: vol_id, \u0027err\u0027: response[\u0027message\u0027]})"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_03c12a80","line":967,"in_reply_to":"fa80f949_acbb83e4","updated":"2015-11-05 17:34:02.000000000","message":"Done","commit_id":"05179c114d6aa3d5fb87059df75e8680afe398c3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2bb6b71d6a94979f5e4fc1cd875bf9b033ba0890","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            current_name \u003d new_volume[\u0027id\u0027]"},{"line_number":928,"context_line":"            new_name \u003d volume[\u0027id\u0027]"},{"line_number":929,"context_line":"            vol_id \u003d new_volume[\u0027provider_id\u0027]"},{"line_number":930,"context_line":"            LOG.info(_LI(\"Renaming %(id)s from %(old_name)s to %(new_name)s\"),"},{"line_number":931,"context_line":"                     {\u0027id\u0027: vol_id, \u0027old_name\u0027: current_name,"},{"line_number":932,"context_line":"                      \u0027new_name\u0027: new_name})"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_28d20dd3","line":930,"updated":"2015-11-05 17:19:29.000000000","message":"Add period.","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"011bf8e7fee7bb13984423fa5305793aca911e14","unresolved":false,"context_lines":[{"line_number":927,"context_line":"            current_name \u003d new_volume[\u0027id\u0027]"},{"line_number":928,"context_line":"            new_name \u003d volume[\u0027id\u0027]"},{"line_number":929,"context_line":"            vol_id \u003d new_volume[\u0027provider_id\u0027]"},{"line_number":930,"context_line":"            LOG.info(_LI(\"Renaming %(id)s from %(old_name)s to %(new_name)s\"),"},{"line_number":931,"context_line":"                     {\u0027id\u0027: vol_id, \u0027old_name\u0027: current_name,"},{"line_number":932,"context_line":"                      \u0027new_name\u0027: new_name})"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_69512dd8","line":930,"in_reply_to":"fa80f949_28d20dd3","updated":"2015-11-09 16:56:08.000000000","message":"Done","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"2bb6b71d6a94979f5e4fc1cd875bf9b033ba0890","unresolved":false,"context_lines":[{"line_number":951,"context_line":"        request \u003d (\"https://%(server_ip)s:%(server_port)s\""},{"line_number":952,"context_line":"                   \"/api/instances/Volume::%(id)s/action/setVolumeName\" %"},{"line_number":953,"context_line":"                   req_vars)"},{"line_number":954,"context_line":"        LOG.info(_LI(\"ScaleIO rename volume request: %s\"), request)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"        params \u003d {\u0027newName\u0027: new_name}"},{"line_number":957,"context_line":"        r \u003d requests.post("}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_684b3588","line":954,"updated":"2015-11-05 17:19:29.000000000","message":"Add period.","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"011bf8e7fee7bb13984423fa5305793aca911e14","unresolved":false,"context_lines":[{"line_number":951,"context_line":"        request \u003d (\"https://%(server_ip)s:%(server_port)s\""},{"line_number":952,"context_line":"                   \"/api/instances/Volume::%(id)s/action/setVolumeName\" %"},{"line_number":953,"context_line":"                   req_vars)"},{"line_number":954,"context_line":"        LOG.info(_LI(\"ScaleIO rename volume request: %s\"), request)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"        params \u003d {\u0027newName\u0027: new_name}"},{"line_number":957,"context_line":"        r \u003d requests.post("}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_095f41e6","line":954,"in_reply_to":"fa80f949_684b3588","updated":"2015-11-09 16:56:08.000000000","message":"Done","commit_id":"dad13c8ce7e22df4e6e1ac42852efaf5d8811be1"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"cdc60e030f071c62d9c895e454b3f857ec0e1d00","unresolved":false,"context_lines":[{"line_number":932,"context_line":"            current_name \u003d new_volume[\u0027id\u0027]"},{"line_number":933,"context_line":"            new_name \u003d volume[\u0027id\u0027]"},{"line_number":934,"context_line":"            vol_id \u003d new_volume[\u0027provider_id\u0027]"},{"line_number":935,"context_line":"            LOG.info(_LI(\"Renaming %(id)s from %(current_name)s to \""},{"line_number":936,"context_line":"                         \"%(new_name)s.\"),"},{"line_number":937,"context_line":"                     {\u0027id\u0027: vol_id, \u0027current_name\u0027: current_name,"},{"line_number":938,"context_line":"                      \u0027new_name\u0027: new_name})"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_e3dc26e6","line":935,"updated":"2015-11-05 17:35:17.000000000","message":"good catch.","commit_id":"67a185004bc813e75dfb1313a6a0c2b174236b34"}]}