)]}'
{"cinder/tests/unit/test_ibm_xiv_ds8k.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"51fe3934228b9d9e0b4c84efbc6bfe3a1888d265","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        return {\u0027status\u0027: \u0027available\u0027}, snapshots"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete_cgsnapshot(self, ctxt, cgsnapshot, snapshots):"},{"line_number":267,"context_line":"        # ignore the snapshots parameter in the fake driver"},{"line_number":268,"context_line":"        snapshots \u003d []"},{"line_number":269,"context_line":"        for snapshot in self.snapshots.values():"},{"line_number":270,"context_line":"            if (cgsnapshot.get(\u0027id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_ecad2b9c","line":267,"updated":"2015-11-13 22:54:05.000000000","message":"Why are you ignoring the snapshots parameter?  If snapshots are empty, lines 269-278 won\u0027t do anything.  Just realize it was like this on the left hand side.  Can you fix this to use the passed in snapshots parameter?","commit_id":"9ee67af55bca09ed2fffdcb7c559bfde830e4b8c"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"82e4c9625134dd2e20b0b15714be658e4bc9c7c5","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        return {\u0027status\u0027: \u0027available\u0027}, snapshots"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete_cgsnapshot(self, ctxt, cgsnapshot, snapshots):"},{"line_number":267,"context_line":"        # ignore the snapshots parameter in the fake driver"},{"line_number":268,"context_line":"        snapshots \u003d []"},{"line_number":269,"context_line":"        for snapshot in self.snapshots.values():"},{"line_number":270,"context_line":"            if (cgsnapshot.get(\u0027id\u0027, None)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_fd9dc9bb","line":267,"in_reply_to":"da85f559_ecad2b9c","updated":"2015-11-15 06:28:28.000000000","message":"Done","commit_id":"9ee67af55bca09ed2fffdcb7c559bfde830e4b8c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3676c3813eb3c6f533f74faa02451b727dcca7a6","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        return {\u0027status\u0027: \u0027available\u0027}, snapshots"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete_cgsnapshot(self, ctxt, cgsnapshot, snapshots):"},{"line_number":267,"context_line":"        return_snapshots \u003d []"},{"line_number":268,"context_line":"        for snapshot in snapshots:"},{"line_number":269,"context_line":"            if snapshot[\u0027name\u0027] \u003d\u003d CANNOT_DELETE:"},{"line_number":270,"context_line":"                raise exception.VolumeBackendAPIException("}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_869eaa05","line":267,"updated":"2015-11-15 14:06:20.000000000","message":"If you return it here, the code after this is not doing anything.  Can you remove line 267 so that the code between 268-281 will be run?","commit_id":"551492b4aa368394d53a02a9af548319f685ed6c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5f40891e1c8cf2484f92f0ed961755cdb43be4a1","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        return {\u0027status\u0027: \u0027available\u0027}, snapshots"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete_cgsnapshot(self, ctxt, cgsnapshot, snapshots):"},{"line_number":267,"context_line":"        return_snapshots \u003d []"},{"line_number":268,"context_line":"        for snapshot in snapshots:"},{"line_number":269,"context_line":"            if snapshot[\u0027name\u0027] \u003d\u003d CANNOT_DELETE:"},{"line_number":270,"context_line":"                raise exception.VolumeBackendAPIException("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_8c811892","line":267,"in_reply_to":"ba8a016a_284a7184","updated":"2015-11-16 23:25:36.000000000","message":"I see.  Better to rename it.  I read it as \"return snapshots \u003d [ ]\" :).","commit_id":"551492b4aa368394d53a02a9af548319f685ed6c"},{"author":{"_account_id":10213,"name":"Alon Marx","email":"alonma@il.ibm.com","username":"alonmarx"},"change_message_id":"590b13e7722a8025adc0cddcbd996591d5c7958d","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        return {\u0027status\u0027: \u0027available\u0027}, snapshots"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def delete_cgsnapshot(self, ctxt, cgsnapshot, snapshots):"},{"line_number":267,"context_line":"        return_snapshots \u003d []"},{"line_number":268,"context_line":"        for snapshot in snapshots:"},{"line_number":269,"context_line":"            if snapshot[\u0027name\u0027] \u003d\u003d CANNOT_DELETE:"},{"line_number":270,"context_line":"                raise exception.VolumeBackendAPIException("}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_284a7184","line":267,"in_reply_to":"da85f559_869eaa05","updated":"2015-11-16 15:05:26.000000000","message":"The code will continue after this line - it is just a variable with a name starting with return. Anyway, it is a bad name, and I\u0027ll replace it.","commit_id":"551492b4aa368394d53a02a9af548319f685ed6c"}]}