)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8247,"name":"Thang Pham","email":"thang.g.pham@gmail.com","username":"thang.pham"},"change_message_id":"3eca8151b0e4cb209513e2912696d98362d5ba16","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Port EMC Vmax to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Fix EMCVMAXMasking._get_storage_group_from_masking_view_instance():"},{"line_number":10,"context_line":"  replace \"if len(groups[0]) \u003e 0:\" with \"if len(groups[0]) \u003e 0:\""},{"line_number":11,"context_line":"* tests-py3.txt: add cinder.tests.unit.test_emc_vmax"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Implements: blueprint cinder-python3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_1bb0fadc","line":10,"updated":"2015-11-09 12:27:00.000000000","message":"I think you mean: \"if groups[0] \u003e 0:\" with if len(groups[0]) \u003e 0:","commit_id":"96227852ced5fea79d7e4def00504a9793f58b4a"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"fbce37e9263a9ccfb4cbb4b107436a195beec35b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Port EMC Vmax to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Fix EMCVMAXMasking._get_storage_group_from_masking_view_instance():"},{"line_number":10,"context_line":"  replace \"if len(groups[0]) \u003e 0:\" with \"if len(groups[0]) \u003e 0:\""},{"line_number":11,"context_line":"* tests-py3.txt: add cinder.tests.unit.test_emc_vmax"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Partial-Implements: blueprint cinder-python3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_fb589558","line":10,"in_reply_to":"da85f559_1bb0fadc","updated":"2015-11-09 12:58:34.000000000","message":"Oops, fixed.","commit_id":"96227852ced5fea79d7e4def00504a9793f58b4a"},{"author":{"_account_id":13900,"name":"Accela Zhao","email":"accelazh@gmail.com","username":"accelazh"},"change_message_id":"5e233166deeecbe39b31064d82fcd7ba5fa77b75","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Stinner \u003cvstinner@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-09 13:57:01 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port EMC Vmax to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Fix EMCVMAXMasking._get_storage_group_from_masking_view_instance():"},{"line_number":10,"context_line":"  replace \"if groups[0] \u003e 0:\" with \"if len(groups[0]) \u003e 0:\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_029d0a59","line":7,"updated":"2015-11-13 03:25:16.000000000","message":"Vmax \u003d\u003e VMAX :-)","commit_id":"c14de3ecfd9c999778d123617963b1321b7da591"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3e5e0ae03fb7ab93d4ec957e9c6efbe40f395185","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Victor Stinner \u003cvstinner@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-11-09 13:57:01 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Port EMC Vmax to Python 3"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"* Fix EMCVMAXMasking._get_storage_group_from_masking_view_instance():"},{"line_number":10,"context_line":"  replace \"if groups[0] \u003e 0:\" with \"if len(groups[0]) \u003e 0:\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_618c0b36","line":7,"in_reply_to":"da85f559_029d0a59","updated":"2015-11-13 09:27:11.000000000","message":"Done","commit_id":"c14de3ecfd9c999778d123617963b1321b7da591"}],"cinder/volume/drivers/emc/emc_vmax_masking.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"596b59a060cf534c458a1ddf9dafba19a46dc9cc","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"        groups \u003d conn.AssociatorNames("},{"line_number":1097,"context_line":"            maskingViewInstance,"},{"line_number":1098,"context_line":"            ResultClass\u003d\u0027CIM_DeviceMaskingGroup\u0027)"},{"line_number":1099,"context_line":"        if len(groups[0]) \u003e 0:"},{"line_number":1100,"context_line":"            foundStorageGroupInstanceName \u003d groups[0]"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"        return foundStorageGroupInstanceName"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_5fc76d64","line":1099,"updated":"2015-11-13 02:47:31.000000000","message":"Should be \"if len(groups) \u003e 0\" or \"if groups\".  We are checking if the returned list is empty here.  groups[0] is  StorageGroupInstanceName, not a number.  The original code on the left hand side is not right.","commit_id":"c14de3ecfd9c999778d123617963b1321b7da591"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3e5e0ae03fb7ab93d4ec957e9c6efbe40f395185","unresolved":false,"context_lines":[{"line_number":1096,"context_line":"        groups \u003d conn.AssociatorNames("},{"line_number":1097,"context_line":"            maskingViewInstance,"},{"line_number":1098,"context_line":"            ResultClass\u003d\u0027CIM_DeviceMaskingGroup\u0027)"},{"line_number":1099,"context_line":"        if len(groups[0]) \u003e 0:"},{"line_number":1100,"context_line":"            foundStorageGroupInstanceName \u003d groups[0]"},{"line_number":1101,"context_line":""},{"line_number":1102,"context_line":"        return foundStorageGroupInstanceName"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_219da359","line":1099,"in_reply_to":"da85f559_5fc76d64","updated":"2015-11-13 09:27:11.000000000","message":"Ok, I used \"if len(group):\".\n\nNote: Many other lines use \"if len(...) \u003e 0:\" but I don\u0027t want to modify them (\"if len(...):\") in the same change (nor write a dedicated change for them).","commit_id":"c14de3ecfd9c999778d123617963b1321b7da591"}]}