)]}'
{"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"afe198f5c352cc50b106567c9ea617946bd352da","unresolved":false,"context_lines":[{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        for (k, v) in diff[\u0027encryption\u0027].items():"},{"line_number":781,"context_line":"            if v[0] !\u003d v[1]:"},{"line_number":782,"context_line":"                LOG.error(_LE(\u0027Retype of encryption type not supported.\u0027))"},{"line_number":783,"context_line":"                return False"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        for (k, v) in diff[\u0027extra_specs\u0027].items():"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_ffc0387e","line":782,"updated":"2015-11-10 16:03:39.000000000","message":"I agree with Jon\u0027s comment below that the message should be improved.  I think that you need to note here that it is failing because the encryption types differ and for when the extra_specs differ below.","commit_id":"d22d0d9ed0f41ed07e9b550b711a2670f05ed5fc"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"9053d6776ebe76426009175671010b1ef11920ea","unresolved":false,"context_lines":[{"line_number":781,"context_line":"            if v[0] !\u003d v[1]:"},{"line_number":782,"context_line":"                LOG.error(_LE(\u0027Retype of encryption type not supported.\u0027))"},{"line_number":783,"context_line":"                return False"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"        for (k, v) in diff[\u0027extra_specs\u0027].items():"},{"line_number":786,"context_line":"            if v[0] !\u003d v[1]:"},{"line_number":787,"context_line":"                LOG.error(_LE(\u0027Retype of extra_specs not supported.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_dccf827d","line":784,"updated":"2015-11-10 15:53:56.000000000","message":"Since you\u0027re not using \u0027k\u0027, you could instead use \u0027_\u0027 to denote that it\u0027s unused in this block.\n\nAlso, the I think the messages could be a bit more descriptive, it\u0027s not that retype isn\u0027t support, but rather that retype where encryption values are not identical that\u0027s not supported. Though obviously the messages above this block suffer in the same way.\n\nThose are just nitpicks though, overall I think this change is well done.","commit_id":"d22d0d9ed0f41ed07e9b550b711a2670f05ed5fc"},{"author":{"_account_id":15961,"name":"lisali","email":"xiaoyan.li@intel.com","username":"lisali"},"change_message_id":"03459ed0c070de6e47d8480bd442ec6194ad9d83","unresolved":false,"context_lines":[{"line_number":777,"context_line":"            LOG.error(_LE(\u0027Retype with host migration is not supported.\u0027))"},{"line_number":778,"context_line":"            return False"},{"line_number":779,"context_line":""},{"line_number":780,"context_line":"        for (unused, v) in diff[\u0027encryption\u0027].items():"},{"line_number":781,"context_line":"            if v[0] !\u003d v[1]:"},{"line_number":782,"context_line":"                LOG.error(_LE(\u0027Retype between volume types with different \u0027"},{"line_number":783,"context_line":"                              \u0027encryption types is not supported.\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_d1071780","line":780,"updated":"2015-11-12 02:48:31.000000000","message":"We don\u0027t care key here, why not use diff[\u0027encryption\u0027].values() here?","commit_id":"e3150fa18673bea6df83b7f0807b08f686a733a5"}]}