)]}'
{"cinder/tests/unit/windows/test_smbfs.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"0fd4fbdad7d3adf2834a143bad68461189c56bcb","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                self._FAKE_VOLUME_PATH, mock.sentinel.volume_format,"},{"line_number":220,"context_line":"                mock.sentinel.block_size)"},{"line_number":221,"context_line":"            drv._vhdutils.resize_vhd.assert_called_once_with("},{"line_number":222,"context_line":"                self._FAKE_VOLUME_PATH, self._FAKE_VOLUME[\u0027size\u0027] \u003c\u003c 30)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_copy_volume_from_snapshot(self):"},{"line_number":225,"context_line":"        drv \u003d self._smbfs_driver"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_613fccd6","line":222,"updated":"2016-01-13 17:26:06.000000000","message":"units.Gi instead?","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3e28db3e7fea3729de190512339211e6e12ac52d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                self._FAKE_VOLUME_PATH, mock.sentinel.volume_format,"},{"line_number":220,"context_line":"                mock.sentinel.block_size)"},{"line_number":221,"context_line":"            drv._vhdutils.resize_vhd.assert_called_once_with("},{"line_number":222,"context_line":"                self._FAKE_VOLUME_PATH, self._FAKE_VOLUME[\u0027size\u0027] \u003c\u003c 30)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_copy_volume_from_snapshot(self):"},{"line_number":225,"context_line":"        drv \u003d self._smbfs_driver"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_9c56d928","line":222,"in_reply_to":"da6ed579_613fccd6","updated":"2016-01-13 21:37:56.000000000","message":"For ease of readability I agree. This should be changed throughout.","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"0fd4fbdad7d3adf2834a143bad68461189c56bcb","unresolved":false,"context_lines":[{"line_number":249,"context_line":"            mock.sentinel.new_volume_path)"},{"line_number":250,"context_line":"        drv._vhdutils.resize_vhd.assert_called_once_with("},{"line_number":251,"context_line":"            mock.sentinel.new_volume_path,"},{"line_number":252,"context_line":"            self._FAKE_VOLUME[\u0027size\u0027] \u003c\u003c 30)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    def test_rebase_img(self):"},{"line_number":255,"context_line":"        drv \u003d self._smbfs_driver"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_4113a866","line":252,"updated":"2016-01-13 17:26:06.000000000","message":"ditto.","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"}],"cinder/tests/unit/windows/test_windows.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"0fd4fbdad7d3adf2834a143bad68461189c56bcb","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @mock.patch.object(fileutils, \u0027ensure_tree\u0027)"},{"line_number":47,"context_line":"    @mock.patch.object(windows, \u0027utilsfactory\u0027)"},{"line_number":48,"context_line":"    def test_do_setup(self, mock_utilsfactory, mock_ensure_tree):"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        self._driver.do_setup(mock.sentinel.context)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.assertEqual(mock_utilsfactory.get_vhdutils.return_value,"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_44a65611","line":49,"updated":"2016-01-13 17:26:06.000000000","message":"this line can be removed.","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b6edf497902738790b77963cb2b539be5bd5b11d","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            mock.sentinel.tmp_snap_name,"},{"line_number":376,"context_line":"            mock.sentinel.vol_vhd_path)"},{"line_number":377,"context_line":"        self._driver._vhdutils.resize_vhd.assert_called_once_with("},{"line_number":378,"context_line":"            mock.sentinel.vol_vhd_path, fake_volume[\u0027size\u0027] \u003c\u003c 30,"},{"line_number":379,"context_line":"            is_file_max_size\u003dFalse)"},{"line_number":380,"context_line":"        tgt_utils.import_wt_disk.assert_called_once_with("},{"line_number":381,"context_line":"            mock.sentinel.vol_vhd_path, fake_volume[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_88942643","line":378,"updated":"2016-01-14 14:47:29.000000000","message":"Few instances here that should be switched to using units.Gi as well.","commit_id":"a6faaa02a7d8a8a04165e00015e2e1d5b88547f6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f6b8cbe9014454faa546051150affd1b8f3f2cd0","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            mock.sentinel.tmp_snap_name,"},{"line_number":376,"context_line":"            mock.sentinel.vol_vhd_path)"},{"line_number":377,"context_line":"        self._driver._vhdutils.resize_vhd.assert_called_once_with("},{"line_number":378,"context_line":"            mock.sentinel.vol_vhd_path, fake_volume[\u0027size\u0027] \u003c\u003c 30,"},{"line_number":379,"context_line":"            is_file_max_size\u003dFalse)"},{"line_number":380,"context_line":"        tgt_utils.import_wt_disk.assert_called_once_with("},{"line_number":381,"context_line":"            mock.sentinel.vol_vhd_path, fake_volume[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_e254d5fe","line":378,"in_reply_to":"da6ed579_88942643","updated":"2016-01-14 17:28:36.000000000","message":"Done","commit_id":"a6faaa02a7d8a8a04165e00015e2e1d5b88547f6"}],"cinder/volume/drivers/windows/windows.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"0fd4fbdad7d3adf2834a143bad68461189c56bcb","unresolved":false,"context_lines":[{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    def _update_volume_stats(self):"},{"line_number":245,"context_line":"        \"\"\"Retrieve stats info for Windows device.\"\"\""},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        LOG.debug(\"Updating volume stats\")"},{"line_number":248,"context_line":"        data \u003d {}"},{"line_number":249,"context_line":"        backend_name \u003d self.__class__.__name__"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_1ee42f0b","side":"PARENT","line":246,"updated":"2016-01-13 17:26:06.000000000","message":"didn\u0027t have to be removed, IMO.","commit_id":"9ae6f0de65e94315ab25c3a448855c68f6e54621"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"0fd4fbdad7d3adf2834a143bad68461189c56bcb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        self._tgt_utils.create_wt_disk(vhd_path, vol_name,"},{"line_number":134,"context_line":"                                       size_mb\u003dvol_size_mb)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def local_path(self, volume, disk_format\u003dNone):"},{"line_number":137,"context_line":"        base_vhd_folder \u003d self.configuration.windows_iscsi_lun_path"},{"line_number":138,"context_line":"        if not disk_format:"},{"line_number":139,"context_line":"            disk_format \u003d self._tgt_utils.get_supported_disk_format()"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_c4c9e679","line":136,"updated":"2016-01-13 17:26:06.000000000","message":"uncovered.","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"0fd4fbdad7d3adf2834a143bad68461189c56bcb","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                                  enabled\u003dTrue)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @contextlib.contextmanager"},{"line_number":237,"context_line":"    def temporary_snapshot(self, volume_name):"},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            snap_uuid \u003d uuidutils.generate_uuid()"},{"line_number":240,"context_line":"            snapshot_name \u003d \u0027%s-tmp-snapshot-%s\u0027 % (volume_name, snap_uuid)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_bec5e33c","line":237,"updated":"2016-01-13 17:26:06.000000000","message":"is this going to be called outside this module? if not, private method?","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"3e28db3e7fea3729de190512339211e6e12ac52d","unresolved":false,"context_lines":[{"line_number":234,"context_line":"                                                  enabled\u003dTrue)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    @contextlib.contextmanager"},{"line_number":237,"context_line":"    def temporary_snapshot(self, volume_name):"},{"line_number":238,"context_line":"        try:"},{"line_number":239,"context_line":"            snap_uuid \u003d uuidutils.generate_uuid()"},{"line_number":240,"context_line":"            snapshot_name \u003d \u0027%s-tmp-snapshot-%s\u0027 % (volume_name, snap_uuid)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_5c1aa17e","line":237,"in_reply_to":"da6ed579_bec5e33c","updated":"2016-01-13 21:37:56.000000000","message":"Agreed","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"0fd4fbdad7d3adf2834a143bad68461189c56bcb","unresolved":false,"context_lines":[{"line_number":288,"context_line":"        LOG.debug(\"Updating volume stats\")"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"        total_gb, free_gb \u003d self._get_capacity_info()"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        data \u003d {}"},{"line_number":293,"context_line":"        backend_name \u003d self.configuration.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":294,"context_line":"        data[\"volume_backend_name\"] \u003d backend_name or self.__class__.__name__"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_5e862714","line":291,"updated":"2016-01-13 17:26:06.000000000","message":"one of those new lines can be removed.","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"0fd4fbdad7d3adf2834a143bad68461189c56bcb","unresolved":false,"context_lines":[{"line_number":299,"context_line":"        data[\u0027free_capacity_gb\u0027] \u003d free_gb"},{"line_number":300,"context_line":"        data[\u0027reserved_percentage\u0027] \u003d self.configuration.reserved_percentage"},{"line_number":301,"context_line":"        data[\u0027QoS_support\u0027] \u003d False"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"        self._stats \u003d data"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def extend_volume(self, volume, new_size):"}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_bec9637a","line":302,"updated":"2016-01-13 17:26:06.000000000","message":"didn\u0027t have to be added, IMO.","commit_id":"5eeada2465d60ad1315759c9a3ecf4c451fccacc"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"dfe1cf55f9efcb09c727ab4ac61885eb9d675195","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        Called one time by the manager after the driver is loaded."},{"line_number":63,"context_line":"        Validate the flags we care about"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        self._vhdutils \u003d utilsfactory.get_vhdutils()"},{"line_number":66,"context_line":"        self._tgt_utils \u003d utilsfactory.get_iscsi_target_utils()"},{"line_number":67,"context_line":"        self._hostutils \u003d utilsfactory.get_hostutils()"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_a3b90c17","line":65,"updated":"2016-01-14 15:08:45.000000000","message":"Please initialize these three vars to None in __init__.","commit_id":"a6faaa02a7d8a8a04165e00015e2e1d5b88547f6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"36dd751ef18ec237a4d710da9335db74219c7117","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        Called one time by the manager after the driver is loaded."},{"line_number":63,"context_line":"        Validate the flags we care about"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        self._vhdutils \u003d utilsfactory.get_vhdutils()"},{"line_number":66,"context_line":"        self._tgt_utils \u003d utilsfactory.get_iscsi_target_utils()"},{"line_number":67,"context_line":"        self._hostutils \u003d utilsfactory.get_hostutils()"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ba63e191_0402ce6f","line":65,"in_reply_to":"da6ed579_82b4f934","updated":"2016-01-19 17:17:07.000000000","message":"This is ok for now, but we\u0027ll probably end up moving them back to do_setup later once we have the infrastructure for soft dependencies sorted out.  os_win a perfect candidate to be a soft dependency.","commit_id":"a6faaa02a7d8a8a04165e00015e2e1d5b88547f6"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"f6b8cbe9014454faa546051150affd1b8f3f2cd0","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        Called one time by the manager after the driver is loaded."},{"line_number":63,"context_line":"        Validate the flags we care about"},{"line_number":64,"context_line":"        \"\"\""},{"line_number":65,"context_line":"        self._vhdutils \u003d utilsfactory.get_vhdutils()"},{"line_number":66,"context_line":"        self._tgt_utils \u003d utilsfactory.get_iscsi_target_utils()"},{"line_number":67,"context_line":"        self._hostutils \u003d utilsfactory.get_hostutils()"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_82b4f934","line":65,"in_reply_to":"da6ed579_a3b90c17","updated":"2016-01-14 17:28:36.000000000","message":"I\u0027ve just moved those completely to __init__. Seemed a bit safer.\n\nThanks for pointing this out.","commit_id":"a6faaa02a7d8a8a04165e00015e2e1d5b88547f6"}]}