)]}'
{"cinder/api/v2/volumes.py":[{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"f795764af5ad917484754228c46218653712d292","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        limit \u003d params.pop(\u0027limit\u0027, None)"},{"line_number":180,"context_line":"        sort_key \u003d params.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":181,"context_line":"        sort_dir \u003d params.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":182,"context_line":"        offset \u003d params.pop(\u0027offset\u0027, None)"},{"line_number":183,"context_line":"        filters \u003d params"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        remove_invalid_options(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Ftns%3D","line":182,"updated":"2013-03-15 15:28:32.000000000","message":"Offset not used","commit_id":"d92ba2cf0cc5ccd7cfa4e77b4356efa235f0003a"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"2817a7af8e784b9f9c4c0cc610cb94b63ad50fb7","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        limit \u003d params.pop(\u0027limit\u0027, None)"},{"line_number":180,"context_line":"        sort_key \u003d params.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":181,"context_line":"        sort_dir \u003d params.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":182,"context_line":"        offset \u003d params.pop(\u0027offset\u0027, None)"},{"line_number":183,"context_line":"        filters \u003d params"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        remove_invalid_options(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F9jY%3D","line":182,"in_reply_to":"AAAAN3%2F%2Ftm0%3D","updated":"2013-03-19 09:35:07.000000000","message":"So you can just pop it, without assigning it to a variable.","commit_id":"d92ba2cf0cc5ccd7cfa4e77b4356efa235f0003a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"2c14d9fa33b858a8faec67b7fd4239bfe1f9ad8b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        limit \u003d params.pop(\u0027limit\u0027, None)"},{"line_number":180,"context_line":"        sort_key \u003d params.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":181,"context_line":"        sort_dir \u003d params.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":182,"context_line":"        offset \u003d params.pop(\u0027offset\u0027, None)"},{"line_number":183,"context_line":"        filters \u003d params"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        remove_invalid_options(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2Ftm0%3D","line":182,"in_reply_to":"AAAAN3%2F%2Ftns%3D","updated":"2013-03-15 15:35:52.000000000","message":"Good question, actually it\u0027s used at here https://github.com/openstack/cinder/blob/master/cinder/api/common.py#L89\nIf we don\u0027t pop it at here, it will be used as a filter condition and cause empty output.","commit_id":"d92ba2cf0cc5ccd7cfa4e77b4356efa235f0003a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"46ee900d849beec07ef1ad801bb21c9363c87b37","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        limit \u003d params.pop(\u0027limit\u0027, None)"},{"line_number":180,"context_line":"        sort_key \u003d params.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":181,"context_line":"        sort_dir \u003d params.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":182,"context_line":"        offset \u003d params.pop(\u0027offset\u0027, None)"},{"line_number":183,"context_line":"        filters \u003d params"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        remove_invalid_options(context,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F8JU%3D","line":182,"in_reply_to":"AAAAOH%2F%2F9jY%3D","updated":"2013-03-20 03:55:23.000000000","message":"+1 for no unused variable.","commit_id":"d92ba2cf0cc5ccd7cfa4e77b4356efa235f0003a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"6c3192a229db3685010f1d40e867cc68989873b5","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            filters[\u0027display_name\u0027] \u003d filters[\u0027name\u0027]"},{"line_number":191,"context_line":"            del filters[\u0027name\u0027]"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            if limit is not None:"},{"line_number":195,"context_line":"                limit \u003d int(limit)"},{"line_number":196,"context_line":"                if limit \u003c 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F%2FQM%3D","line":193,"updated":"2013-03-18 04:16:24.000000000","message":"I know there are still places on this layer that are doing validation, but I would really like to see this on the base api layer in case someone is using the cinder module.","commit_id":"d92ba2cf0cc5ccd7cfa4e77b4356efa235f0003a"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"46ee900d849beec07ef1ad801bb21c9363c87b37","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            filters[\u0027display_name\u0027] \u003d filters[\u0027name\u0027]"},{"line_number":191,"context_line":"            del filters[\u0027name\u0027]"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            if limit is not None:"},{"line_number":195,"context_line":"                limit \u003d int(limit)"},{"line_number":196,"context_line":"                if limit \u003c 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F8Jc%3D","line":193,"in_reply_to":"AAAAOH%2F%2F%2FL8%3D","updated":"2013-03-20 03:55:23.000000000","message":"cinder.volume.api.API\n\nWhat you\u0027re doing validates for the REST API layer, but does not validate for something interacting with API class.","commit_id":"d92ba2cf0cc5ccd7cfa4e77b4356efa235f0003a"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"2a7caf4b1f39dffa02b3a92dc4903fe4e83b037c","unresolved":false,"context_lines":[{"line_number":190,"context_line":"            filters[\u0027display_name\u0027] \u003d filters[\u0027name\u0027]"},{"line_number":191,"context_line":"            del filters[\u0027name\u0027]"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            if limit is not None:"},{"line_number":195,"context_line":"                limit \u003d int(limit)"},{"line_number":196,"context_line":"                if limit \u003c 0:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAOH%2F%2F%2FL8%3D","line":193,"in_reply_to":"AAAAOH%2F%2F%2FQM%3D","updated":"2013-03-18 13:07:34.000000000","message":"Mike, it would be nice if you can explain more about \"on the base api layer\". Since based on my understanding, /volumes is almost on the top level. Thanks.","commit_id":"d92ba2cf0cc5ccd7cfa4e77b4356efa235f0003a"}],"cinder/tests/api/v2/test_volumes.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"431d91113efab91994273648c0d2a7fcb96999da","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":450,"context_line":"        volumes \u003d res_dict[\u0027volumes\u0027]"},{"line_number":451,"context_line":"        self.assertEquals(len(volumes), 1)"},{"line_number":452,"context_line":"        self.assertEquals(volumes[0][\u0027id\u0027], 2)"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"    def test_volume_detail_with_marker(self):"},{"line_number":455,"context_line":"        def stub_volume_get_all_by_project(context, project_id, marker, limit,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2FvaY%3D","line":452,"updated":"2013-03-14 10:11:25.000000000","message":"It will be great if we can have the exception cases.","commit_id":"c1c471ab91bb80629aaf092fba2752be2608e6d1"}],"cinder/volume/api.py":[{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"b4dede2bcfeb73577acd70eb407739c282d4c51d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import functools"},{"line_number":24,"context_line":"import webob"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo.config import cfg"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOH%2F%2F6dI%3D","line":24,"updated":"2013-03-21 04:42:51.000000000","message":"use cinder.exception.Invalid instead of importing webob.","commit_id":"a293957f5b8d693e59404cc42fd40385d16036e8"},{"author":{"_account_id":6484,"name":"Feilong Wang","email":"hustemb@gmail.com","username":"flwang"},"change_message_id":"ea2eeb3b28c2194e4e77b8b30c43dce5bdf87b2d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"\"\"\""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"import functools"},{"line_number":24,"context_line":"import webob"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from oslo.config import cfg"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOH%2F%2F6b4%3D","line":24,"in_reply_to":"AAAAOH%2F%2F6dI%3D","updated":"2013-03-21 05:39:12.000000000","message":"Done","commit_id":"a293957f5b8d693e59404cc42fd40385d16036e8"}]}