)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ecace057cbd54469f27469131d53239b030e06dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"EMC VMAX - VMAX driver failing to remove zones"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This is regression.  The population of the target_wwns and"},{"line_number":10,"context_line":"init_targ_map should occur before the terminate_connection"},{"line_number":11,"context_line":"and not after."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_297d98e7","line":9,"updated":"2015-11-13 01:13:46.000000000","message":"Can you please identify what change caused the regression?","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ecace057cbd54469f27469131d53239b030e06dc","unresolved":false,"context_lines":[{"line_number":10,"context_line":"init_targ_map should occur before the terminate_connection"},{"line_number":11,"context_line":"and not after."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"Closes-Bug: #1501938"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I3a896a1fcdfd9c09a4c8fa5a1f7fb7253ff36715"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"da85f559_2916f8a7","line":13,"updated":"2015-11-13 01:13:46.000000000","message":"This doesn\u0027t need a \"DocImpact\" flag.  It is an internal bug fix.","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"}],"cinder/volume/drivers/emc/emc_vmax_fc.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ecace057cbd54469f27469131d53239b030e06dc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":43,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":44,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":45,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3 Bug 5\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_0903f477","line":45,"updated":"2015-11-13 01:13:46.000000000","message":"What does \"Bug 5\" mean?  \"Bug\" should not be part of the version.","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9d14e5553c1ed00e62df797489d56eb7768ebf6f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":43,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":44,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":45,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3 Bug 5\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_5ac0902a","line":45,"in_reply_to":"ba8a016a_cdee3322","updated":"2015-11-17 17:40:38.000000000","message":"I am going to change it to \n2.3 - Bug fix - Cleanup Zoning","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"324dc39c5cd263d22d091bb60379bccd14e00667","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":43,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":44,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":45,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3 Bug 5\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_d747b91b","line":45,"in_reply_to":"da85f559_0903f477","updated":"2015-11-13 10:07:56.000000000","message":"So it should be 2.3.5?","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"b6924fe7d301df704d1a5541da09be177844450f","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":43,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":44,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":45,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3 Bug 5\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_cdee3322","line":45,"in_reply_to":"da85f559_ac63a3dc","updated":"2015-11-17 04:03:58.000000000","message":"If you are going to use the same versioning style we used in Liberty, then this should be 2.3.1.  This is because the other 4 patches won\u0027t necessarily get merged before this one.  You\u0027ll have to resolve the merge conflict if this is merged after your other patch.\n\nThe only way to avoid the merge conflict is to make one patch dependent on another, but then you\u0027ll have to update all patches if you modify one of them.","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8b527711b89f1f8de1440a890189d965a179fb44","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":43,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":44,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":45,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3 Bug 5\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_ac63a3dc","line":45,"in_reply_to":"da85f559_d747b91b","updated":"2015-11-13 22:44:43.000000000","message":"Should be as follows if you are going to use one version for all Mitaka patches.\n\n2.3 - Cleanup zoning\n\nSee example here:\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/emc/emc_cli_iscsi.py#L52","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ecace057cbd54469f27469131d53239b030e06dc","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3 Bug 5\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_c9fc0c75","line":48,"updated":"2015-11-13 01:13:46.000000000","message":"See above comment.","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"52f3328ceb2c356f46196c2c1667c6094d4842d5","unresolved":false,"context_lines":[{"line_number":45,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":46,"context_line":"    \"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    VERSION \u003d \"2.3 Bug 5\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_9ac6f847","line":48,"updated":"2015-11-17 17:44:27.000000000","message":"Is this a new naming convention for versions? Using  revision should read Cleaning Zoning (bug ########) and the verison would be 2.3.5","commit_id":"1036fc07d55da5d48ec5a8b36083af4bef764238"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"501cf573ae490a25a356f4be50267eca0f1a3b09","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"            LOG.debug(\"Looking for masking views still associated with \""},{"line_number":228,"context_line":"                      \"Port Group %s.\", portGroupInstanceName)"},{"line_number":229,"context_line":"            mvInstances \u003d self.common.get_masking_views_by_port_group("},{"line_number":230,"context_line":"                portGroupInstanceName)"},{"line_number":231,"context_line":"            if len(mvInstances) \u003e 0:"},{"line_number":232,"context_line":"                LOG.debug(\"Found %(numViews)lu MaskingViews.\","}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_13a8ea1e","line":229,"updated":"2016-01-12 16:40:25.000000000","message":"Doesn\u0027t seem like the logic will work if looking for MV instances by port group. There could be a lot of other masking views for different VMs using the same port group, but we still need to cleanup the masking view for this VM/host, right?","commit_id":"8e875d6f34d4896baef0bc69effbda9fa69dc42e"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"57ccb0e769147ff88e8ead6d668c771e8c508594","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"            LOG.debug(\"Looking for masking views still associated with \""},{"line_number":228,"context_line":"                      \"Port Group %s.\", portGroupInstanceName)"},{"line_number":229,"context_line":"            mvInstances \u003d self.common.get_masking_views_by_port_group("},{"line_number":230,"context_line":"                portGroupInstanceName)"},{"line_number":231,"context_line":"            if len(mvInstances) \u003e 0:"},{"line_number":232,"context_line":"                LOG.debug(\"Found %(numViews)lu MaskingViews.\","}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_39dcede3","line":229,"in_reply_to":"da6ed579_13a8ea1e","updated":"2016-01-12 17:15:06.000000000","message":"Hi Carl,  The masking view for this VM/host will have been deleted in the terminate_connection line 225 if there are no more volumes in the storage group contained in the MV.","commit_id":"8e875d6f34d4896baef0bc69effbda9fa69dc42e"},{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"282a969f5fe8d9416d8d71a42f512c59a5f9dba0","unresolved":false,"context_lines":[{"line_number":226,"context_line":""},{"line_number":227,"context_line":"            LOG.debug(\"Looking for masking views still associated with \""},{"line_number":228,"context_line":"                      \"Port Group %s.\", portGroupInstanceName)"},{"line_number":229,"context_line":"            mvInstances \u003d self.common.get_masking_views_by_port_group("},{"line_number":230,"context_line":"                portGroupInstanceName)"},{"line_number":231,"context_line":"            if len(mvInstances) \u003e 0:"},{"line_number":232,"context_line":"                LOG.debug(\"Found %(numViews)lu MaskingViews.\","}],"source_content_type":"text/x-python","patch_set":10,"id":"da6ed579_62ab8a8a","line":229,"in_reply_to":"da6ed579_39dcede3","updated":"2016-01-12 17:51:24.000000000","message":"I had a typo in my comment. I should have said \"cleanup the zoning\" instead of MV. If no mvInstances are found, then it falls into the \"else:\" branch below which adds the keys to the data dict that will allow zoning to be cleaned up. My comment is it won\u0027t fall into that branch since len(mvInstances) will be greater than 0 in general unless this is a fresh install.\n\nInstead, you should be checking whether \"mvInstanceName\" (obtained earlier) still exists. If it does not exist, then fall into the else branch for zoning cleanup.","commit_id":"8e875d6f34d4896baef0bc69effbda9fa69dc42e"}],"cinder/volume/drivers/emc/emc_vmax_iscsi.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ecace057cbd54469f27469131d53239b030e06dc","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3 Bug 5\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"da85f559_89f7e48b","line":56,"updated":"2015-11-13 01:13:46.000000000","message":"Please see comment in the other file.","commit_id":"f5deb30b0d5d4d151750071363a3645d7443562c"},{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"52f3328ceb2c356f46196c2c1667c6094d4842d5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":51,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":52,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":53,"context_line":"        2.3 Bug 5 - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3 Bug 5\""}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_5a8f30cc","line":53,"updated":"2015-11-17 17:44:27.000000000","message":"I think this should be 2.3.5 with the bug number, see 2.1.1, 2.1.2 and 2.1.3 for an example","commit_id":"1036fc07d55da5d48ec5a8b36083af4bef764238"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2dc2f4844f4bb4db7cd6846c57ca8cc17001df3","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":51,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":52,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":53,"context_line":"        2.3   - Bug - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3\""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_9c633f41","line":53,"updated":"2015-11-23 23:17:31.000000000","message":"There is no such thing as zoning in iSCSI","commit_id":"fdd5488d544605067f50afe170043c692f1a2247"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5669eeb38fc38ccab1a924039071335d47c9204f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":51,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":52,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":53,"context_line":"        2.3   - Bug - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_888239ff","line":53,"in_reply_to":"9a8ffd7b_72515662","updated":"2015-11-25 15:42:18.000000000","message":"Walt,\n\nYou are right that this change is for FC only and looks odd here, but we are trying to keep the same versioning for FC and iSCSI drivers so it is easier for us to keep it straight:).\n\nHelen,\n\nCan you add a note here?\n\n2.3  - Cleanup Zoning (bug #1501938; This fix applies to FC only)","commit_id":"fdd5488d544605067f50afe170043c692f1a2247"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5cdbe2f9c83fdc39ada9f315d51e8302346681a9","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":51,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":52,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":53,"context_line":"        2.3   - Bug - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_331cdec0","line":53,"in_reply_to":"9a8ffd7b_888239ff","updated":"2015-11-25 15:57:08.000000000","message":"Will do","commit_id":"fdd5488d544605067f50afe170043c692f1a2247"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d8ad61453f69d4776734fbc5caff70f8e5a6e678","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        2.2.2 - Update Consistency Group"},{"line_number":51,"context_line":"        2.2.3 - Pool aware scheduler(multi-pool) support"},{"line_number":52,"context_line":"        2.2.4 - Create CG from CG snapshot"},{"line_number":53,"context_line":"        2.3   - Bug - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_72515662","line":53,"in_reply_to":"ba8a016a_9c633f41","updated":"2015-11-24 11:27:39.000000000","message":"Correct, this is an FC fix","commit_id":"fdd5488d544605067f50afe170043c692f1a2247"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"c2dc2f4844f4bb4db7cd6846c57ca8cc17001df3","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        2.3   - Bug - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_bc772301","line":56,"updated":"2015-11-23 23:17:31.000000000","message":"But this patch doesn\u0027t even change this file, and it\u0027s completely unrelated to the FC problem described in the bug ?","commit_id":"fdd5488d544605067f50afe170043c692f1a2247"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"5669eeb38fc38ccab1a924039071335d47c9204f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        2.3   - Bug - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_c8604138","line":56,"in_reply_to":"9a8ffd7b_52021240","updated":"2015-11-25 15:42:18.000000000","message":"Helen,\n\nCan you add a note in the commit message that this fix is for FC driver only and you bumped the iSCSI driver version because we want to keep the same version for both drivers?","commit_id":"fdd5488d544605067f50afe170043c692f1a2247"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5cdbe2f9c83fdc39ada9f315d51e8302346681a9","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        2.3   - Bug - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_b3868ed9","line":56,"in_reply_to":"9a8ffd7b_c8604138","updated":"2015-11-25 15:57:08.000000000","message":"Will do","commit_id":"fdd5488d544605067f50afe170043c692f1a2247"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d8ad61453f69d4776734fbc5caff70f8e5a6e678","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        2.3   - Bug - Cleanup Zoning"},{"line_number":54,"context_line":"    \"\"\""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    VERSION \u003d \"2.3\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_52021240","line":56,"in_reply_to":"ba8a016a_bc772301","updated":"2015-11-24 11:27:39.000000000","message":"That is correct.  The versioning is for the entire VMAX plugin, not just for FC or ISCSI.  Most fixes are relevant to both, there are the few where it is just applicable to just FC or just ISCSI.","commit_id":"fdd5488d544605067f50afe170043c692f1a2247"}],"cinder/volume/drivers/emc/emc_vmax_masking.py":[{"author":{"_account_id":12802,"name":"Carl Pecinovsky","email":"csky@us.ibm.com","username":"carl-sky"},"change_message_id":"03a0134ad9314fbedaebd88be654f5298e0e41fd","unresolved":false,"context_lines":[{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":"    def get_masking_views_by_initiator_group("},{"line_number":2146,"context_line":"            self, conn, initiatorGroupInstanceName):"},{"line_number":2147,"context_line":"        \"\"\"Given port group, retrieve the masking view instance name."},{"line_number":2148,"context_line":""},{"line_number":2149,"context_line":"        :param conn: the ecom connection"},{"line_number":2150,"context_line":"        :param portGroupInstanceName: the instance name of the port group"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_83c83b56","line":2147,"updated":"2016-01-15 18:37:45.000000000","message":"The doc string is wrong as it repeatedly refers to port groups and portGroupInstanceName","commit_id":"74f5b5b516d48b8b6fc3667787a10d7815b5f882"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9ee2b990d338af448d5bb71482f1483bb4cd6304","unresolved":false,"context_lines":[{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":"    def get_masking_views_by_initiator_group("},{"line_number":2146,"context_line":"            self, conn, initiatorGroupInstanceName):"},{"line_number":2147,"context_line":"        \"\"\"Given port group, retrieve the masking view instance name."},{"line_number":2148,"context_line":""},{"line_number":2149,"context_line":"        :param conn: the ecom connection"},{"line_number":2150,"context_line":"        :param portGroupInstanceName: the instance name of the port group"}],"source_content_type":"text/x-python","patch_set":11,"id":"da6ed579_b2f22f6e","line":2147,"in_reply_to":"da6ed579_83c83b56","updated":"2016-01-18 10:21:31.000000000","message":"Thanks.  I will change this","commit_id":"74f5b5b516d48b8b6fc3667787a10d7815b5f882"}]}