)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"f180ea8c761b19ec1e7240362e9f5479e31d533f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Sheepdog: Optimization of error handling"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Every function which calls the _run_dog() method need to handle the"},{"line_number":10,"context_line":"connect error. I think it\u0027s better to handle this error centralize"},{"line_number":11,"context_line":"in _run_dog() method to simplify code."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib1eb3044e583b46a8a42f820bf780600415122e8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_2f5a6984","line":10,"updated":"2015-11-16 19:40:51.000000000","message":"Suggest: \"Since each place where _run_dog() is called needs to handle a connection error, it would be more efficient to handle it inside the _run_dog() method.\"","commit_id":"b25d45a0cf491f8d59e00d771653b625f66caaf6"}],"cinder/volume/drivers/sheepdog.py":[{"author":{"_account_id":16708,"name":"Kendall Nelson","display_name":"Kendall (diablo_rojo)","email":"kennelson11@gmail.com","username":"kjnelson"},"change_message_id":"f180ea8c761b19ec1e7240362e9f5479e31d533f","unresolved":false,"context_lines":[{"line_number":300,"context_line":"    def get_volume_stats(self):"},{"line_number":301,"context_line":"        try:"},{"line_number":302,"context_line":"            (_stdout, _stderr) \u003d self._run_dog(\u0027node\u0027, \u0027info\u0027, \u0027-r\u0027)"},{"line_number":303,"context_line":"        except exception.SheepdogCmdError as e:"},{"line_number":304,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":305,"context_line":"                LOG.error(_LE(\u0027Failed to get volume status. \u0027))"},{"line_number":306,"context_line":"        return _stdout"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_afc41940","line":303,"updated":"2015-11-16 19:40:51.000000000","message":"It\u0027s failing pep8 because e gets assigned here and then never used in your logging below. Maybe refactor to get rid of it since you are no longer setting it to _stderr to use inside the with statement?","commit_id":"b25d45a0cf491f8d59e00d771653b625f66caaf6"},{"author":{"_account_id":13203,"name":"Wilson Liu","email":"295988511@qq.com","username":"Bob-OpenStack"},"change_message_id":"d6649708a44554068c88546a26e71307dd3fb3b5","unresolved":false,"context_lines":[{"line_number":302,"context_line":"            (_stdout, _stderr) \u003d self._run_dog(\u0027node\u0027, \u0027info\u0027, \u0027-r\u0027)"},{"line_number":303,"context_line":"        except exception.SheepdogCmdError as e:"},{"line_number":304,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":305,"context_line":"                LOG.error(_LE(\u0027Failed to get volume status. %s\u0027) % e)"},{"line_number":306,"context_line":"        return _stdout"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9a8ffd7b_46403d07","line":305,"updated":"2015-11-28 13:54:09.000000000","message":"Please change \"%\" to \",\":\nLOG.error(_LE(\u0027Failed to get volume status. %s\u0027), e)","commit_id":"2b997dd659ceb84b6dae562fed6d33ec4254a126"}]}