)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"d2ebf2f19ac1197275bb3a28f3330f363ffc80db","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cinder is using \u0027metadata\u0027 to return volume metadata instead"},{"line_number":10,"context_line":"of previous \u0027volume_metadata\u0027, so VNX could not get the correct existing"},{"line_number":11,"context_line":"metadata, only append VNX specific metadata so existing"},{"line_number":12,"context_line":"metadata get overridden."},{"line_number":13,"context_line":"In this fix, VNX will use \u0027metadata\u0027 when getting metadata."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1215883a6076e9b15b1ced19aa40aae43c66a00c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_44e4320c","line":12,"updated":"2015-11-17 19:10:10.000000000","message":"Can you reword this a little bit?  Some functions (i.e., create_volume) in Cinder have been converted to use versioned objects and the volume object has \u0027metadata\u0027.  Other functions (i.e., migrate_volume) have not been converted yet and they are still getting volume from DB directly and it still contains \u0027volume_metadata\u0027.","commit_id":"fb50ed9451b65deef4b3262d35df6927a0533905"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"c13eb9b6840f9a866a4f7be334ce0b74a9c31a0e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Cinder is using \u0027metadata\u0027 to return volume metadata instead"},{"line_number":10,"context_line":"of previous \u0027volume_metadata\u0027, so VNX could not get the correct existing"},{"line_number":11,"context_line":"metadata, only append VNX specific metadata so existing"},{"line_number":12,"context_line":"metadata get overridden."},{"line_number":13,"context_line":"In this fix, VNX will use \u0027metadata\u0027 when getting metadata."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1215883a6076e9b15b1ced19aa40aae43c66a00c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba8a016a_9f03310d","line":12,"in_reply_to":"ba8a016a_44e4320c","updated":"2015-11-18 03:00:06.000000000","message":"Updated, please take a review again\n\nThanks\nPeter","commit_id":"fb50ed9451b65deef4b3262d35df6927a0533905"}],"cinder/volume/drivers/emc/emc_vnx_cli.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"4eebe5c6c38730a3359ea35e6bdfdf445647bdb5","unresolved":false,"context_lines":[{"line_number":2967,"context_line":"        return model_update"},{"line_number":2968,"context_line":""},{"line_number":2969,"context_line":"    def _get_volume_metadata(self, volume):"},{"line_number":2970,"context_line":"        return volume[\u0027metadata\u0027] if \u0027metadata\u0027 in volume else {}"},{"line_number":2971,"context_line":""},{"line_number":2972,"context_line":"    def dumps_provider_location(self, pl_dict):"},{"line_number":2973,"context_line":"        return \u0027|\u0027.join([k + \u0027^\u0027 + pl_dict[k] for k in pl_dict])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_a4387ea1","line":2970,"updated":"2015-11-17 19:05:22.000000000","message":"I think the code needs to take care of both \u0027volume_metadata\u0027 and \u0027metadata\u0027 at this point.  create_volume has been converted to use versioned objects, so it is \u0027metadata\u0027.  migrate_volume has not been converted yet.  It is still getting volume from db and it is still \u0027volume_metadata\u0027.","commit_id":"fb50ed9451b65deef4b3262d35df6927a0533905"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"c13eb9b6840f9a866a4f7be334ce0b74a9c31a0e","unresolved":false,"context_lines":[{"line_number":2967,"context_line":"        return model_update"},{"line_number":2968,"context_line":""},{"line_number":2969,"context_line":"    def _get_volume_metadata(self, volume):"},{"line_number":2970,"context_line":"        return volume[\u0027metadata\u0027] if \u0027metadata\u0027 in volume else {}"},{"line_number":2971,"context_line":""},{"line_number":2972,"context_line":"    def dumps_provider_location(self, pl_dict):"},{"line_number":2973,"context_line":"        return \u0027|\u0027.join([k + \u0027^\u0027 + pl_dict[k] for k in pl_dict])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_fc0dab3e","line":2970,"in_reply_to":"ba8a016a_a4387ea1","updated":"2015-11-18 03:00:06.000000000","message":"Thanks for the reminder.\n\ndone","commit_id":"fb50ed9451b65deef4b3262d35df6927a0533905"},{"author":{"_account_id":8912,"name":"Ryan McNair","email":"rdmcnair@us.ibm.com","username":"rdmcnair"},"change_message_id":"c014a007028a78d1ff38d7f2981c2a9dc9399c83","unresolved":false,"context_lines":[{"line_number":2974,"context_line":"        if \u0027volume_metadata\u0027 in volume:"},{"line_number":2975,"context_line":"            for metadata in volume[\u0027volume_metadata\u0027]:"},{"line_number":2976,"context_line":"                volume_metadata[metadata[\u0027key\u0027]] \u003d metadata[\u0027value\u0027]"},{"line_number":2977,"context_line":"            return volume_metadata"},{"line_number":2978,"context_line":"        return volume[\u0027metadata\u0027] if \u0027metadata\u0027 in volume else {}"},{"line_number":2979,"context_line":""},{"line_number":2980,"context_line":"    def dumps_provider_location(self, pl_dict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_2ee2c02f","line":2977,"updated":"2015-11-19 14:19:07.000000000","message":"Equivalent to \"return volume.get(\u0027metadata\u0027, {})\"","commit_id":"e32aaf82a37ac09c3180dbe7476287db24237452"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"a715025a3e99d4f53743579940503f709e8e6d1d","unresolved":false,"context_lines":[{"line_number":2974,"context_line":"        if \u0027volume_metadata\u0027 in volume:"},{"line_number":2975,"context_line":"            for metadata in volume[\u0027volume_metadata\u0027]:"},{"line_number":2976,"context_line":"                volume_metadata[metadata[\u0027key\u0027]] \u003d metadata[\u0027value\u0027]"},{"line_number":2977,"context_line":"            return volume_metadata"},{"line_number":2978,"context_line":"        return volume[\u0027metadata\u0027] if \u0027metadata\u0027 in volume else {}"},{"line_number":2979,"context_line":""},{"line_number":2980,"context_line":"    def dumps_provider_location(self, pl_dict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_a4ea4f72","line":2977,"in_reply_to":"ba8a016a_2ee2c02f","updated":"2015-11-19 14:55:44.000000000","message":"Does seem like this could be cleaned up as Ryan suggests.  Certainly up to  you, but it would be much improved in terms of readability.","commit_id":"e32aaf82a37ac09c3180dbe7476287db24237452"},{"author":{"_account_id":10628,"name":"Peter Wang","email":"peter.wang13@emc.com","username":"peter_wang"},"change_message_id":"aee95ed5ad69e1eea64ec33f03ddfa151125250f","unresolved":false,"context_lines":[{"line_number":2974,"context_line":"        if \u0027volume_metadata\u0027 in volume:"},{"line_number":2975,"context_line":"            for metadata in volume[\u0027volume_metadata\u0027]:"},{"line_number":2976,"context_line":"                volume_metadata[metadata[\u0027key\u0027]] \u003d metadata[\u0027value\u0027]"},{"line_number":2977,"context_line":"            return volume_metadata"},{"line_number":2978,"context_line":"        return volume[\u0027metadata\u0027] if \u0027metadata\u0027 in volume else {}"},{"line_number":2979,"context_line":""},{"line_number":2980,"context_line":"    def dumps_provider_location(self, pl_dict):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_c055d8f9","line":2977,"in_reply_to":"ba8a016a_2ee2c02f","updated":"2015-11-20 05:06:11.000000000","message":"Thanks, Ryan and John\n\nI will address this comment in a following up patch\nwhen versioned_object transition is finished.","commit_id":"e32aaf82a37ac09c3180dbe7476287db24237452"}]}